From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC16E3F9CB for ; Mon, 29 Jan 2024 17:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706550885; cv=none; b=pBYypBJDv3ZqUmiG54v5xf0hM09mJv8jNU7qyKwyr/B3061HEq3fv3Z77/sRi04n9zhJddDUFkagsw1FTqFpmFrCtVxJXNhwQUZONBEzR4KRyesgGqqKYHZ26LrDMSBOBzbzrsu0ZEhxeARqVv43wzYsuz6jiQEUbtCVEc8zcV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706550885; c=relaxed/simple; bh=sAiDrWDvVVNWIyyIYoWKyxgVvvGZG7qFK/Y4jjOK1X4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ok7vXBp1reAJrgISH3YOlQ49GC78qbLroBfHSPFTgnfpEwyCemHDrvGP5Wm0RqzKeqBo/7DbbDpttNJNYzre0wg4fJf8j3EFAC+vPOOW9Jn/rcTjN0pay6okAsoGly3wmiXlzcAgR6V2O5TC7p2ufvqUjuZA5ODBfR0UtA5ZdfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s1oUzxO5; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s1oUzxO5" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40e76109cdeso40649525e9.0 for ; Mon, 29 Jan 2024 09:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706550882; x=1707155682; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bVR5nbml2aTFOfaqC+3gdwm2ez6gyOkqhxn8ov2iG9U=; b=s1oUzxO5TcDKxerv50P2Eu+maFVK90LzeNaoEKygLuTcqRWHzVgIKA+6EbaCSHDlts v3oUIxwq5Cq3OIqW6N1R5Ji9yPhsMkdISfY9JvfK/hRYYprgjCUaUOoffyJrweiDNAbp C8Yut6D3YV5tuylenpmKonVs1G0E1efBrEnh2A4MtimiblSkfVN//embb3TCplmhQOXH nBcCKx9G/WsrWaMa0BIVTtgSBhAytMeGAwwvb+ziXOBL8Km87vkrycMF+4HKnxmktfMg 2brdOf7WZ1PQihSFjxBiKUh/uWdQrcwOSs1pebA1T38tCJFHggAAo3foGy36DeE6+R+k 8TZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706550882; x=1707155682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bVR5nbml2aTFOfaqC+3gdwm2ez6gyOkqhxn8ov2iG9U=; b=UaCnxNS5cGRx+iexmbrQbZ6Ea6BtFHAz4S9Sx5iyEDD13ha69/C7QKfex9rvnLnOkk BClaUiI2qzIMKQmF/G86U8WQl2y1orxqE5Wo/1b3/jvLW/qrc0FEEioVxGxvGyz9B89s Y6Nqeyt4QAwgK6b8ornXxjEkcAxLrQWWyLYcptave1QZVs69qQUR0M34AO2860z+xMzT lhCQyCnw1zxrFbSYyhDoul5Pov1lcn0dUB8S4KQetcGW8A71AMTCTKjlZ4gF9jcI22rg TrvjSHwzcIeyuINWFwnPDdIzJeUGU6Qr4fHVnbuK4FHG7aU0p5S3UVHqtEPbpzKzt95S bQ7w== X-Gm-Message-State: AOJu0YzaVH6FVCe6bZ0v8+aAJiMfSVkm957AiVbn9hnMHRPwsfNpIxjk OkoXxzNRmLSRI6ZrHRD0LPFZdI3r0O+TS1f2l9M3oec8GnCpYpuDYJzZ9xxMA8c= X-Google-Smtp-Source: AGHT+IEauaKrcKGiyoN2Xoj5HFoaMjvt5k+EqMXaiXSNB17XmoJT9k5CaAzrvbvkQlKtnhHo/F+H4A== X-Received: by 2002:adf:ea4b:0:b0:33a:f024:271f with SMTP id j11-20020adfea4b000000b0033af024271fmr2073808wrn.68.1706550882039; Mon, 29 Jan 2024 09:54:42 -0800 (PST) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id az27-20020adfe19b000000b0033af4fbce50sm1306081wrb.3.2024.01.29.09.54.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 09:54:41 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 18:54:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal/sysfs: Always enable hysteresis write support To: "Rafael J. Wysocki" , Manaf Meethalavalappu Pallikunhi Cc: Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240106191502.29126-1-quic_manafm@quicinc.com> <921c2f90-fb8b-4e70-9e3d-6e185fec03b6@linaro.org> <41b284d7-e31f-48b5-8b21-0dca3e23cb1c@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Rafael, On 29/01/2024 18:07, Rafael J. Wysocki wrote: [ ... ] >> Index: linux-pm/drivers/thermal/thermal_sysfs.c >> =================================================================== >> --- linux-pm.orig/drivers/thermal/thermal_sysfs.c >> +++ linux-pm/drivers/thermal/thermal_sysfs.c >> @@ -474,7 +474,8 @@ static int create_trip_attrs(struct ther >> tz->trip_hyst_attrs[indx].name; >> tz->trip_hyst_attrs[indx].attr.attr.mode = S_IRUGO; >> tz->trip_hyst_attrs[indx].attr.show = trip_point_hyst_show; >> - if (tz->ops->set_trip_hyst) { >> + if (IS_ENABLED(CONFIG_THERMAL_WRITABLE_TRIPS) && >> + mask & (1 << indx)) { >> tz->trip_hyst_attrs[indx].attr.attr.mode |= S_IWUSR; >> tz->trip_hyst_attrs[indx].attr.store = >> trip_point_hyst_store; > > So it looks like I need to submit this, even though I'm not sure if > anyone cares. > > In any case, I care about consistency. Yeah, sorry for the delay. I'll have a look at it tomorrow -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog