From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D17F8345CD5 for ; Thu, 4 Dec 2025 13:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855594; cv=none; b=MMnIXEwB3XeU6Va1MJu3d8hP84uKmnfVFCEraT31cThTo11DNoCeCrvg03L/nB68SEeWMPqDy06mrG3UT3tnuR9XO9xSJQuvjhZLC6+QBQnMt/SjmuJg+DC4DdtxK2AecJHKWBVJO4MWpbyQJ0UntdFUNcDkK+Dt/Jbk23L52Hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855594; c=relaxed/simple; bh=Byady7NBttcZvBzss9LmHECB2eAKN21blUD0eYYKe0s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=frE5DaHUsZRiXaKz/830UWYctfee1pgo0oyT/uLgYA985TgcxsUJvWJ50p+cBW96H5zzgq28TCM44BYUzXos7y5g6e+SteQHN8sNt9XjAYfY7l/BbcZUgzOKHQqUbSi0LWIPDpPeEgCM0XhWM/rHvE3EP7SagP+1Qd0bH2pKQjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aXCf2S6T; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aXCf2S6T" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-64320b9bb4bso1886145a12.0 for ; Thu, 04 Dec 2025 05:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764855590; x=1765460390; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FpH8Z+iCPRMm2GQp2wva6RkvWE9tQWZcrTCI041rIRk=; b=aXCf2S6T5JHiBNdGKgzOuYKbVxitbZAi+CCp3poZmCxklN5zCzuZjavEzR6ynOicJn rUZl8yjBg28RSxtK5kJeBx2MGti1rN4puPK/0wjO22YOpYoJqw9XSCSJYtej76FxdCtc J7TWoZktA1+Yz33AssytQ0kYNIeXfpZF85ocPbjzq0lnuTyCAeua7law+YJ/Fhab983a apqQVdcLcNBOuHUXB4CQgxqeCJPye3Xih2eRlVoZjGFUUiltpbexk8/+hzTV1PEsng0E UlYhL1OuZZxM9+SL5yFJ57taf4KYD0WJEsZuEe4U1IkSBSbieCdqk8KNzag/kxTbTOyu K57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764855590; x=1765460390; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FpH8Z+iCPRMm2GQp2wva6RkvWE9tQWZcrTCI041rIRk=; b=XJL8a5mHilacFQTZgh5LnDtprE3sqTNq3kiqQEeJ0qWFjdMWfIFc7sYQTsGCxYMOwh 1h/7W1cRmNpCvnbsAkJnE6CFAGKXEXlH5QlyPEk+9oBk4OnAKiQgMdT+DPjhQuSpYNuB m6Cl8wMGs++D4BI4VHVxW3xH4HnrI/ULFJDMhIyRhJDetCKzbHYlIeiKvR92TOu9ZY39 hMHEcj+5nqSTSgWVImt5f/LMFwTCCd+GDvkdDkrUtYVlhStYmyHXD06CQd1FA3JhZas7 yiJYdZQDadgmg04DRbu4ZX5plIbsP3xQy3YM5adBljh6R4787B2HkVyQVie1nNUa1FAE NVxw== X-Forwarded-Encrypted: i=1; AJvYcCVlCRac8tE9Plw1P+iBfhzkShq7r6yMeovGj9DPR4cpmGPOBeLV9ie7mCOsUheOsm2TMvFxL31FLiX2OWY=@vger.kernel.org X-Gm-Message-State: AOJu0YwHGJqEsWUR3dhGBZjYErHc4gVh7p/wdLCF0REY+13gxATZRNaV U35spuXOsvVKN29UTnwbA7uSfwBVNImFBQ2huX8laZRyqIZjP1yCNHut X-Gm-Gg: ASbGnct3klTatfD8hmvXv8fS00/z7dZKStuODimFtw+7Jc6bJbVJDbKqlDCXXhpf9w1 0mDzQ0G9n9dprlknaP34B1OGyPka3/QMQ5HWzj678NunQHXXZhZYYgd3FX6r7W0mBTBuwn9OMT5 2pOCgUI2z32BGhFK4yB48oKjawU+JNNs7gngpk/DOh4jtdcNCsS52fnDU5HedoqzsUXMwgHn9WB cj/IaUUbZiwvw+mbFaENpgqC51PiA4YcYBfj2MNaZPSuzVaSBfg/8XHs7+DG7NotLXRcB8S/4Sf Ob6hNtLeFieAOrfyKB3v29zfTLy4az69J2/9AOn5boVdfApp02kmZf96vVY72Hf7mwxntUFByCH 7ecpVPWBo+XCGlNER/jGozbrPNgmdjceMvz56rk6ckNzj67mAW/OXzkY4tYiR6ua2aIDrFGK4MA geV7iWfpl5YPleG/DFUgQQAwlrtUjr4HuyEIDyfTZhUCqGLVMX5WddKEIAr/MlFz2qzFMG0GaZ X-Google-Smtp-Source: AGHT+IHyxocklivKXDBa3Wth7R4D/VqTLCwo+FByG3Nl3VEFRJTgTKno+GZt80pxVvvVR/fSlLKsgg== X-Received: by 2002:a05:6402:40ce:b0:647:62ba:123b with SMTP id 4fb4d7f45d1cf-647a6a23982mr3154351a12.9.1764855589895; Thu, 04 Dec 2025 05:39:49 -0800 (PST) Received: from [192.168.0.2] (dslb-002-205-018-238.002.205.pools.vodafone-ip.de. [2.205.18.238]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-647b368de06sm1265575a12.22.2025.12.04.05.39.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 05:39:49 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 14:39:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] broadcom: b44: prevent uninitialized value usage To: Alexey Simakov , Michael Chan Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michael Buesch , "John W. Linville" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20251204052243.5824-1-bigalex934@gmail.com> From: Jonas Gorski Content-Language: en-US In-Reply-To: <20251204052243.5824-1-bigalex934@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 12/4/25 06:22, Alexey Simakov wrote: > On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy() > leaves bmcr value uninitialized and it is used later in the code. > > Add check of this flag at the beginning of the b44_nway_reset() and > exit early of the function if an external PHY is used, that would > also correspond to other b44_readphy() call sites. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Fixes: 753f492093da ("[B44]: port to native ssb support") > Signed-off-by: Alexey Simakov > --- > drivers/net/ethernet/broadcom/b44.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c > index 0353359c3fe9..cbfd65881326 100644 > --- a/drivers/net/ethernet/broadcom/b44.c > +++ b/drivers/net/ethernet/broadcom/b44.c > @@ -1789,6 +1789,9 @@ static int b44_nway_reset(struct net_device *dev) > u32 bmcr; > int r; > > + if (bp->flags & B44_FLAG_EXTERNAL_PHY) > + return 0; Wouldn't the right fix here to call phy_ethtool_nway_reset(dev->phydev); instead of just returning 0? That way it properly restarts auto-negotiation even in this case. > + > spin_lock_irq(&bp->lock); > b44_readphy(bp, MII_BMCR, &bmcr); > b44_readphy(bp, MII_BMCR, &bmcr); Best regards, Jonas