From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24D746B5 for ; Mon, 13 Jan 2025 12:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736770721; cv=none; b=Y70rr7uH+D4VfdH4NRvJhK+ql+hhrIYWN0hlCcWrv+Vh6o+Og1yUx52JFZKR9mPwqwIvyn80SQPFPrwCZJ9xp27q3rhed8pOXB32hGWBWbqCRabj51Qgp2NyQYfTyc+TuSvVdB6F+EoQk52bILj8rSApcnkyDaWbUEpI5fInKiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736770721; c=relaxed/simple; bh=WifrLQgJuMfmI/ucbTFaipkWuZj+DemDUpDW2BE6JBM=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=QM7PcWJqRhson/e4CdHCpsHstKWvx9VBTnJloAiWqqCKLkY4YPzq9h2PMM6BQiDbwxHOr63uRC1KWjo67xSxZusgTfu427UtETdSyigONplllFDP5csIuW/Skv6q/FG+V6Fv428PDef5wS5FYP9WiqfZ8TzlRZYneTVXdTuFd7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=ULI54weZ; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="ULI54weZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1736770710; x=1737375510; i=markus.elfring@web.de; bh=PrfQpP75yiuM4H7OxwC1JC1Kolu7fNxLdriiCrhxzKs=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:Cc:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ULI54weZc7WSUelEQDtmpNiH9MyiPHoWEad6KpX/pXXrorl/k2AKid3PkC6ABBXL +PIcNX8oSYsoxL5tcBZ5l1nykzmdBjbUBZgh9413KfB9rM5ZhrI6Xz2PvRUgr8I4s AfWCFA8HgMGnG/W8zKYDbpAh8V8/Pb6dOAXGInvgMJUvxKlz1aYUJExz+3h8gAwlh 1iVJd+ABVIUlANTd0cTDT9P6jNqMdAq+M4D6HAj/lShjS5crXNZSpjkCq//Zy6Slz 4lWhKmrrulb24wuRbf2w0Klq0DWGNRqetetoTN2zfcFNgvj2vYYl9TfYeacHyA+jJ CSST7I7qYlIhH8AhFA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.70.22]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MQgl2-1tsqQ40Wms-00MhQE; Mon, 13 Jan 2025 13:18:30 +0100 Message-ID: Date: Mon, 13 Jan 2025 13:18:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [cocci] [PATCH] coccinelle: platform_no_drv_owner: Handle also built-in drivers To: Krzysztof Kozlowski , cocci@inria.fr References: <20250104141414.114971-1-krzysztof.kozlowski@linaro.org> Content-Language: en-GB Cc: LKML , Julia Lawall , Nicolas Palix From: Markus Elfring In-Reply-To: <20250104141414.114971-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:D5Gq/udjN7sZE4fciFnBfzJV4HA/6Yxkp7xyG4fxzFb1yHEjn4Z UOJVvTHzHzgq3M640Ru7/DDxk+0dQ3yrxy8sUvmOp+OzyBm8tFWp8dJOgoZc4xx4h9WvmfZ bJBCrDwpHnsduWo7wni3lnmKuEo4YPR2hUxdp6ZCQmlER1XI/3S/ya5d6fPm75vzgb0NX6r G2u5UKrP8ijRssN+i6GjQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:nP20U41ffq0=;02Qswk71EZQLrihs+owtSZ2EV6x TrtN6DW2FVNca39KI/An8OPsUT8BctYkoFg/iFX0XNK6N51En8bcB4cHs4MrO5re+/FVsyXJh i7xwTzq/z8eTGG/wYo3VkLIj9D959IjRfmdbsEf0Juyl8cx1KRbuxp7HUq26/0ZrvcIXx9GN4 GxDYOw6LYaehurn9JsYqA/bw+1V5e4duA6PLYxalA/ZqLVTmFvq+cqxiYjDqqWKVJ0enalmws P0URfN0QxLI12+7Oss58HwhgW2185zWfaZ5L2S5PT0/7VfMvUOq0GIbEzGzEEGkHxT2AwIr2y BRMMqKrlRA+pKXltxD8Er88Lf33Rtma5QNCD9DrIfcT5BxkiUiD3Ge//6llRv1IWl3+NjkJ4f +ZAZmGpaN9J5rG/KhIPqA5HBiVt5SIeW+4YguVUYwkpoQBh6fPh5FJbeB7N/lqlKH9L9alU7w c6T8tzHQBUpyobAC08tPqBUz0SPbZcRVUyAPcZQWzGFNS6jDFuBBhfRrCjDvfQuxuUT7v79RB 8INgzMvoi+aq9WzNyDfp9vq1VOG4g3kqKIhtvKorkUSTW8P9sKuV44UFXe05t1X/8KjyiVDIf H1AjJikvie6j8nwzHkYhjb49PW4HeWLYO2kV0WDxJy7ozvwSLn71IZZRJcdHOj5ZGVAWGRWiB mIa/92MAL68kKSIdIGwbNfXxJmRAlQEjA2XemEE1FPq7rcUEj9zFpuq/KshIkejXRnbj64rGm p23jmsSbKLFJTMI4Z3aooh/mWzb9DOGQstXzuaJ151QJbfVxZqr2pLpFVVsAcEwe4uzqvnyic p+rxo/bU5pbeS5sgczEkbQFbasm5Vk75cuuowJu1ljI6nNR6mHPaG2tQi24mvH1IUr4kZvYBA 7TLNW9Zdi+DAAMB1aoTb9TCvQ2zLGGXZmlfsIUSajxNUR61wOcVO1K++hewyAEkhFunnKGSWg yNo8US9kMBVhcM6Fyj3B2UlZBcT+yn9ra5K4monoJ3s+7M/i+BZWR82tJkZ5wFVmvMq3p0agY VF3xG1s+MUK4SF0r9QWBBnRZWQgJqO04LQxZvMxeypE8rSS77aTaYQrVlXfLZlqt10i9XN3Wz ozm2szIW4= =E2=80=A6 > +++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci > @@ -10,12 +10,21 @@ virtual org > virtual report > > @match1@ =E2=80=A6 > @@ > ( > + builtin_i2c_driver(__driver); > +| > + builtin_platform_driver(__driver); > +| > + builtin_platform_driver_probe(__driver, ...); > +| > module_i2c_driver(__driver); > | > module_platform_driver(__driver); How do you think about to avoid a bit for duplicate SmPL code (by using nested disjunctions)? Development idea: ( (builtin_platform_driver |builtin_i2c_driver |module_i2c_driver |module_platform_driver )(__driver); |builtin_platform_driver_probe(__driver, ...);) Regards, Markus