From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACEB83D9027 for ; Tue, 26 May 2026 10:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779791660; cv=none; b=SCkTQUYYsl0VE8PtAMziIVsrQThg8pgBTS/paJ3NC1oV1ZXNaQBfTXoQPR6ughRh6uYGmWErGE1swSMSFPrtj/FatropPiTrx2oUbTWX5Xt4sMfp6S3TnVySDWDoDGy7OpOkjgkVAJqsF5UxX542+XvY2fv64s1gtev+WbzQrGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779791660; c=relaxed/simple; bh=sFsRO0yDsb89oIT21S7eA8A6dy+u3vy3rLbnkAXXODM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fUccAJba+kjR4d9WHOWVcwtoaj6UqUh5T3qXNG08pG2MW7lxn2txdjpLEq95jwd6BsR1XRon9FUvR8ioHCxUB4FzdOsIFKBQ9+D/XXhaJOH+RAVj2F4Sm1bCXIG8Cm/J/dMvtI6OLvBsPx/umxnqr/RL32wk0P2Vm9FpWffeFPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h6DAze2G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YDlbefO3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h6DAze2G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YDlbefO3" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64Q8VdN34117392 for ; Tue, 26 May 2026 10:34:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M6rrwvTxF7kpNlbgbAaNRd9qzBWBl+jhGHIIgmLXSLM=; b=h6DAze2G1t7voQ+I 3q65s89rrWntoHB5fhr5aJ2BjUPY12d4DnktScZv7z9KFW40LAsfTK7obOjiIPfg tyhkXjZKWid28CNg8JkLL9l2lXEUtxIUnmP4NDJd2FTE6tU14bHjnknFWCWSInm7 FeeaD56RHAkHo96hI+gPA0mLZWy6wME0CkZmh4duwRag4n25N03ypyquGwV0tntB 2jqJnZMvU7sEhz8Rgq2QLpodBW3JnykLzO0y/NyfXlI516x+2BjtNxDQ7yyBrL2j vyeo8pBmLjf+2cU9+F1SE+w6BXv4gHUeV0DEae8Tj3jerLvaOoXwaEONXj0IsoPd dslUjA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ecqudbebj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 10:34:17 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b4530a90fdso39350395ad.1 for ; Tue, 26 May 2026 03:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779791656; x=1780396456; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M6rrwvTxF7kpNlbgbAaNRd9qzBWBl+jhGHIIgmLXSLM=; b=YDlbefO3S7I4V7GGJv1vKmEteW4zxTSe5+YkfeHLLehTc2nlDMGi5outd0HLvGoQMm J1w0il1vQFBgV8a4HB0MQGISf2mgqyfm853a4kc2H8uNzzKT0V2El+Xv2zL7r3ObcFya BsYzuQDdbPwKLyXL2SIS2D/hAwF2pTEref5ee77rSiX4csQ4tHncvmDNr6sCOJvYz6L2 xYWxlzgbYm7N5xF9liKPEZvNgZafHfz1LkSjJt3+D+mYmW0bg4j3Q5/fS+Zc7z30twym u8ke42+BckiHBVhkhY/ObuiYHFICjY8xC7/aElfUMZRk6jEooNM1zpcc6sho3rZyJXOb pH8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779791656; x=1780396456; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M6rrwvTxF7kpNlbgbAaNRd9qzBWBl+jhGHIIgmLXSLM=; b=R6JiuqhMuR3iZcgRVa1YDJN22KYvGde5VLkBmmvyGGDb7slYG2xXZCEN6AWFFs8ed1 GPo2UnqO6s3lA5wQq6yZ9l2GpeE+PqTz9MUFuntBogicB0cAJhrfdkX9Su/G4RWkpMwS X0Em2nz01IFcRoF45S6cTJQeZKSn0tcqf7KEyKBHIXuhqmUHQingos4OgnFqvMjKCcEV fRBusg7dL7TAKEt9NqQAbhEf2cHCxMCaV2jkP2nLyBpz0aFakfxFxq0MKkI/3hqYAjAo /SL1VyQSPuVsl7w0RWdU2aKS6dSQhwZriph4tUAVcOZDte7dxZm93iUwTH9oUiBJkwab 9Ufg== X-Forwarded-Encrypted: i=1; AFNElJ/0+DYHiB+qCVSg7McJxK9oZs7if9+O60fg2XieTk8M5h5nadn/0J+p+u6/ZGp/iVIxFJoe1xiRRgbbvf4=@vger.kernel.org X-Gm-Message-State: AOJu0YwUldl+QyxflQtoCX53anusvYeIs1jprfFJtr2Tb2Jm/HK3HCVF ytjW3xslJZJ6Gp52kyMVcGq+jKxKfVRCJlQp4rcsaKS75mEeFwR8KwO4IvYx+1FO9YfRfR089pt Zl84IOpLqXnpfKBksh2OQOTL8Nq+4HrvnGHsQH6qQfcRDYtpl9b5pJWtSQmGQBU/4laA= X-Gm-Gg: Acq92OGc2rZtrjH2yxQkfUAkHNrIoKgzfLAPmCiHzPZUJ41SrM4WxVg5vN4/C4lG6jq vdgQLirT+eLYg7aCYTR5Q+VmgJqAvkgvzxwwxN3vQBJ8XWdll7BPAnd1q1d2Tpat+N0gom0qvif 8mUpqHEqgtNr0BOC+Ulb+S86XVpba2qVE2sfAH0g8jOC8GZl9a39pEF3+TBbskyX3wQu2oJ/yhz 1H6Jka0UoARbc9eoKaULLafYTQbMKrSnrJ5bR+bvQv6tSSkdDnU+xTwB51gvRNrbp1yLvb3jbE6 X4aGJJLWgSUJrTb3HWGGNNLJvjeFY7Nt8rLExknvMl/EL9ssAgjJ/Ztjx4H5Je31fvmcGWko9dW LPhnzCKg10K8J2ATlOr+6dMymMVEzClrs3LkQyK0M2XDVCAcY2I8= X-Received: by 2002:a17:902:d489:b0:2ba:6ca2:bca with SMTP id d9443c01a7336-2beb0680e99mr203240815ad.26.1779791656203; Tue, 26 May 2026 03:34:16 -0700 (PDT) X-Received: by 2002:a17:902:d489:b0:2ba:6ca2:bca with SMTP id d9443c01a7336-2beb0680e99mr203240575ad.26.1779791655684; Tue, 26 May 2026 03:34:15 -0700 (PDT) Received: from [10.206.100.243] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56e090fsm131331095ad.34.2026.05.26.03.34.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 03:34:15 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 16:02:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7807S panel controller To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ayushi Makhija , rajeevny@qti.qualcomm.com References: <20260518-ili7807s-panel-v1-0-d7b048163b1c@oss.qualcomm.com> <20260518-ili7807s-panel-v1-1-d7b048163b1c@oss.qualcomm.com> <20260519-curly-courageous-sturgeon-2facfe@quoll> Content-Language: en-US From: Arpit Saini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 3NNT7crEkIWhFeWdZ_IdAoaiURftnJNx X-Proofpoint-GUID: 3NNT7crEkIWhFeWdZ_IdAoaiURftnJNx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA5MiBTYWx0ZWRfX+WHx90ORpz+n 62XGpPX6voraRJr6I0ZAhrLc2vxwjc0wh5R+UHoQGU+INcCyDio4O4cSbNt7bd2SJ30nuwxq8bM bMahlsErTawS4+WwYVAwnTq35rvAErZWpg30ihEs7t/vv5AMMfsn4/QBpcOzRQbvAj/G2D2Wx9J wftlD2jKE9Vg4SwwPcosGOleJIvr/bJX/VNjha2UI56hNMu2ss1MKHSQb0giSoUH2ftJt/nfW8P 4FJ5luoVjLbD3n+s+kYBmYqyUflEiXD/XL1gJm6bRMpgVk4Qs1tZfRUKz05h37ZjyxlSxmAGA50 k95jaV1mPstv7gBx0l5D/OgVHQuoSWERUVdX4fmzQfy2M4P/oFDUBE0lz0Jyr7CQKXfq1UzYZmN rUkM8+eilA6uxmfK5HVhoWmQJu0GHkEFbGwwtT4AjTTJvUqQ8Dh6gkRikiSfObU36m5TdXZ1qp1 YgxFmehZPi3iBwNfnEA== X-Authority-Analysis: v=2.4 cv=C9jZDwP+ c=1 sm=1 tr=0 ts=6a157729 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=IV4c8OSHAAAA:8 a=QqSZzXjYCKH221ueLxIA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=Q6n48rkgcAvIKCAITAMI:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-26_02,2026-05-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 clxscore=1015 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260092 Hi Krzysztof , Dmitry On 5/20/2026 6:56 PM, Dmitry Baryshkov wrote: > On Wed, May 20, 2026 at 06:10:57PM +0530, Arpit Saini wrote: >> Hi Krzysztof , Dmitry >> >> On 5/19/2026 4:02 PM, Krzysztof Kozlowski wrote: >>> On Mon, May 18, 2026 at 04:34:12PM +0530, Arpit Saini wrote: >>>> ILI7807S is a DSI display controller used to drive MIPI-DSI panels. >>>> The DLC DLC0697 1080x1920 LCD panel is based on this controller. > > I can't find this panel on the DLC website. Do you have a pointer to the > product page? > https://v4.cecdn.yun300.cn/100001_2012175013/DLC0697AAL21MF-1.pdf >>>> >>>> The panel requires a reset GPIO, backlight enable GPIO, I/O voltage >>> >>> If panel requires it, so should the binding. >>> >> Ack, I will update. >>> ... >>> >>>> + reg: >>>> + maxItems: 1 >>>> + description: DSI virtual channel >>>> + >>>> + reset-gpios: true >>>> + >>>> + backlight-en-gpios: >>>> + description: Backlight enable GPIO (active high) >>> >>> What is the name of the pin in ili7807s device? >>> >> Display daughter card has WLED driver as well as LCD bias driver. > > What is the display daughter card here? Is it a Qualcomm board or is it > a part of the panel? > > Also you wrote a lot of text, but you didn't really answer either of the > quesitons. Is there a GPIO on the panel connector that enables the > backlight? If not, this is some external supply on your (assumingly) > daughter card. And it should be modelled accordingly. > >> >> The WLED driver's Enable is coming from WLED_P1_EN and PWM is coming from >> LCD_CABC output of the panel. >> >> DISPLAY0_BACKLIGHT_ENABLE (GPIO 91) of ITP baseband card ==> WLED_P1_EN of >> Display Daughter Card (DC) >> >> In the display daughter card of Shikra ITP platform, we are not using the >> external PWM for WLED driver. But connected the CABC output of the panel to >> the WLED driver. Backlight update is happening using MIPI DCS command which >> is driving the CABC output (i.e., PWM for WLED). >> >> Because of above HW configuration, we need to enable the MIPI DCS brightness >> update on this panel. The below command of dlc0697_init_sequence() is >> enabling this. >> mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x24); > > So, this should be then dependent on the presence of the backlight in > the DT. Either it is a panel-internal one, or an external one. > >> >> >> After checking this, I realized that this panel can be used without the DCS >> backlight as well when it's using PWM based backlight control. >> >> I can add `has_dcs_backlight` in panel_desc and set it true for dlc0697. I >> will update bindings and add backlight as optional property. > > Why? Use backlight property instead. It's already there. Anyway, you > really, really need to describe the panel in the bidings. Not your > daughter card. > This `has_dcs_backlight` in panel_desc will serves both the purpose, as for our current platform constraint , we need to create our own backlight. But this panel can be used without the DCS backlight as well when it's using PWM based backlight control. So in this case I need to implement the backlight as implemented in panel-novatek-nt36523.c, panel-himax-hx83121a.c. with this implementation ,I will remove the backlight from the dt-bindings. Please let me know,if I am missing something. Thanks, Arpit