From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521B71B0433 for ; Fri, 20 Dec 2024 09:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734687430; cv=none; b=p7sn/AkrPhXenxJI9F3cUmNKvZjjW3quhqmGKZmH19AClSnYqYrwj35dvLs3RuCAKYtmC+hdOLSuLU37i+4Sw/P/4xlO2aUFjzUlRsdyLd13CTeU8AEf8hXQ5EHk2jhKYtTmH51K/BxR7gXYcawGM9T8uwovMvPuBPUFLaipQnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734687430; c=relaxed/simple; bh=sDdFiDa5rwkAIlrLyHaCtQbwf1RknOw9hv324X9pEmE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i4uG1CuGpW4HVvJkQvkbqNwx3cQ9UKUSAwZMGg9+GhHttD4406SsNJj19mMH8fEOCFCi1aUJynLyoRFttJ5ACnAk8xvJfZ5hZ+2WTOhAnTvJbGwa7YLeW2943Zvf1743c1D0CxeOywyjuqx4NEXtkrpAfHU2sAULMkGuNuH9hcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iNSz0FZG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iNSz0FZG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BK4PZID024605 for ; Fri, 20 Dec 2024 09:37:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h7oj8R8h4E4EYHPxhiDSmNCuo81TupGOmdcttJnlWpc=; b=iNSz0FZG1YcH+8Dw Fl7dIoV3u55itHDXeQ/Rc/8pxNsdkFfk017S28+nVtF1DExqv18EKqjzKc+1ODp0 eUbzE7rscXa8ba8Val7f6TIck7dvHazIZuj/7Ce+HpCD58GcyVt+UqOkphAK8oof MNsmMj9u68hUMsWm+IvriMmdFerpfiC/0ewFhClMdBzHgZD3Opch4KSPUcK5pNMX A96SiZdeqnvUHDBiYuPtubLhFvnam/nRmgzuSrb8NyV/LxeIWnF+4BiTOELSFIN1 t6lOI9OLzNBU8q0M9xVxQuMePLRxsrOHGRK9oFAmwfihq6BciWecmfzdWyubIJTW JHnpuA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43n1hx0sk0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 20 Dec 2024 09:37:06 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6d8f15481bbso5059386d6.1 for ; Fri, 20 Dec 2024 01:37:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734687395; x=1735292195; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h7oj8R8h4E4EYHPxhiDSmNCuo81TupGOmdcttJnlWpc=; b=mESJ+TQPrVa5Wseb4N3BtdZUNRstwuug/4kfhue8tNbrpFbzg9yU+kMou+Oy9+zhtf CNiYj357lJ/Gu8dil3/4ZuO7fosT0iKeqeFVrVmXmRSkqrmFnJORPFAWscju0EetwPta cmp90BH84HdqCmT0vs2pOh9r1CiIXr6tHsScdZ9TOHFPM/Efu7o1aAdaoqpK21HE4lRI SxDB5f0vs7SwFmlXPfn5/vbbPwxnrjsM1pK2sFeIrQVPHNwf3xvpYEdTp6nLVbbuwivq 4jF0C6/ue3/v5XIrFmwXXQd0kCFywpSLqQ5cQAVYVpJmjNn4Qb78G3urbWiocCt68oc8 ptYg== X-Forwarded-Encrypted: i=1; AJvYcCWalBkb+E5sPlihRbcqxNbqKHi2LpaoB00BDHnVWrk4+yjaJg0f1KJPT2ZTDdfN+S0VZAYdPEADKcIoYvc=@vger.kernel.org X-Gm-Message-State: AOJu0YyrBxYZoGS13t5WGWjS5clHsd4AJ65e0LFPTD8BteP3tpK3a6tf 3Xz4Y6OePUN5be+fLYPFl52uTU2gPaQgHF7VQHjeYKb+Aws6bzvoc1JgRJYwAzJ1Z5q60yTiMtd Wz+sl0fzDfSIFMtSvEHrFh4UUon4bnGMlMQj2XK1nPMG9kz2Ybu43W7C8B77TTsA= X-Gm-Gg: ASbGnctNAI9vYU96iRwTH8Cj/oDWATQQnSCNxtEoxepH/Vgad/1or4PiKJXrMBMAoag eZVgYKlgzHCqeHLY4AYhXZ5yJpOwQ4edDHAhj54BoL/kpoyER9pGyIL+rPBr4qkDnUJ6ljX4OQi E+UPgyfcSUmspSF+e4dltQdJbV6K0cUJONHD0Sa9F9FFUBH5cUcvyRLbufRgkqUGgb09yaoRZmB UxUo1btbrCl7XvxxlHRgVBhcUbqaCM0lJ7k18xgR/hTChUwb6FOLJgMcMNYK4RjWGjRmkyix/Ym 5fdA4+PU1TdRtCbT6u3VKPK4ycaxOeqA0NA= X-Received: by 2002:a05:6214:c21:b0:6d8:9a85:5b33 with SMTP id 6a1803df08f44-6dd233bafd1mr12002456d6.11.1734687395493; Fri, 20 Dec 2024 01:36:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFoncBjB8cj/M7gA2nrgGGLaBphVRng7XSV8mU7QIm6l9QbtXTfOitLjiLlZGrB/N13wB8Lag== X-Received: by 2002:a05:6214:c21:b0:6d8:9a85:5b33 with SMTP id 6a1803df08f44-6dd233bafd1mr12002376d6.11.1734687395116; Fri, 20 Dec 2024 01:36:35 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e830abfsm158492166b.20.2024.12.20.01.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 01:36:34 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 10:36:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra qcom,msm-id value To: Luca Weiss , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241220-fp4-msm-id-v1-1-2b75af02032a@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241220-fp4-msm-id-v1-1-2b75af02032a@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: yKC60cJbdjwIH6zPV_0jXY-bNn-1E0a- X-Proofpoint-ORIG-GUID: yKC60cJbdjwIH6zPV_0jXY-bNn-1E0a- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=934 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412200079 On 20.12.2024 9:55 AM, Luca Weiss wrote: > The ID 434 is for SM6350 while 459 is for SM7225. Fairphone 4 is only > SM7225, so drop the unused 434 entry. > > Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairphone 4") > Signed-off-by: Luca Weiss > --- > Completely dropping these values also appears to work when using > boot.img header version 2, but doing this change now would mean any > tooling in the wild for packaging up the boot.img using header v0 would > stop producing working without adjusting that mkbootimg invocation. > --- It would be nice if you could start shifting that tooling to bootimgv2 slowly, and when it trickles down to appropriate places, switch it up upstream as well. Of course if that works for you. Reviewed-by: Konrad Dybcio Konrad