From: Chuck Lever <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>
Cc: Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Rick Macklem <rmacklem@uoguelph.ca>, Chris Mason <clm@meta.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nfsd: release OPEN-decoded posix ACLs via op_release
Date: Mon, 1 Jun 2026 07:41:43 -0700 [thread overview]
Message-ID: <a53a1a3e-d7df-45a7-a3ba-8946d2570ba7@oracle.com> (raw)
In-Reply-To: <6924de18c6fd50d61e39b426bcfdce7617ce2976.camel@kernel.org>
On 6/1/26 6:41 AM, Jeff Layton wrote:
> On Mon, 2026-06-01 at 11:06 +1000, NeilBrown wrote:
>> I think this patch is good, but I think it would be even better if the
>> ->op_release() call were moved out of nfsd4_encode_operation() and
>> places after this if-else. Then there would be only one call-site in a
>> fairly obviously-correct place.
>> But:
>> Reviewed-by: NeilBrown <neil@brown.name>
>> for if you just want to stick with this version.
>>
>> Thanks,
>> NeilBrown
>>
>
> I like that idea.
>
> I'll be testing a pile of other patches today anyway, so I'll make this
> change and test it alongside the rest.
>
> Chuck, you can either take this one and I'll do a cleanup patch along
> the lines of what Neil suggests, or I can send a v3.
v3 sounds fine.
--
Chuck Lever
prev parent reply other threads:[~2026-06-01 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 22:19 Jeff Layton
2026-06-01 1:06 ` NeilBrown
2026-06-01 13:41 ` Jeff Layton
2026-06-01 14:41 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a53a1a3e-d7df-45a7-a3ba-8946d2570ba7@oracle.com \
--to=chuck.lever@oracle.com \
--cc=Dai.Ngo@oracle.com \
--cc=clm@meta.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=rmacklem@uoguelph.ca \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®