From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jason Wang <wangborong@cdjrlc.com>, sreekanth.reddy@broadcom.com
Cc: sathya.prakash@broadcom.com,
suganath-prabu.subramani@broadcom.com,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: message: fusion: Fix comment typo
Date: Tue, 19 Jul 2022 09:09:17 -0400 [thread overview]
Message-ID: <a53cf4da2a03af3635bebbfc1bb4ecf0a73bc0e1.camel@HansenPartnership.com> (raw)
In-Reply-To: <20220716042245.35708-1-wangborong@cdjrlc.com>
On Sat, 2022-07-16 at 12:22 +0800, Jason Wang wrote:
> The double `only' is duplicated in the comment, remove one.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/message/fusion/mptbase.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/message/fusion/mptbase.c
> b/drivers/message/fusion/mptbase.c
> index 9b3ba2df71c7..86e7510d7614 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -518,7 +518,7 @@ mpt_reply(MPT_ADAPTER *ioc, u32 pa)
>
> /* Map DMA address of reply header to cpu address.
> * pa is 32 bits - but the dma address may be 32 or 64 bits
> - * get offset based only only the low addresses
> + * get offset based only the low addresses
What is the point of all this if you're not even going to read the
comment to make sure it makes grammatical sense? Neither the before
nor after versions do here.
James
next prev parent reply other threads:[~2022-07-19 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 4:22 Jason Wang
2022-07-19 13:09 ` James Bottomley [this message]
2022-08-04 1:06 Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a53cf4da2a03af3635bebbfc1bb4ecf0a73bc0e1.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®