From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18548318EE9 for ; Tue, 13 Jan 2026 20:23:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768335799; cv=none; b=I446C0W0rLt4clq1CZe46MJ2aNNO9p0GY1zrjRqzXBj77GReo4YHH1eRQCoSsWJH7ZWfF+FoaXS8nthzmq0e3Vsb0v2RfGL+jG3cMi1i12YuUSAD700+d6Mq0To+ZFL7tl+UNwUWiL9WC4tGc2Gk8+Ztp9MLglN2OVdsYFpEqiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768335799; c=relaxed/simple; bh=OzuQ6iWjzoYV77KDRUSGerU/496Kc4rlMMYENR9wF3U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FElH8PkPk8ithRppr0gNQHyt3f2AyrYetuwwDEKVsk2q+cXha7fGRhyVJ4/qfmd/tFvp1F1vQHsW4J+l0+2ZAEUq45Gs2DJWpdGsLhee0J0Ug2YTzEj3aOez3aheMJOBptUElpq6yOZtqh++ss4eBzCvawtX+U988dx0VM8c1bY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=T/kmzgRf; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="T/kmzgRf" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47ee301a06aso1538645e9.0 for ; Tue, 13 Jan 2026 12:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768335796; x=1768940596; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K8uUTB1SVA3MIzVmUio8rFNP+sCwhx9nt26BkyDd1XI=; b=T/kmzgRfMOMDkluUzaiTFwReEiFtEAKcouSRkvh1QUjVM+XEN/7qblJIfzbbpiJVew yRkGPLpARu4nfUK6xqeYzRQHKl41tunf4ozmUS6INdvyZntSSFXdq2LewfPiuF7DJ74J Yjou8cX5/7MU8wT1n9CMmBEwiOcLkcENUnoq6csE1ZernVI6IuNPfyimp4JGz5wT1Q7X yvyng8MYTS7slP+8JUZdtmxhAhxfeBseE2ordQemvjpf68avZxjWapUwJhTOlYAXRoiv uTIwkwFcjbYt8yk9SoyGodCrGXnmg56VrRsxOQyjvL0f8CeC9eAZhMGicv97iQ6zlEda +VIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768335796; x=1768940596; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K8uUTB1SVA3MIzVmUio8rFNP+sCwhx9nt26BkyDd1XI=; b=mATboCv4pBs+yuGNWRrQUllOlyeoF1msk/PJHU4rQ9Sxw3Cqu+wE6Wm3IqMi/iK8vp xyDsKtUHWnQHtvTnXb6L+7cMYskiXSmnn0ggjL0xEsV0K1lH4OC23reh6nQu8zq419zL /j+00CLddLFAjCQGsHOi2zer4ZtYMGNBCoVGZ0G6yYjH2M2LmSqDBg8rHTNJiNS1OdrF BAwuc24CmUgGmUbVRueNd7g0LAdw2jSCDXDyewFzd9bsf5RkmZQSPXRXJWBSSewNpbtV hBzUU+1NiAZosj1ghy99fvtFiQkdZMHHmbabTDBgED0v0usfZZJLzBw+MNkDUbydHbrQ HR+w== X-Forwarded-Encrypted: i=1; AJvYcCV0rOfkkbY8HGVETyCJUXTIPkRakDe8DiQucziavO3xGJj5mU5fw56odscIEba2BYFM9XCp4adrBMnOZAA=@vger.kernel.org X-Gm-Message-State: AOJu0YwHa9LehUmi5NWQuRgu+27gVRDjvFM2wCELeqs+kK+RtCxGFZ+X vJOJs38zgAE0HzF+5sQGMGyAtf/pTzFj9U2yt9vcwl9CZl+BWU2l3JNYCLNfpCX6kuk= X-Gm-Gg: AY/fxX60eeerHaE5/Iiq/l89vB9xYKEVEk7iUsZUncGxtDI+N68wtoP6qitc6hWUG0b tzAHlYBYRAwvsycgCC7bBlu6Ep37Hk4qqLhHel9EcGJkGiByJdF+9kSgZZoawNQcq7eGM+Wgd2O Z6t6oADn6vDf1Rw3MZifTKOzpl8GO3ptYj5gBRqj6ofRN6mYVcMsXZYCC5AroZFgrVmUq6v4aLr 1txsqyx6H5wV7bR2WxUfE+bRKcFzPV8bFlodgRvInFkpHEd1OCbHGfNqOcllyyYnTdJUAWFgVH/ epM+z7Imu2nWyEhB4pQ3NnH8+McAgfn5JI88IwTysw0chB6LBNRiV6Q7rI7qeuJyAZ3kZzRmqmM 8btjqqKH/wQVBr0QksjrLooZW9tV0gXLEnyXFCtb96LQp1J37MBBoH5SU4z0n+WZe9RG5KSBb06 JfNARr9aiYmsW7eUQH1O/OjYdwyeAHjGMn6zve+bzhAyMHxWxG3PlfS38= X-Received: by 2002:a05:600c:3acb:b0:477:b734:8c53 with SMTP id 5b1f17b1804b1-47ee33214c4mr3686195e9.12.1768335796432; Tue, 13 Jan 2026 12:23:16 -0800 (PST) Received: from ?IPV6:2001:a61:138d:5701:1aab:ab2a:99f8:6c9a? ([2001:a61:138d:5701:1aab:ab2a:99f8:6c9a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47edb26792fsm47371495e9.14.2026.01.13.12.23.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 12:23:15 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 21:23:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [usb?] INFO: task hung in i2c_tiny_usb_disconnect To: weipeng Cc: anna-maria@linutronix.de, frederic@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com, tglx@linutronix.de References: <6963d09e.050a0220.eaf7.0070.GAE@google.com> <20260113154748.341096-1-coderlogicwei@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260113154748.341096-1-coderlogicwei@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13.01.26 16:47, weipeng wrote: > @@ -287,9 +321,12 @@ static void i2c_tiny_usb_disconnect(struct usb_interface *interface) > { > struct i2c_tiny_usb *dev = usb_get_intfdata(interface); > > - i2c_del_adapter(&dev->adapter); > + mutex_lock(&dev->usb_lock); > usb_set_intfdata(interface, NULL); > - i2c_tiny_usb_free(dev); > + dev->disconnected = true; > + mutex_unlock(&dev->usb_lock); > + > + queue_work(system_long_wq, &dev->release_work); > > dev_dbg(&interface->dev, "disconnected\n"); > } what prevents the following sequence: i2c_tiny_usb_disconnect() -> module unload -> i2c_tiny_usb_release() As far as I can tell, this can happen and you'd execute already freed memory. Regards Oliver