From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F02DA33062 for ; Sun, 29 Dec 2024 14:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735484280; cv=none; b=LfKtr2po4HvplONBXjkBcGGUTL+9X2nfGHgQJ5FZ7aS69AeCzexDrPcixUuqlD1OKDvNh+06Bw1NxjGKyMYVHAV+LQDttTu6foEB2o/oQF41ZvtUANiha/5vP6OEVR6kT80bhe9fdyXOBaaGPqQZG9GdA2pz686QsJCqyS8hU44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735484280; c=relaxed/simple; bh=KCtsAFBIXcN2INX9wKaR8KhaocFsmJ3pKVzGzQF5CXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CBFULexUxXwYTluIuO0zpBIjvsn+l28+eLSjlujEIkJ3wWOGW9GExZ7ODq+9MI4fw64179KfP7ubvzZxP1C0bYcMQhOyp3/N2XAvJZNqKidsgrSqGgXZ4NAFVeZY/bXdj8a3FxDbSb6pFRaw9GjR9FWEwX661SjQezkteFlrqYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=IZgFsQki; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="IZgFsQki" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BTDlmRe019905; Sun, 29 Dec 2024 14:57:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=mggIH5 c11tMsZWj/+1hXr3rjU1yhEB+HE7S6unz5wKs=; b=IZgFsQki9R1ll/Rszx30Fz Ex75mqr+0VjbHJLPQGcx8S9euoqBIsqyXFVZZNfDs0OunFh/+R+VHLDq3bPRVs/6 53BUjM0oRCrY68QK5enN6F/ydB5jQebc7jWYM5lNFt8yK7Z5GePIG5oJ8FRWSGTk B6ceDXjQczcFFaZS/Tjtm50i9/NMLltoo2da2uZ6tZ+7qvmzU/haTex+09OUStEa aqLV4uZp571G6U04Xd6PAk1SnJiGYqN3OfBxFF9HtuFOBnTlvF9WBxQ7XTIgkxJC zewHP4WtJ6FP96XmcMTEuSoAt4tVdaZhcmyd+DorBDC8ZB3cAKV3npISabNrtSqA == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43txwb9aey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 14:57:49 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BTEvmD9019978; Sun, 29 Dec 2024 14:57:48 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43txwb9aew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 14:57:48 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BT9Wrli027055; Sun, 29 Dec 2024 14:57:47 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43txc1hnmx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 14:57:47 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BTEvlr724445572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Dec 2024 14:57:47 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 159DD5804E; Sun, 29 Dec 2024 14:57:47 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 241E65803F; Sun, 29 Dec 2024 14:57:41 +0000 (GMT) Received: from [9.171.1.162] (unknown [9.171.1.162]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 29 Dec 2024 14:57:40 +0000 (GMT) Message-ID: Date: Sun, 29 Dec 2024 20:27:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> <4504da8d-a5e7-45a1-9feb-167f94210200@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XC89uqIGNvmo7YzPS1jIm6b0-nKNt1AV X-Proofpoint-ORIG-GUID: tpscf6y3E1nTufbGLAkvXSqzZp-FXeBA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=552 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412290129 On 12/27/24 21:19, Gregory Price wrote: > On Fri, Dec 27, 2024 at 04:18:24PM +0530, Donet Tom wrote: >> On 12/11/24 03:07, Gregory Price wrote: > ... snip ... >>> + NUMA_HINT_PAGE_CACHE, >>> + NUMA_HINT_PAGE_CACHE_LOCAL, >>> NUMA_PAGE_MIGRATE, > ... snip ... >>> if (folio_nid(folio) == numa_node_id()) { >>> - count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); >>> + count_vm_numa_event(NUMA_HINT_TYPE_LOCAL(vmf)); >> I have tested this patch series on my system with my test program. I am able >> to see unmapped page cache pages are getting promoted. >> numa_hint_faults2269numa_hint_faults_local2245numa_hint_page_cache1244numa_hint_page_cache_local0numa_pages_migrated4501 >> >> In my test result numa_hint_page_cache_local is 0. I am seeing >> numa_hint_page_cache_local will only be incremented if the folio's >> node and the process's running node are the same. This condition >> does not occur in the current implementation, correct? >> > I did not want to assume we'd never use this interface where such a > scenario could occur - so i wanted to: > > a) make such a scenario visible > b) make the code consistent with existing fault counts Understood, thank you for clarifying! > > I'm fine removing it. It's hard to know if this interface ever gets > called with that scenario occurringwithout capturing the data. > > ~Gregory >