mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] perf script: Find script file relative to exec path
Date: Mon, 24 May 2021 09:41:33 +0300	[thread overview]
Message-ID: <a5492881-c6c3-da0d-7a7b-846cdd030971@intel.com> (raw)
In-Reply-To: <YKp8ejb3zzmk6go8@krava>

On 23/05/21 7:02 pm, Jiri Olsa wrote:
> On Sat, May 22, 2021 at 01:01:51PM +0300, Adrian Hunter wrote:
> 
> SNIP
> 
>> diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
>> index 4e4aa4c97ac5..db8f24341406 100644
>> --- a/tools/perf/util/scripting-engines/trace-event-python.c
>> +++ b/tools/perf/util/scripting-engines/trace-event-python.c
>> @@ -1876,6 +1876,7 @@ static int python_generate_script(struct tep_handle *pevent, const char *outfile
>>  
>>  struct scripting_ops python_scripting_ops = {
>>  	.name			= "Python",
>> +	.dirname		= "python",
>>  	.start_script		= python_start_script,
>>  	.flush_script		= python_flush_script,
>>  	.stop_script		= python_stop_script,
>> diff --git a/tools/perf/util/trace-event-scripting.c b/tools/perf/util/trace-event-scripting.c
>> index 714581b0de65..721f38c0d5cf 100644
>> --- a/tools/perf/util/trace-event-scripting.c
>> +++ b/tools/perf/util/trace-event-scripting.c
>> @@ -63,6 +63,7 @@ static int python_generate_script_unsupported(struct tep_handle *pevent
>>  
>>  struct scripting_ops python_scripting_unsupported_ops = {
>>  	.name = "Python",
>> +	.dirname = "python",
>>  	.start_script = python_start_script_unsupported,
>>  	.flush_script = flush_script_unsupported,
>>  	.stop_script = stop_script_unsupported,
>> @@ -126,6 +127,7 @@ static int perl_generate_script_unsupported(struct tep_handle *pevent
>>  
>>  struct scripting_ops perl_scripting_unsupported_ops = {
>>  	.name = "Perl",
>> +	.dirname = "perf",
> 
> looks like typo.. usually means that you run perf way too often ;-)

Betrayed by muscle memory! :-)

      reply	other threads:[~2021-05-24  6:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22 10:01 Adrian Hunter
2021-05-23 16:02 ` Jiri Olsa
2021-05-24  6:41   ` Adrian Hunter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5492881-c6c3-da0d-7a7b-846cdd030971@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®