From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Dev Jain <dev.jain@arm.com>,
akpm@linux-foundation.org, ljs@kernel.org, muchun.song@linux.dev,
osalvador@suse.de
Cc: riel@surriel.com, liam@infradead.org, vbabka@kernel.org,
harry@kernel.org, jannh@google.com, lance.yang@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ryan.roberts@arm.com, anshuman.khandual@arm.com
Subject: Re: [PATCH 2/5] mm/rmap: Add try_to_unmap_hugetlb_one
Date: Tue, 7 Jul 2026 16:15:50 +0200 [thread overview]
Message-ID: <a54ca48f-c776-4b4a-9697-1c2170cb420b@kernel.org> (raw)
In-Reply-To: <20260707121128.373192-3-dev.jain@arm.com>
On 7/7/26 14:11, Dev Jain wrote:
> Simplify try_to_unmap_one() by separating the hugetlb parts into
> try_to_unmap_hugetlb_one().
>
> To understand the correctness of the refactoring, the following points
> are noted:
>
> 1. try_to_unmap() is called for hugetlb folios only when they are
> hwpoisoned.
>
> 2. A hugetlb VMA cannot be mlocked.
>
> 3. page_vma_mapped_walk() returns at most one hugetlb mapping in a VMA,
> and that mapping points at the head PFN.
>
> 4. We won't ever process a softleaf entry that encodes a hugetlb folio;
> hugetlb folios are never swapped out, migration entries will be
> skipped (PVMW_MIGRATION not passed), and device-exclusive does not
> work for hugetlb.
>
> 5. The hwpoison entry is constructed from the poisoned folio, just as in
> the pre-refactor code. Any previous uffd-wp state is deliberately not
> preserved for the hwpoison entry.
>
> 6. TTU_HWPOISON is always present; for it to not be present, either the
> folio has to be in swapcache, or mapping_can_writeback() is true (see
> unmap_poisoned_folio), none of which is true for hugetlb folios.
>
> 7. Hugetlb uses separate counters from normal rss counters, therefore
> update_highwater_rss() need not be called.
>
> While at it:
>
> - Change VM_BUG_* to VM_WARN_*.
>
> - Do not declare variables which are only used once.
>
> - Use huge_pte_dirty() instead of pte_dirty().
>
> - Add 3 VM_WARN_ON_ONCE asserting that TTU_HWPOISON should be present,
> pte_present() must be true, and the pfn derived from the huge pte
> must be that of the head of the hugetlb folio.
>
> Except the BUG->WARN change, no functional change intended.
>
> Suggested-by: David Hildenbrand <david@kernel.org>
> Signed-off-by: Dev Jain <dev.jain@arm.com>
> ---
> include/linux/hugetlb.h | 1 +
> mm/rmap.c | 177 +++++++++++++++++++++-------------------
> 2 files changed, 96 insertions(+), 82 deletions(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 4115076e4922a..bf7e163e3779d 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -1271,6 +1271,7 @@ static inline void hugetlb_count_sub(long l, struct mm_struct *mm)
> }
>
> pte_t huge_ptep_get(struct mm_struct *mm, unsigned long addr, pte_t *ptep);
> +unsigned long huge_pte_dirty(pte_t pte);
>
> static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma,
> unsigned long addr, pte_t *ptep)
> diff --git a/mm/rmap.c b/mm/rmap.c
> index dbb077f8443e3..934773dfa2f2a 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1978,6 +1978,95 @@ static inline unsigned int folio_unmap_pte_batch(struct folio *folio,
> FPB_RESPECT_WRITE | FPB_RESPECT_SOFT_DIRTY);
> }
>
> +static bool try_to_unmap_hugetlb_one(struct folio *folio,
> + struct vm_area_struct *vma, unsigned long address, void *arg)
> +{
> + DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, 0);
> + struct mmu_notifier_range range;
> + enum ttu_flags flags = (enum ttu_flags)(long)arg;
> + struct mm_struct *mm = vma->vm_mm;
> + const unsigned long hsz = huge_page_size(hstate_vma(vma));
I would move const variables all the way up.
> + bool ret = true;
> + pte_t pteval;
> +
> + /*
> + * The try_to_unmap() is only passed a hugetlb folio in the case
> + * where the hugetlb folio is poisoned.
> + */
> + VM_WARN_ON_FOLIO(!folio_test_hwpoison(folio), folio);
> + VM_WARN_ON_ONCE(!(flags & TTU_HWPOISON));
> +
> + range.end = vma_address_end(&pvmw);
> + mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm,
> + address, range.end);
> + adjust_range_if_pmd_sharing_possible(vma, &range.start, &range.end);
> + mmu_notifier_invalidate_range_start(&range);
> +
> + /* There is only a single mapping in a VMA. */
> + if (!page_vma_mapped_walk(&pvmw))
> + goto range_end;
> +
> + address = pvmw.address;
Will address ever change due to the page_vma_mapped_walk()? I don't think so, right?
So this can instead become a VM_WARN_ON_ONCE, maybe?
Nothing else jumped at me, much clearer to me.
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-07-07 14:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 12:11 [PATCH 0/5] mm/rmap: Refactor try_to_unmap_one Dev Jain
2026-07-07 12:11 ` [PATCH 1/5] mm/rmap: convert page -> folio for hwpoison checks Dev Jain
2026-07-07 14:06 ` David Hildenbrand (Arm)
2026-07-07 12:11 ` [PATCH 2/5] mm/rmap: Add try_to_unmap_hugetlb_one Dev Jain
2026-07-07 14:15 ` David Hildenbrand (Arm) [this message]
2026-07-09 12:15 ` Dev Jain
2026-07-07 12:11 ` [PATCH 3/5] mm/rmap: refactor some code around lazyfree folio unmapping Dev Jain
2026-07-07 14:18 ` David Hildenbrand (Arm)
2026-07-09 12:16 ` Dev Jain
2026-07-09 13:43 ` David Hildenbrand (Arm)
2026-07-07 12:11 ` [PATCH 4/5] mm/rmap: refactor anon swapbacked folio unmap in try_to_unmap_one Dev Jain
2026-07-07 14:26 ` David Hildenbrand (Arm)
2026-07-09 13:39 ` Dev Jain
2026-07-07 12:11 ` [PATCH 5/5] mm/rmap: add anon folio unmap dispatcher function Dev Jain
2026-07-07 14:28 ` David Hildenbrand (Arm)
2026-07-09 13:34 ` Dev Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a54ca48f-c776-4b4a-9697-1c2170cb420b@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=dev.jain@arm.com \
--cc=harry@kernel.org \
--cc=jannh@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®