From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: cgel.zte@gmail.com
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] ata: simplify the return expression of brcm_ahci_remove
Date: Mon, 9 May 2022 20:44:38 +0900 [thread overview]
Message-ID: <a54d0558-be00-b87b-9238-187978ca06c1@opensource.wdc.com> (raw)
In-Reply-To: <20220505022133.55852-1-chi.minghao@zte.com.cn>
On 2022/05/05 11:21, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/ata/ahci_brcm.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c
> index ab8552b1ff2a..f61795c546cf 100644
> --- a/drivers/ata/ahci_brcm.c
> +++ b/drivers/ata/ahci_brcm.c
> @@ -549,15 +549,10 @@ static int brcm_ahci_remove(struct platform_device *pdev)
> struct ata_host *host = dev_get_drvdata(&pdev->dev);
> struct ahci_host_priv *hpriv = host->private_data;
> struct brcm_ahci_priv *priv = hpriv->plat_data;
> - int ret;
>
> brcm_sata_phys_disable(priv);
>
> - ret = ata_platform_remove_one(pdev);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return ata_platform_remove_one(pdev);
> }
>
> static void brcm_ahci_shutdown(struct platform_device *pdev)
Applied to for-5.19. Thanks !
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2022-05-09 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 2:21 cgel.zte
2022-05-09 11:44 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a54d0558-be00-b87b-9238-187978ca06c1@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®