From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>,
Kamaljit Singh <kamaljit.singh1@wdc.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"niklas.cassel@wdc.com" <niklas.cassel@wdc.com>,
"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>
Subject: Re: [PATCH v1 1/1] nvme: add admin controller support. prohibit ioq creation for admin & disco ctrlrs
Date: Tue, 1 Apr 2025 02:20:38 +0000 [thread overview]
Message-ID: <a54fab93-d48e-4095-89dc-97060652799a@nvidia.com> (raw)
In-Reply-To: <Z-qur5YnK2ZtiRR3@kbusch-mbp.dhcp.thefacebook.com>
On 3/31/25 08:03, Keith Busch wrote:
> On Fri, Mar 28, 2025 at 02:36:40PM -0700, Kamaljit Singh wrote:
>> -static inline bool nvme_discovery_ctrl(struct nvme_ctrl *ctrl)
>> -{
>> - return ctrl->opts && ctrl->opts->discovery_nqn;
>> -}
>> -
> I suppose it's fine to rename this function with an nvmf_ prefix, but
> it's not really related to the rest of the patch and makes the diff
> larger than necessary.
perhaps consider making a separate patch ...
-ck
next prev parent reply other threads:[~2025-04-01 2:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 21:36 [PATCH v1 0/1] " Kamaljit Singh
2025-03-28 21:36 ` [PATCH v1 1/1] " Kamaljit Singh
2025-03-28 22:09 ` Damien Le Moal
[not found] ` <BY5PR04MB6849189D63EBB6EF4B66AD42BCAD2@BY5PR04MB6849.namprd04.prod.outlook.com>
2025-04-01 22:47 ` Kamaljit Singh
2025-03-31 7:25 ` Niklas Cassel
[not found] ` <BY5PR04MB68491AD9C47CD7AB9B552098BCAC2@BY5PR04MB6849.namprd04.prod.outlook.com>
2025-04-01 22:52 ` Kamaljit Singh
2025-03-31 15:03 ` Keith Busch
2025-04-01 2:20 ` Chaitanya Kulkarni [this message]
2025-04-01 8:04 ` Niklas Cassel
[not found] ` <BY5PR04MB68496CB7512F91FEA30DFF86BCAC2@BY5PR04MB6849.namprd04.prod.outlook.com>
2025-04-01 22:57 ` Kamaljit Singh
2025-04-02 6:37 ` Niklas Cassel
2025-04-02 21:03 ` Kamaljit Singh
2025-04-03 4:49 ` Christoph Hellwig
2025-04-03 18:59 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a54fab93-d48e-4095-89dc-97060652799a@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=kamaljit.singh1@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=niklas.cassel@wdc.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®