From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754666AbeATJ3Z (ORCPT ); Sat, 20 Jan 2018 04:29:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:50560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbeATJ3P (ORCPT ); Sat, 20 Jan 2018 04:29:15 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 927DD21716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: allow to recover node blocks given updated checkpoint To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20180120042643.20717-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Sat, 20 Jan 2018 17:29:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180120042643.20717-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/1/20 12:26, Jaegeuk Kim wrote: > If fsck.f2fs changes crc, we have no way to recover some inode blocks by roll- > forward recovery. Let's relax the condition to recover them. As this is fsck case only, what about writing checkpoint with special flag for such case, and relax the condition if flag was set, so, for normal case, it can avoid recovering obsolete data. Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/node.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h > index 0ee3e5ff49a3..15280eeb24ea 100644 > --- a/fs/f2fs/node.h > +++ b/fs/f2fs/node.h > @@ -305,10 +305,11 @@ static inline bool is_recoverable_dnode(struct page *page) > struct f2fs_checkpoint *ckpt = F2FS_CKPT(F2FS_P_SB(page)); > __u64 cp_ver = cur_cp_version(ckpt); > > - if (__is_set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG)) > + if (__is_set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG)) { > cp_ver |= (cur_cp_crc(ckpt) << 32); > - > - return cp_ver == cpver_of_node(page); > + return cp_ver == cpver_of_node(page); > + } > + return (cp_ver << 32) == (cpver_of_node(page) << 32); > } > > /* >