From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
kai.vehmanen@linux.intel.com, daniel.baluta@nxp.com
Cc: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Jaska Uimonen <jaska.uimonen@linux.intel.com>,
"moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS"
<sound-open-firmware@alsa-project.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: SOF: Update correct LED status at the first time usage of update_mute_led()
Date: Thu, 30 Apr 2020 16:24:55 -0700 [thread overview]
Message-ID: <a557561fef13e030c3b64eec62e3fd5c2e86e6d5.camel@linux.intel.com> (raw)
In-Reply-To: <20200430091139.7003-1-kai.heng.feng@canonical.com>
On Thu, 2020-04-30 at 17:11 +0800, Kai-Heng Feng wrote:
> At the first time update_mute_led() gets called, if channels are
> already
> muted, the temp value equals to led_value as 0, skipping the
> following
> LED setting.
>
> So set led_value to -1 as an uninitialized state, to update the
> correct
> LED status at first time usage.
>
> Fixes: 5d43001ae436 ("ASoC: SOF: acpi led support for switch
> controls")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
LGTM, thanks!
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
next prev parent reply other threads:[~2020-04-30 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 9:11 Kai-Heng Feng
2020-04-30 17:40 ` Kai Vehmanen
2020-04-30 23:24 ` Ranjani Sridharan [this message]
2020-05-01 11:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a557561fef13e030c3b64eec62e3fd5c2e86e6d5.camel@linux.intel.com \
--to=ranjani.sridharan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=jaska.uimonen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®