From: Chanwoo Choi <chanwoo@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH v2 1/2] extcon: max77693: add device-tree compatible string
Date: Sat, 7 Oct 2023 00:11:24 +0900 [thread overview]
Message-ID: <a557b83a-758f-e84f-bfe1-bba1b10b14a9@kernel.org> (raw)
In-Reply-To: <20231006100434.2908243-1-m.szyprowski@samsung.com>
On 23. 10. 6. 19:04, Marek Szyprowski wrote:
> Commit 57f706bf7307 ("ARM: dts: samsung: exynos4412-midas: add USB
> connector and USB OTG") added a 'muic' node to the MAX77693 PMIC
> definition in various device-tree files. Since that commit, the newly
> created MFD cell gained its own of_node and compatible string. This
> changed its modalias, what in turn broke automated loading of the driver
> module, because the new modalias is based on the of_node compatible
> string, not the platform device name.
>
> Fix this by adding the needed device-tree compatible string.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/extcon/extcon-max77693.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 1f1d9ab0c5c7..2c567e0b7b7f 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -1258,9 +1258,16 @@ static int max77693_muic_probe(struct platform_device *pdev)
> return ret;
> }
>
> +static const struct of_device_id of_max77693_muic_dt_match[] = {
> + { .compatible = "maxim,max77693-muic", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, of_max77693_muic_dt_match);
> +
> static struct platform_driver max77693_muic_driver = {
> .driver = {
> .name = DEV_NAME,
> + .of_match_table = of_max77693_muic_dt_match,
> },
> .probe = max77693_muic_probe,
> };
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2023-10-06 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231006100441eucas1p1642aee6baa9713864274aa254f4b5116@eucas1p1.samsung.com>
2023-10-06 10:04 ` Marek Szyprowski
[not found] ` <CGME20231006100442eucas1p2a51781e74ccd43bbac5c5d0eead6101f@eucas1p2.samsung.com>
2023-10-06 10:04 ` [PATCH v2 2/2] extcon: max77843: " Marek Szyprowski
2023-10-06 10:05 ` Krzysztof Kozlowski
2023-10-06 15:15 ` Chanwoo Choi
2023-10-06 10:05 ` [PATCH v2 1/2] extcon: max77693: " Krzysztof Kozlowski
2023-10-06 15:11 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a557b83a-758f-e84f-bfe1-bba1b10b14a9@kernel.org \
--to=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome