From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AD1B3C0A14 for ; Sat, 17 Oct 2026 08:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792224444; cv=none; b=LK1N+5ranIIIdKG6gg6Idfj61Cq23cPxviLu5RI8D1FbHtPY1Oxc2nD+IHA/bXAIcz1wggvqFIGBzw8h7Pz7GbvdazBbfoPIy/sGvzbfRb5VGOUgsCO85U8DfsNjHBgIqs+K8o/psVH7xMm1Exq4c4xSYLYl3QI5blroZFdxF9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792224444; c=relaxed/simple; bh=bY2jCeq3P1+EwwI8EHoEtrfZe2cRh12mwezenEG9yFU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dz8c9h1JlTTqrg3ubTN5oduuGmQiQNnv58jpumUJ0q5zbX3Ku8CzzKJsJRezKy+1HDZDWaFSNeAXFDOTSavvHdqvCt3XLIolDbAwq/Fw/juXvh8qA/hiTU0F68fzOtCysYt3TqIuQjHT2HUVD3G49VpSf5fWiB5/XegYAPhO0rY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WBzk5T7w; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Pur0euC2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WBzk5T7w"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Pur0euC2" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69H6ntsN1402579 for ; Sat, 17 Oct 2026 08:07:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= inGKjpvl5VwXPVpSApZydZ9aNOUzG556wHdzVbdOK0Q=; b=WBzk5T7w3aje8HSD 6XFT+IDo2+9Y7+pJWQqCdUM1FsOMbEdukJrGHh0ehRjwzvHG4gp6OvU4Vh4YXRgC +kKSggKsnPEB+QWHL/HqepKC6I7HwKj8yNaV1u6Tx+H/juRoq6kAyxTCpNE6xWkY AhvMB7GTxDjkMqGDcUMhVv9D66ULcdXG2vRCOiB9SH8Rcgq3HChB1z7ePrtuBF5r idvFy+5D1teoxfUybwB5tha5eCSJgX9puEXvde8XOb7QXsV+M4AfizMMpM7I0LbI oyyqLfG9c704tCsua3WnUrIO6SHISgNe7WV9aZQCk6vgFmoAiUU6NnzMQA7Qms3G VkOSkA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hbyys0maw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 08:07:22 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9308eafb465so172185985a.2 for ; Sat, 17 Oct 2026 01:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792224441; x=1792829241; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=inGKjpvl5VwXPVpSApZydZ9aNOUzG556wHdzVbdOK0Q=; b=Pur0euC2TQersrcN7jUHgfilyG1h9PmZnGsptWgOCsLfn2blwZOpjAj73Al3S6u/Gq q3LbxeKoGHwWj/FrsTnWHMWONXgXcXImoKrOQgrS4O8TF1rp+ki1dqA4w/A4l/cRnsdR jZWD3c/bXGuykJPnFb/BfqrDhff2dhop3zI4GsEU4tGIm2e7AQSFocqQK3XP+YqKM7/m 5MS2/RC68K1j3hLQZF1IdCGa0dA81Xffb7oFqhWqi/mEcKD5vSgI5u65QIN9quVbcHbv HtB/tMdsXkf9Y1QTakXrku51UbOg4JgQBldRFYbvc/Xrdro9V3/F3+/NJpUxGinD/UYG cJrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792224441; x=1792829241; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=inGKjpvl5VwXPVpSApZydZ9aNOUzG556wHdzVbdOK0Q=; b=Tv5ZPswjtzA3NA6iI73tEI+X2ajzUox79XxMH7Ffr2FpJcFLZwIm9gn2cPgaN8+fpc 8WYj88xsis1avgrvjtHtycsIlAkiSHKOY2lKEJocQ/eHS+SqUAatxd23BiJianQGWNXH Xkx/RV81N5RySO/oHZYaILeKNEum78TdBKBh4heFxUIJcz7yQ1rfashK0Al384wC7tFe c4xAMU63atTUJsJU8QUn7LP/b4B2Ho732D7wLk0xsFVF/5krU6GDLfx1FKtCcKfypKAS 2PkOBosNUOfpq6pCsGX3qId2oe10dW26YvJF8g0mGcBLTIljTQnk3gnQPCFMcdB+zTP6 dHlA== X-Forwarded-Encrypted: i=1; AKwUvByfbVFJY7Fn048ywY5pnkl6iSveLVlVtHlw4wSi9N9JWocIFd6tPCcANS3klMPr1eRcsD9pq1C5JMeMbLc=@vger.kernel.org X-Gm-Message-State: AFq9FYLhy4i2sS1GPNLlltqVmzIcYazMBYqTk1lDXH9iP788H025waxq zVJ+twviSF0Vq1tKV1RiOovXtiP+g/RUiSpUsMAPyfV094IiAUp6NsjaR+X5Ltq+mfQsa5lYf8P JXRUQP6sD2hTQ9dmaWPqP/EYBHxTBgWPUpGJqJrFuhZmflrCXKwxsfCZgzSYh3w9ez8M= X-Gm-Gg: AYBFou3Pyy6V5LQ+kC5xFtUyF1rXNyLm79+EqXA8kb6aS9gO1LmZp5VPdA3Kr5X9xHT 2JQ3sPQvk0z7rS4hjWjlKz3EDvKuTp3rJTcdXTrCQYR3x/q2rFHQJ4O1/d/0eVTPzUeGs//oeMa dJvKnspOrfJBGZZy9/s+BmOiohIppbRYWACec+1WVLpuB5BBeNwebcvbJAFHZrPaoXL1cgx9esc s/kcnTNuYZYeYd3w9At7XVHxY+0AdZ57fYoUz3xwYB1GswV+MsMaP/ILusFosiJcgrITDwcGRVI 0hDrIKUXVx3LpphMJX3cY8YYFVRg3zTc5a0SztxGBeL14w2j5nZ+TDlWW7m5WhQ0JcdKKCXG+q4 cbE+gRJk5G77Ur715auuDo/c5saWLy6jnXgKSZIg/jaJRu6Q+HCVGe5Ct X-Received: by 2002:a05:620a:2609:b0:93e:7dfa:2f3f with SMTP id af79cd13be357-93f29d9614cmr366478785a.62.1792224441276; Sat, 17 Oct 2026 01:07:21 -0700 (PDT) X-Received: by 2002:a05:620a:2609:b0:93e:7dfa:2f3f with SMTP id af79cd13be357-93f29d9614cmr366475185a.62.1792224440743; Sat, 17 Oct 2026 01:07:20 -0700 (PDT) Received: from [192.168.1.16] (46.150.72.42.lvv.nat.volia.net. [46.150.72.42]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd409989sm10501005f8f.0.2026.10.17.01.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Oct 2026 01:07:19 -0700 (PDT) Message-ID: Date: Sat, 17 Oct 2026 10:07:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: qcom: camss: configure C-PHY in the new csiphy_stream_on() To: Anusha Arun Nandi , david@ixit.cz, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, bod@kernel.org, vladimir.zapolskiy@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gjorgji.rosikopulos@oss.qualcomm.com, jigarkumar.zala@oss.qualcomm.com, hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com, bryan.odonoghue@linaro.org, linux-media@vger.kernel.org, daniel@quora.org, konrad.dybcio@oss.qualcomm.com, christopher.obbard@linaro.org, alex.vinarskis@gmail.com References: <20261017040529.3832120-1-anusha.nandi@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US In-Reply-To: <20261017040529.3832120-1-anusha.nandi@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDAzMiBTYWx0ZWRfXwSzpej0m6TFY HXXhHmk5rEuuDxOo/Q2Hzh13XC2aDRk7FehyqTD1Pfhz3J4u9TxyYQ1rnvPAfeYicWlB8KmDzHW ijyizC5aB6Yu/jqiEPToKs2bE8VRoCVQfJ4MNPfXSA8gR4JV+lLl8FGZWTpj4KXWHrQhau6oeHj GUlQ66ozyDgdMv9uu25rusW1n7lBhx2aDH8myodqb74H0QJ41b+b4KXf82Vp4SuI0fw0lulaAtd zq+byUjaOaNPuwYEmPwPiIGBoRwb5Us9vzJs6YWNHxujh+UYvQGoc9PmgRlflHY75FfAP7+oTDe JE/9svwDyMfQGASSscGPezr7IFzGXjV3QbQtWYpC1kv3RO/ZRGOfTvT5uCtH/fs42t4J39Gpf3x wzmqXFCIaGR9AUmkrVuy/TUMZpP5miWNM/0IhwdG0NR222StZA5kkKRn9TnD/9KGvCs+RIz6HSn Fldi39obfaXd8K2UXlw== X-Authority-Analysis: v=2.4 cv=W4WtxhWk c=1 sm=1 tr=0 ts=6ad32cba cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=/kTH1SCY3H94FTY3n2CK6g==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=eJoEciQUwBFPcfgth9AA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 6fqMx8Q_-t9i1OpeLG01P9BMRF_RTrxD X-Proofpoint-GUID: 6fqMx8Q_-t9i1OpeLG01P9BMRF_RTrxD X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDAzMiBTYWx0ZWRfX0/TidKOLr7Da nNsfs8lqH0rqZhUFRsms+u0ZiKDOFTGU29OkJZBxh6FQQuArnFcprewYu/0m0T8Qv5pmRJnfyGm I7EWxeHEOhjZG0sbY1DFZr3Aw3rLYmA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170032 On 17/10/2026 06:05, Anusha Arun Nandi wrote: > The new (non-legacy) csiphy_stream_on() introduced by the PHY API > devices support only built a MIPI D-PHY configuration and > unconditionally called phy_set_mode(PHY_MODE_MIPI_DPHY). For a C-PHY > sensor this makes phy_configure() dispatch to the C-PHY handler with a > D-PHY opts union, which fails validation. > > Branch on the recorded PHY type: for C-PHY build the opts via > phy_mipi_cphy_get_default_config_for_hsclk(), populate the per-trio > lane positions and polarities and select PHY_MODE_MIPI_CPHY; > keep the existing D-PHY path otherwise. The shared > phy_configure()/phy_power_on() tail handles both. I received multiple patchsets from you. CC list looks really random, half of the addresses are some internal ones? Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument, so you will not CC people just because they made one commit years ago). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. Best regards, Krzysztof