From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753209AbcIOOsS (ORCPT ); Thu, 15 Sep 2016 10:48:18 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:58828 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbcIOOsI (ORCPT ); Thu, 15 Sep 2016 10:48:08 -0400 Subject: Re: [PATCH 13/13] blk-mq: get rid of the cpumask in struct blk_mq_tags To: Christoph Hellwig , Christoph Hellwig References: <1473862739-15032-1-git-send-email-hch@lst.de> <1473862739-15032-14-git-send-email-hch@lst.de> <20160915144413.GA19508@infradead.org> CC: , , , , From: Jens Axboe Message-ID: Date: Thu, 15 Sep 2016 08:46:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160915144413.GA19508@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CO1PR16CA0020.namprd16.prod.outlook.com (10.166.27.30) To BN6PR15MB1187.namprd15.prod.outlook.com (10.172.205.141) X-MS-Office365-Filtering-Correlation-Id: 42ddd8ea-d58c-456a-3fd8-08d3dd771ee8 X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;2:W9lWewae7mPX8gb7ml8PPOJK4qBZGkezViEnFHT1kMhtHjDQi8Vab8fUcqZiSDwdxKzM/ws5hibixVfO03Ge16tPweUG3JRPyzKh1Dewv9jnUjh0geUK+gqszi7A73Z1caTmialAJa8kGUTujIT2Q1tLgzV4DM6hfxKg45F7uyWj2bafQ32EwZyFytv0qPBi;3:XPu5JC6cSaS2yYIUjmSZ94aIT/IvKx5HvzDwQSsGpDqHvCc00IL3+Yz1mQfZskyhmp+SFC1VfhhNS7jLgZcXInfTqKhFjBfyRbpMxx66a8WHUTfGxWreBS7PqILw6Cem X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;25:QUUTzHBDO0Zqxcghkv+spz+p92g0zYYSg4FdFgVc5AImHQiR2wjnzIsN7D2nSA3nI3Xqzvhaxkc8Ur619L32TO/E7z4m2D37MYeBcmPBcZKrZr76f+D2sq/OYnglQqOCQ98FaEYB5LDN7EiIak0Aw+Dr8V2TZf4lgm8drthfFvO3XmtyrsiTVGXgPTcVR6V4OwawC6w5QBgllqLGnKPc/GB+6YvQ4b3kocwACobNN7S+DHlC2DYNtOM48bcUG/U8IiwxWiyKJQMMyR1nH4WbTYJ1WGp2RIINEeCAjmbAHRcxLzOBYNJwE01TX8rZKlXhRfngI8h2BcgCEZBYXWz2oKIem43LDVjpLpH8/kVHXQJl18soI1PhXrnp8IxQlRB7xBxzRYE06CkzrvA16tybWTqwsc2/pvtR6rvMr/sNKpym1hoA0VnNHQ0IqggP8YwqA+OW54STa72ij87iqY+w2+Ta+9m47q0WZAR3MaY6/4SzKVBc/7JI9cqhDv/tA3Nr+W7XEhNAVFydRwp6fMj0UOlWi5nbUMny+Ds2gZTv7yrSZrUdWrAF+gyVlfd7P/iCn9MM3YlNe8kiR6John7hhF/Rql28OqM94dgf6IU3qdJUcZw0iw/fgHnSHPvFszV0HNfVwIM7m6FYGDPjuBihadpqpvNRucEQZ4wQrfm6pbx43BzR5W8lxf/pkRreL/1t;31:SkSrUD8WVj1/KCVf1/5cU66vejtYhbHpav40MwDd3PcDs2OdusDGjr6yNR4p4NQ7BZo+OS8nzT3RFV83JjR5EkUnWu4r7/87NjarS5mkG1ovsgMA2tEcTJFB9+q4Q31RLZaQU5tB/TvizNXpnM4e8VsKU6fnvbc7ocU5pqkJhdugbtRPVOW/v42/NeO/4XPt1CMBOKTpaeg9x2EmP+VWj2pFOvLyaCttQ7BQDCI9Ljc= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:wuPtx/tM/o3xsgcEtgx1NBGH68zkQ8E2xswWhZXIj2DEKBvUOtKBI8u6ipNU0iepXMyn+z7p7hLqZaxz7/mtAragd3Z1gPGmbL0nlRwvMHll+Gs8sWDrpDC8VxtV/Q+H1JwhxnHz4DhmKJiguKcY+hsaj1bHr7zXg+KA1dUlamA=;4:SBZLds3ctLuMK4oXd2y6jEE7hPhkhLIo9cCElUT9GNF/HSHj39dNT6/Zp7DA9YXIPz5NNKiUE3f8Jcn26URaLeHjdyvuQqn6IanH+4dLYYvVUcK6Y35Mk9ITpv3ExD/djyCTznVl4XiMKD7Bvruy8VGdse+GYzcUamUpkAISWgGpboX4c4p1izZVZ81WnvHqdkCi1MK7lt+UNMoiy8LVeZhQ2NGeJJvZKP5IwPjhfUsuJtdezUBqnU12XkjA5jjSxyR4eolbHy7GWxwELZy0yfqyTZpTsgWVwIyJTuHuUSjetrcdIviiLDdrPBI7PCMi+Z9m/PwYhARe/WZcDXhchCykjHeRLAI2LJMJqQ9sg0dSe60OfjyJLVYOSVwR3uRneIbCXqmwgrjDI24H6cnKgg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN6PR15MB1187;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Forefront-PRVS: 0066D63CE6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(377454003)(199003)(24454002)(64126003)(65806001)(65956001)(66066001)(83506001)(36756003)(3846002)(6116002)(586003)(4326007)(2906002)(92566002)(189998001)(106356001)(230700001)(105586002)(31686004)(68736007)(86362001)(33646002)(31696002)(23746002)(5660300001)(42186005)(5001770100001)(97736004)(4001350100001)(7846002)(65826007)(54356999)(76176999)(50986999)(50466002)(117156001)(81166006)(77096005)(305945005)(81156014)(7736002)(101416001)(8676002)(2950100001)(47776003)(26583001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1187;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1187;23:v6tltd6FB9y7onO5uZZieFtfRoxIFYUml/Whj?= =?Windows-1252?Q?3mJVfcxGT129AHQPYVQhNtyne/UTl3UWQaAnNcvjFd5zeitZTGDWye73?= =?Windows-1252?Q?qqhimmOFrMTE4X57Uz1+eX8xoSwoHOZnZXe8v//mROA2HFg7SyY2/1Ff?= =?Windows-1252?Q?DA67x8LkgiZ2K17Nj9/GR4fG05a2PHiivphaxHsKNRZY/1SE8JlFayNm?= =?Windows-1252?Q?AlrJNFibmf2/rk8XAqvAKwwmK6s87M3COi9uMsntpv21T2S/xR1t/jVc?= =?Windows-1252?Q?+TnvJeW/SOZhaW+opov0luX40dYtC0+bo11Q1xWJbY/yNVg/Rw1lGEA6?= =?Windows-1252?Q?3edD/AlqNhPx/dXXzslFjSocb6TPsogdjqTAIpMSj/XRnMhWeaweyqLu?= =?Windows-1252?Q?62JCYI8pKlNVWUZ4g9H1g22PGWgWyaD2Xu+aTHEcZXCWxKUvYgbHU/u2?= =?Windows-1252?Q?MQB8UDGnYDxJ/MEJ7gLHCpoLfHBumIoLttq9Xb/ZALJL04bM+KMALAZy?= =?Windows-1252?Q?tc0Uk9Rfc3U15EKKChgGu1ccuvR7Zo/CEWOIkjoT0xmOQo6+tHyU7Slb?= =?Windows-1252?Q?UCtnImcYwhUR6d2ZofnQ2Vvr51hMBpKIzWOYdQ7SuhxrtV8MGN5ECDtT?= =?Windows-1252?Q?nqh6TeLBIUjVYmHHjeu75870RXNoVwcixuwHWbLH26mYKDMpOrS2xUqi?= =?Windows-1252?Q?BTczUFklIzR8IVn65cOaz9GXYEk3xv3OrtBXfW43Uo2MZcQrmZpyGQKm?= =?Windows-1252?Q?X45Hr5O9Z69Dxg6rEbEOjJBjltIiickPabHYAYaAnBFNr8Q1S7dYnZiS?= =?Windows-1252?Q?eS8bLZFEa7RXKykx3P3Kd51QgkeRg6AKmgdpbvzEdz2pYZYqtl1mimQk?= =?Windows-1252?Q?Dhjhkw8G7veGJuYKSpa4rsQXISoQOXhEBRovPM4DbUo715fNTxRm0sfz?= =?Windows-1252?Q?OKbE3P83ODv3lLuWNU2JwYmomnSPw62F9jzj3J6qFC88b4u1QQQY7fWZ?= =?Windows-1252?Q?Kn5Iu8h4Wu+d5sdErEjdTXdlpvX2i9LSWtUMAbqRarHgWLGyzVeOWGJY?= =?Windows-1252?Q?zL6tvYqwOJjstq1ZCWQpXgZEsNqiMgrnaBMOD6rYwTQJPMkkw2yhj4YN?= =?Windows-1252?Q?P4bpycv9SjiYMNvmOM6oC4B6M7Z+sS4dMeVLByPlSM3Fg7cHC2ADQiFO?= =?Windows-1252?Q?GyyVkH9Z7uubKZew3z/x+Tf+VMCgL4ezqjPSJWbWOadz8YpQkd8QwYCk?= =?Windows-1252?Q?vzEUBNcfLmWkErURCMaWEsHUduiwsno4/DnWfFCn8qVf/rrqBnNRAf59?= =?Windows-1252?Q?2rXlHlYSJS+uvDY2d8lpdMN27X41r5qrRDkE8zrezbjf/x9zV0OD5fHK?= =?Windows-1252?Q?sjoJQji21VDrc/wff46kVzIKqC87h9aXA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;6:lAlxkoPWI82ZcIhmI3vuFad+tXExQBiGmRu/2CZsImq0yFE07tCeTJXctitGfMlB9C7dzrbZHqxPODIzgydX4w52I+4I9lldqHvZDKQKppZkIfJ8CFPBa4nijyURpzQT6kgFZA7q39jR6ACkGAH9wQH2IaFsQDawOrAnmy3eeY3GXibSrRRWL1iACo6lkOFilAJaQPi0KMYnOabv84SyhzzvU9aYKtIFZ4LEibMsfds8jo/UabIQPCAAAW5v+l0+EE6rda7RRAD6nj3RZp3agdSP8f5v7ySOuLaZdnM9zqk=;5:Xc+cm82hT9hi0hbFVbCeTTvmG632MZtuFC8umpFcvaIQ42LQChC5aV8Idr1LWYnVe+Wzi6ntjtXVSSGaZ/h78sHyOCuAImriV/RgGH/Hy0MppgRBUMS/qaM/breUKzAKTU/asu4ou/m6wYchMDDzcg==;24:dcfvXv23ioCYcvyK4Gq3Qf/RoHSZYh6VFOKgu9yxAM5VLh9RMdnPOYbm6bMHjSjtZRaOVt95Xet9aO4R7eWD9rO/VBNAOY0bIOrUW/H80DQ=;7:Yl7Uu9Ut2zDiPdgg4kxrfE8U0LEYrXG0u363YbiN6ojFxiJDk2+30rhxlWG11PaVO4hGOkm0r1751WftJycO7ruAlGnbT8Be/rHxdfysnNXywxHzFRHFzHucKdcH/9912KWMLZiEORvDiQZ6HCZ9h8GvSeC6Xt9vrgean8pGncw4CR2dxhj3qDtgt0LQYSIfDMcF2M+jSY13+4da9w1q/fwJoLMIwfQEPnvn1D60DX1RIdGphEcS2pirwnSsN6md SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:GTyon+B0HJS9Iupnm0hublcg7HCubKDLIzeiHOUN4McjW8tgqd3v3AeMAtSvLk4HpI5HG4+IOBJaoFsuYDFFrWsJmBC4CD6REHUHF6ixJ4P8JaFedWUrbldbyFGYbTD9UlmAGud4VoLGzNUMQEV6C1wbO3l1ik6JQuSP7PgGDIY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2016 14:46:46.6615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1187 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-15_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2016 08:44 AM, Christoph Hellwig wrote: >> +static int blk_mq_create_mq_map(struct blk_mq_tag_set *set, >> + const struct cpumask *affinity_mask) >> { >> + int queue = -1, cpu = 0; >> + >> + set->mq_map = kzalloc_node(sizeof(*set->mq_map) * nr_cpu_ids, >> + GFP_KERNEL, set->numa_node); >> + if (!set->mq_map) >> + return -ENOMEM; >> + >> + if (!affinity_mask) >> + return 0; /* map all cpus to queue 0 */ >> + >> + /* If cpus are offline, map them to first hctx */ >> + for_each_online_cpu(cpu) { >> + if (cpumask_test_cpu(cpu, affinity_mask)) >> + queue++; >> + if (queue >= 0) >> + set->mq_map[cpu] = queue; >> + } >> + >> + return 0; >> } > > I just noticed that the patch adds this unused function due to a rebase > error. Jens, do you you just want to fix this up while applying or > should I resend? Killed it off manually, I already applied and pushed it out. -- Jens Axboe