From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6EAC46467 for ; Sat, 26 Nov 2022 16:27:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbiKZQ1V (ORCPT ); Sat, 26 Nov 2022 11:27:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbiKZQ1R (ORCPT ); Sat, 26 Nov 2022 11:27:17 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66B6A26A; Sat, 26 Nov 2022 08:27:16 -0800 (PST) Received: from [192.168.1.104] (unknown [103.238.109.19]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 600A1471; Sat, 26 Nov 2022 17:27:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669480033; bh=9JgwMYaMqW628l2Ol/scePAZkaal2MIBpF9/7ieZUYU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NyL1IUSIS9+5gvfkmBxMMqCbVEiIpkAT8Q+t9SFRNRchj2SyoOTkT0t4fGhSY+YP7 uPi/myeHxO09kbL0LUFo0QSYA4If9VTQn+mygQrIQDtJxIiwXiHw/OM5/jLFrtpEwf THnXDhut39B7Bd7CPd0zmdT63lsZ1qNMfjj35iDk= Message-ID: Date: Sat, 26 Nov 2022 21:56:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 00/14] staging: vc04_services: bcm2835-isp support To: Stefan Wahren , linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list Cc: Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham , Laurent Pinchart References: <20221121214722.22563-1-umang.jain@ideasonboard.com> Content-Language: en-US From: Umang Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan On 11/26/22 8:12 PM, Stefan Wahren wrote: > Hi Umang, > > Am 21.11.22 um 22:47 schrieb Umang Jain: >> This series aims to upport bcm2835-isp from the RPi kernel [1] and is a >> independent subset of earlier series [2] posted to upport CSI-2/CCP2 >> receiver IP core("Unicam) + the ISP driver found in BCM283x and >> compatible >> SoCs (namely BCM2711). Unicam is still under active development to work >> with multistream support to get into mainline. Hence only the ISP driver >> will remain the primary area of this series. > > thanks for working on this. But honestly i would prefer that vchiq > comes out of staging before adding more features. As Greg said some > time ago staging is not a place to "dump code and run away". These new > files are in the same bad shape as the rest of vc04 before the > clean-up here in staging started. Certainly, I am not here to do that - but I am still learning the ropes. If the staging issue is becoming a blocker for bcm2835-isp going upstream, I would be happy to help here! Though I must mention that I still have limited visibility so my aim would be to chart out a plan of things needed to be done to get vc04_services out of staging! > > I agree that VCSM is on the TODO list for vchiq, but this driver is > not necessary for making bcm2835-audio & bcm2835-camera leave staging. > It just binds more resources on a new feature. I see two TODO files in vc04_services:     ./bcm2835-camera/TODO     ./interface/TODO One of the bcm2835-camera TODO points to the vc-sm-cma driver itself. So that's address in the series. The other remaining one - I will need to take a deeper look before commenting on it. The main chunk of TODO are in vc04_services/interfaces/TODO.  Doing a cursory reading of them suggests that these apply to *all* vc04_services components? Am I right? Are these are the specific bits of cleanup you are referring to in your comment? > > Unfortuntately i hadn't much time to work on vchiq by myself. > > Just my two cents > Stefan >