mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	LKML <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path
Date: Mon, 30 Jan 2023 10:09:56 -0700	[thread overview]
Message-ID: <a56e460e-f8f5-97e6-f469-9ae44b0eedc2@linuxfoundation.org> (raw)
In-Reply-To: <7023e3f3-bfd3-5842-5624-b1fd21576591@efficios.com>

On 1/30/23 10:00, Mathieu Desnoyers wrote:
> On 2023-01-30 11:26, Alexei Starovoitov wrote:
>> On Mon, Jan 30, 2023 at 8:12 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>>
>>> On 1/27/23 06:57, Mathieu Desnoyers wrote:
>>>> Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents
>>>> building against kernel headers from the build environment in scenarios
>>>> where kernel headers are installed into a specific output directory
>>>> (O=...).
>>>>
>>>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>>>> Cc: Shuah Khan <shuah@kernel.org>
>>>> Cc: linux-kselftest@vger.kernel.org
>>>> Cc: Ingo Molnar <mingo@redhat.com>
>>>> Cc: <stable@vger.kernel.org>    [5.18+]
>>>> ---
>>>>    tools/testing/selftests/bpf/Makefile | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
>>>> index c22c43bbee19..6998c816afef 100644
>>>> --- a/tools/testing/selftests/bpf/Makefile
>>>> +++ b/tools/testing/selftests/bpf/Makefile
>>>> @@ -327,7 +327,7 @@ endif
>>>>    CLANG_SYS_INCLUDES = $(call get_sys_includes,$(CLANG),$(CLANG_TARGET_ARCH))
>>>>    BPF_CFLAGS = -g -Werror -D__TARGET_ARCH_$(SRCARCH) $(MENDIAN)               \
>>>>             -I$(INCLUDE_DIR) -I$(CURDIR) -I$(APIDIR)                   \
>>>> -          -I$(abspath $(OUTPUT)/../usr/include)
>>>> +          $(KHDR_INCLUDES)
>>>>
>>>>    CLANG_CFLAGS = $(CLANG_SYS_INCLUDES) \
>>>>               -Wno-compare-distinct-pointer-types
>>>
>>>
>>>
>>> Adding bpf maintainers - bpf patches usually go through bpf tree.
>>>
>>> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>>
>> Please resubmit as separate patch with [PATCH bpf-next] subj
>> and cc bpf@vger, so that BPF CI can test it on various architectures
>> and config combinations.
> 
> Hi Shuah,
> 
> Do you have means to resubmit it on your end, or should I do it ?
> 

Hi Mathieu,

Please go ahead and resubmit.

thanks,
-- Shuah


  reply	other threads:[~2023-01-30 17:10 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 13:57 [PATCH 00/34] selftests: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 01/34] selftests: arm64: " Mathieu Desnoyers
2023-01-30 16:09   ` Shuah Khan
2023-01-30 17:14     ` Catalin Marinas
2023-01-30 17:20       ` Shuah Khan
2023-01-27 13:57 ` [PATCH 02/34] selftests: bpf: " Mathieu Desnoyers
2023-01-30 16:12   ` Shuah Khan
2023-01-30 16:26     ` Alexei Starovoitov
2023-01-30 17:00       ` Mathieu Desnoyers
2023-01-30 17:09         ` Shuah Khan [this message]
2023-01-27 13:57 ` [PATCH 03/34] selftests: clone3: " Mathieu Desnoyers
2023-01-30 16:15   ` Shuah Khan
2023-01-30 16:26     ` Christian Brauner
2023-01-27 13:57 ` [PATCH 04/34] selftests: core: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 05/34] selftests: dma: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 06/34] selftests: dmabuf-heaps: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 07/34] selftests: drivers: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 08/34] selftests: filesystems: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 09/34] selftests: futex: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 10/34] selftests: gpio: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 11/34] selftests: ipc: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 12/34] selftests: kcmp: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 13/34] selftests: media_tests: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 14/34] selftests: membarrier: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 15/34] selftests: mount_setattr: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 16/34] selftests: move_mount_set_group: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 17/34] selftests: net: " Mathieu Desnoyers
2023-01-27 16:21   ` Matthieu Baerts
2023-01-27 16:42     ` Mathieu Desnoyers
2023-01-30 16:24   ` Shuah Khan
2023-01-27 13:57 ` [PATCH 18/34] selftests: perf_events: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 19/34] selftests: pid_namespace: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 20/34] selftests: pidfd: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 21/34] selftests: powerpc: " Mathieu Desnoyers
2023-01-30 16:32   ` Shuah Khan
2023-01-27 13:57 ` [PATCH 22/34] selftests: ptp: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 23/34] selftests: rseq: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 24/34] selftests: sched: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 25/34] selftests: seccomp: " Mathieu Desnoyers
2023-01-30 16:52   ` Shuah Khan
2023-01-27 13:57 ` [PATCH 26/34] selftests: sync: " Mathieu Desnoyers
2023-01-30 16:44   ` Shuah Khan
2023-01-30 16:51     ` Shuah Khan
2023-01-27 13:57 ` [PATCH 27/34] selftests: user_events: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 28/34] selftests: vm: " Mathieu Desnoyers
2023-01-30 16:55   ` Shuah Khan
2023-01-27 13:57 ` [PATCH 29/34] selftests: x86: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 30/34] selftests: bpf docs: Use installed " Mathieu Desnoyers
2023-01-30 16:57   ` Shuah Khan
2023-01-27 13:57 ` [PATCH 31/34] selftests: iommu: " Mathieu Desnoyers
2023-01-30 17:01   ` Shuah Khan
2023-01-30 17:05     ` Jason Gunthorpe
2023-01-27 13:57 ` [PATCH 32/34] selftests: memfd: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 33/34] selftests: ptrace: " Mathieu Desnoyers
2023-01-27 13:57 ` [PATCH 34/34] selftests: tdx: " Mathieu Desnoyers
2023-01-30 22:29 ` [PATCH 00/34] selftests: Fix incorrect " Shuah Khan
2023-01-30 23:45   ` Alexei Starovoitov
2023-01-30 23:48     ` Shuah Khan
2023-01-30 23:49       ` Alexei Starovoitov
2023-02-02  2:07   ` Shuah Khan
2023-02-04  1:06     ` Shuah Khan
2023-02-11  0:15       ` Shuah Khan
2023-02-20  3:49 ` (subset) " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a56e460e-f8f5-97e6-f469-9ae44b0eedc2@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®