From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751862AbdK3GlV (ORCPT ); Thu, 30 Nov 2017 01:41:21 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37783 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbdK3GlT (ORCPT ); Thu, 30 Nov 2017 01:41:19 -0500 X-Google-Smtp-Source: AGs4zMbLeT3oXEj0VFT27y5j0qSfUSuEVfTiJuYDBihTGinGgjgoXzl6KAycyn7sPWqMpDc/8QWELA== Subject: Re: jsm_tty: Fix a possible null pointer dereference in two functions To: SF Markus Elfring , Greg Kroah-Hartman , linux-serial@vger.kernel.org Cc: "Guilherme G. Piccoli" , Joe Perches , kernel-janitors@vger.kernel.org, LKML References: <5c78db97-88f5-8655-9a47-eeee0a043fba@users.sourceforge.net> <1511976187.19952.65.camel@perches.com> <20171129173504.GA20581@kroah.com> <1511977896.19952.69.camel@perches.com> <20171129180528.GA24705@kroah.com> <089a4b85-64e8-cb4a-c5f8-9abb2556e5e5@users.sourceforge.net> From: Jiri Slaby Message-ID: Date: Thu, 30 Nov 2017 07:41:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <089a4b85-64e8-cb4a-c5f8-9abb2556e5e5@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2017, 07:19 PM, SF Markus Elfring wrote: >>> It's pretty unlikely, but it is an actual defect. >> >> No it is not, those variables will never be set to NULL, >> so this can never be triggered. Walk up the call chain. > > If the involved software developers are convinced about the validity > of this pointer: > > How do you think about to delete the following condition check > instead in the discussed function implementations? > > if (!ch) > return; ACK thanks, -- js suse labs