From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752487AbdJ0Jl6 convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 05:41:58 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:7612 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752026AbdJ0Jl4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 05:41:56 -0400
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 27 Oct 2017 02:41:48 -0700
From: Jeetesh Burman <jburman@nvidia.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
CC: "keescook@chromium.org" <keescook@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bibek Basu <bbasu@nvidia.com>
Subject: RE: [PATCH] panic: add support to update panic_timeout via DT
Thread-Topic: [PATCH] panic: add support to update panic_timeout via DT
Thread-Index: AQHTTte+2FgVhX6ub0WFt9dqbHxnK6L3VYQAgAAYQPA=
Date: Fri, 27 Oct 2017 09:39:12 +0000
Message-ID: <a573218f5deb4b3288e2faed00392a4d@BGMAIL104.nvidia.com>
References: <1509076662-22253-1-git-send-email-jburman@nvidia.com>
 <20171027080006.GA609@tigerII.localdomain>
In-Reply-To: <20171027080006.GA609@tigerII.localdomain>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.47.39]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sergey,

Thanks for review, 'PATCH V2' uploaded

> why init_oops_id()? you are going to re-read it every time you call
> print_oops_end_marker(), and the system can be configured not to panic on
> oops. put it to oops_setup()? or, at least, move it to `if (!oops_id)' branch,
> maybe?
[Jeetesh] It looks to make changes in oops_setup(), need to pass "oops" parameter in kernel-command
line, so I made changes under 'if (!oops_id)', please review "PATCH V2"

Regards,
Jeetesh

> -----Original Message-----
> From: Sergey Senozhatsky [mailto:sergey.senozhatsky@gmail.com]
> Sent: Friday, October 27, 2017 1:30 PM
> To: Jeetesh Burman <jburman@nvidia.com>
> Cc: sergey.senozhatsky@gmail.com; keescook@chromium.org; linux-
> kernel@vger.kernel.org; Bibek Basu <bbasu@nvidia.com>
> Subject: Re: [PATCH] panic: add support to update panic_timeout via DT
> 
> On (10/27/17 09:27), Jeetesh Burman wrote:
> > Add support to set 'panic_timeout' value via dtb to have control from
> > device tree. This makes sense when you have multiple platforms support
> > from same defconfig and differentiated only through device tree blob.
> > The patch will check for panic time out value coming from dtb if it
> > exists, otherwise continues with defconfig provided option.
> 
> *my personal opinion* - I'm not super happy to see more and more
> of_find_node_by_name()'s in random places. but that's just IMHO.
> 
> >  static int init_oops_id(void)
> >  {
> > +	struct device_node *np;
> > +
> > +	np = of_find_node_by_name(NULL, "panic_timeout");
> > +	if (np)
> > +		of_property_read_u32(np, "panic-timeout-value",
> &panic_timeout);
> > +
> >  	if (!oops_id)
> >  		get_random_bytes(&oops_id, sizeof(oops_id));
> >  	else
> 
> why init_oops_id()? you are going to re-read it every time you call
> print_oops_end_marker(), and the system can be configured not to panic on
> oops. put it to oops_setup()? or, at least, move it to `if (!oops_id)' branch,
> maybe?
> 
> 	-ss