From: Judith Mendez <jm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-can@vger.kernel.org>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Schuyler Patton <spatton@ti.com>, <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/2] can: m_can: Add hrtimer to generate software interrupt
Date: Fri, 12 May 2023 15:26:10 -0500 [thread overview]
Message-ID: <a5754d69-16c1-c217-f4cb-ea0b5e068bd2@ti.com> (raw)
In-Reply-To: <20230511062353.GE14287@atomide.com>
Hello Tony,
On 5/11/23 01:23, Tony Lindgren wrote:
> Hi,
>
> * Judith Mendez <jm@ti.com> [230510 20:31]:
>> Add an hrtimer to MCAN class device. Each MCAN will have its own
>> hrtimer instantiated if there is no hardware interrupt found and
>> poll-interval property is defined in device tree M_CAN node.
>>
>> The hrtimer will generate a software interrupt every 1 ms. In
>> hrtimer callback, we check if there is a transaction pending by
>> reading a register, then process by calling the isr if there is.
>
> So what about system suspend, do you need to do something to
> ensure the timer does not happen to run while suspending?
Great question. Tested the MCAN using timer polling method and
it seems to suspend to RAM but not resume. Meanwhile MCAN using
hardware irq suspends and resumes from RAM just fine. Will look
deeper into this here soon. Thank you Tony for bringing this up.
regards,
Judith
prev parent reply other threads:[~2023-05-12 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 20:29 [PATCH v5 0/2] Enable multiple MCAN on AM62x Judith Mendez
2023-05-10 20:29 ` [PATCH v5 1/2] dt-bindings: net: can: Add poll-interval for MCAN Judith Mendez
2023-05-11 9:30 ` Krzysztof Kozlowski
2023-05-10 20:29 ` [PATCH v5 2/2] can: m_can: Add hrtimer to generate software interrupt Judith Mendez
2023-05-11 6:23 ` Tony Lindgren
2023-05-12 20:26 ` Judith Mendez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5754d69-16c1-c217-f4cb-ea0b5e068bd2@ti.com \
--to=jm@ti.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=socketcan@hartkopp.net \
--cc=spatton@ti.com \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®