From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755457AbdIGPHX (ORCPT ); Thu, 7 Sep 2017 11:07:23 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:37226 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbdIGPHV (ORCPT ); Thu, 7 Sep 2017 11:07:21 -0400 X-Google-Smtp-Source: ADKCNb50j8lyvo/LED9RX68MBRSTCFfOV5W48KU3GWgV7r6GEYbUx2L8jvQyByHs2XEerBYui1o1iA== Subject: Re: [PATCH] perf sched timehist: Add pid and tid options To: namhyung@kernel.org, acme@redhat.com Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo References: <1504288152-19690-1-git-send-email-dsahern@gmail.com> From: David Ahern Message-ID: Date: Thu, 7 Sep 2017 09:07:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504288152-19690-1-git-send-email-dsahern@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo: are you ok with this change? On 9/1/17 11:49 AM, David Ahern wrote: > Add options to only show event for specific pid(s) and tid(s). > > Signed-off-by: David Ahern > --- > tools/perf/Documentation/perf-sched.txt | 8 ++++++++ > tools/perf/builtin-sched.c | 4 ++++ > 2 files changed, 12 insertions(+) > > diff --git a/tools/perf/Documentation/perf-sched.txt b/tools/perf/Documentation/perf-sched.txt > index a092a2499e8f..55b67338548e 100644 > --- a/tools/perf/Documentation/perf-sched.txt > +++ b/tools/perf/Documentation/perf-sched.txt > @@ -106,6 +106,14 @@ OPTIONS for 'perf sched timehist' > --max-stack:: > Maximum number of functions to display in backtrace, default 5. > > +-p=:: > +--pid=:: > + Only show events for given process ID (comma separated list). > + > +-t=:: > +--tid=:: > + Only show events for given thread ID (comma separated list). > + > -s:: > --summary:: > Show only a summary of scheduling by thread with min, max, and average > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index 322b4def8411..b7e8812ee80c 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -3363,6 +3363,10 @@ int cmd_sched(int argc, const char **argv) > OPT_STRING(0, "time", &sched.time_str, "str", > "Time span for analysis (start,stop)"), > OPT_BOOLEAN(0, "state", &sched.show_state, "Show task state when sched-out"), > + OPT_STRING('p', "pid", &symbol_conf.pid_list_str, "pid[,pid...]", > + "analyze events only for given process id(s)"), > + OPT_STRING('t', "tid", &symbol_conf.tid_list_str, "tid[,tid...]", > + "analyze events only for given thread id(s)"), > OPT_PARENT(sched_options) > }; > >