From: Yang Ruibin <11162571@vivo.com>
To: "Kenneth Feng" <kenneth.feng@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Xinhui Pan" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v3] fix up the misspellings
Date: Mon, 26 Aug 2024 12:15:30 +0800 [thread overview]
Message-ID: <a57b41ee-e2ee-42e7-9c2a-619202648fbb@vivo.com> (raw)
In-Reply-To: <20240826025522.1474757-1-11162571@vivo.com>
Sorry, please ignore this patch for now. As the wrong subject line.
This patch will be updated later.
在 2024/8/26 10:55, Yang Ruibin 写道:
> Hightest is a typo. It should be highest.Please ensure
> the consistency of variable naming.
>
> Signed-off-by: Yang Ruibin <11162571@vivo.com>
> ---
> Changes V3:
> -Updated the ignored misspellings
> ---
> .../drm/amd/pm/powerplay/smumgr/fiji_smumgr.c | 16 ++++++++--------
> .../amd/pm/powerplay/smumgr/polaris10_smumgr.c | 16 ++++++++--------
> .../drm/amd/pm/powerplay/smumgr/vegam_smumgr.c | 16 ++++++++--------
> 3 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c
> index 5e43ad2b2956..e16efc44df88 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c
> @@ -1014,7 +1014,7 @@ static int fiji_populate_all_graphic_levels(struct pp_hwmgr *hwmgr)
> struct SMU73_Discrete_GraphicsLevel *levels =
> smu_data->smc_state_table.GraphicsLevel;
> uint32_t i, max_entry;
> - uint8_t hightest_pcie_level_enabled = 0,
> + uint8_t highest_pcie_level_enabled = 0,
> lowest_pcie_level_enabled = 0,
> mid_pcie_level_enabled = 0,
> count = 0;
> @@ -1054,27 +1054,27 @@ static int fiji_populate_all_graphic_levels(struct pp_hwmgr *hwmgr)
> } else {
> while (data->dpm_level_enable_mask.pcie_dpm_enable_mask &&
> ((data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> - (1 << (hightest_pcie_level_enabled + 1))) != 0))
> - hightest_pcie_level_enabled++;
> + (1 << (highest_pcie_level_enabled + 1))) != 0))
> + highest_pcie_level_enabled++;
>
> while (data->dpm_level_enable_mask.pcie_dpm_enable_mask &&
> ((data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> (1 << lowest_pcie_level_enabled)) == 0))
> lowest_pcie_level_enabled++;
>
> - while ((count < hightest_pcie_level_enabled) &&
> + while ((count < highest_pcie_level_enabled) &&
> ((data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> (1 << (lowest_pcie_level_enabled + 1 + count))) == 0))
> count++;
>
> mid_pcie_level_enabled = (lowest_pcie_level_enabled + 1 + count) <
> - hightest_pcie_level_enabled ?
> + highest_pcie_level_enabled ?
> (lowest_pcie_level_enabled + 1 + count) :
> - hightest_pcie_level_enabled;
> + highest_pcie_level_enabled;
>
> - /* set pcieDpmLevel to hightest_pcie_level_enabled */
> + /* set pcieDpmLevel to highest_pcie_level_enabled */
> for (i = 2; i < dpm_table->sclk_table.count; i++)
> - levels[i].pcieDpmLevel = hightest_pcie_level_enabled;
> + levels[i].pcieDpmLevel = highest_pcie_level_enabled;
>
> /* set pcieDpmLevel to lowest_pcie_level_enabled */
> levels[0].pcieDpmLevel = lowest_pcie_level_enabled;
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c
> index ff6b563ecbf5..d785cc6468ef 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c
> @@ -1050,7 +1050,7 @@ static int polaris10_populate_all_graphic_levels(struct pp_hwmgr *hwmgr)
> struct SMU74_Discrete_GraphicsLevel *levels =
> smu_data->smc_state_table.GraphicsLevel;
> uint32_t i, max_entry;
> - uint8_t hightest_pcie_level_enabled = 0,
> + uint8_t highest_pcie_level_enabled = 0,
> lowest_pcie_level_enabled = 0,
> mid_pcie_level_enabled = 0,
> count = 0;
> @@ -1114,27 +1114,27 @@ static int polaris10_populate_all_graphic_levels(struct pp_hwmgr *hwmgr)
> } else {
> while (hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &&
> ((hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> - (1 << (hightest_pcie_level_enabled + 1))) != 0))
> - hightest_pcie_level_enabled++;
> + (1 << (highest_pcie_level_enabled + 1))) != 0))
> + highest_pcie_level_enabled++;
>
> while (hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &&
> ((hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> (1 << lowest_pcie_level_enabled)) == 0))
> lowest_pcie_level_enabled++;
>
> - while ((count < hightest_pcie_level_enabled) &&
> + while ((count < highest_pcie_level_enabled) &&
> ((hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> (1 << (lowest_pcie_level_enabled + 1 + count))) == 0))
> count++;
>
> mid_pcie_level_enabled = (lowest_pcie_level_enabled + 1 + count) <
> - hightest_pcie_level_enabled ?
> + highest_pcie_level_enabled ?
> (lowest_pcie_level_enabled + 1 + count) :
> - hightest_pcie_level_enabled;
> + highest_pcie_level_enabled;
>
> - /* set pcieDpmLevel to hightest_pcie_level_enabled */
> + /* set pcieDpmLevel to highest_pcie_level_enabled */
> for (i = 2; i < dpm_table->sclk_table.count; i++)
> - levels[i].pcieDpmLevel = hightest_pcie_level_enabled;
> + levels[i].pcieDpmLevel = highest_pcie_level_enabled;
>
> /* set pcieDpmLevel to lowest_pcie_level_enabled */
> levels[0].pcieDpmLevel = lowest_pcie_level_enabled;
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/vegam_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/vegam_smumgr.c
> index 34c9f59b889a..3e73f380a591 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/vegam_smumgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/vegam_smumgr.c
> @@ -878,7 +878,7 @@ static int vegam_populate_all_graphic_levels(struct pp_hwmgr *hwmgr)
> struct SMU75_Discrete_GraphicsLevel *levels =
> smu_data->smc_state_table.GraphicsLevel;
> uint32_t i, max_entry;
> - uint8_t hightest_pcie_level_enabled = 0,
> + uint8_t highest_pcie_level_enabled = 0,
> lowest_pcie_level_enabled = 0,
> mid_pcie_level_enabled = 0,
> count = 0;
> @@ -925,27 +925,27 @@ static int vegam_populate_all_graphic_levels(struct pp_hwmgr *hwmgr)
> } else {
> while (hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &&
> ((hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> - (1 << (hightest_pcie_level_enabled + 1))) != 0))
> - hightest_pcie_level_enabled++;
> + (1 << (highest_pcie_level_enabled + 1))) != 0))
> + highest_pcie_level_enabled++;
>
> while (hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &&
> ((hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> (1 << lowest_pcie_level_enabled)) == 0))
> lowest_pcie_level_enabled++;
>
> - while ((count < hightest_pcie_level_enabled) &&
> + while ((count < highest_pcie_level_enabled) &&
> ((hw_data->dpm_level_enable_mask.pcie_dpm_enable_mask &
> (1 << (lowest_pcie_level_enabled + 1 + count))) == 0))
> count++;
>
> mid_pcie_level_enabled = (lowest_pcie_level_enabled + 1 + count) <
> - hightest_pcie_level_enabled ?
> + highest_pcie_level_enabled ?
> (lowest_pcie_level_enabled + 1 + count) :
> - hightest_pcie_level_enabled;
> + highest_pcie_level_enabled;
>
> - /* set pcieDpmLevel to hightest_pcie_level_enabled */
> + /* set pcieDpmLevel to highest_pcie_level_enabled */
> for (i = 2; i < dpm_table->sclk_table.count; i++)
> - levels[i].pcieDpmLevel = hightest_pcie_level_enabled;
> + levels[i].pcieDpmLevel = highest_pcie_level_enabled;
>
> /* set pcieDpmLevel to lowest_pcie_level_enabled */
> levels[0].pcieDpmLevel = lowest_pcie_level_enabled;
prev parent reply other threads:[~2024-08-26 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 2:55 Yang Ruibin
2024-08-26 4:15 ` Yang Ruibin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a57b41ee-e2ee-42e7-9c2a-619202648fbb@vivo.com \
--to=11162571@vivo.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kenneth.feng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®