From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8926BC83008 for ; Tue, 28 Apr 2020 12:40:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65FF7206D9 for ; Tue, 28 Apr 2020 12:40:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726808AbgD1MkB (ORCPT ); Tue, 28 Apr 2020 08:40:01 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3370 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726678AbgD1MkB (ORCPT ); Tue, 28 Apr 2020 08:40:01 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 8BC8EF9C70D98CA403CF; Tue, 28 Apr 2020 20:39:57 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 28 Apr 2020 20:39:51 +0800 Subject: Re: [PATCH 2/7] staging: rtl8723bs: os_dep: remove set but not used 'size' To: Greg KH CC: , , , Hulk Robot References: <20200427032342.27211-1-yanaijie@huawei.com> <20200427032342.27211-3-yanaijie@huawei.com> <20200428122853.GB1253850@kroah.com> From: Jason Yan Message-ID: Date: Tue, 28 Apr 2020 20:39:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200428122853.GB1253850@kroah.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/4/28 20:28, Greg KH 写道: > On Mon, Apr 27, 2020 at 11:23:37AM +0800, Jason Yan wrote: >> And also remove the NULL check before kfree() because kfree() can handle >> NULL pointers correctly. >> >> Fix the following gcc warning: >> >> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:157:6: warning: >> variable ‘size’ set but not used [-Wunused-but-set-variable] >> u32 size = 0; >> ^~~~ >> >> Reported-by: Hulk Robot >> Signed-off-by: Jason Yan >> --- >> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 11 ----------- >> 1 file changed, 11 deletions(-) >> >> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c >> index 1ba85a43f05a..b037868fbf22 100644 >> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c >> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c >> @@ -154,17 +154,6 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc( >> >> static void rtw_spt_band_free(struct ieee80211_supported_band *spt_band) >> { >> - u32 size = 0; >> - >> - if (!spt_band) >> - return; >> - >> - if (spt_band->band == NL80211_BAND_2GHZ) >> - { >> - size = sizeof(struct ieee80211_supported_band) >> - + sizeof(struct ieee80211_channel)*RTW_2G_CHANNELS_NUM >> - + sizeof(struct ieee80211_rate)*RTW_G_RATES_NUM; >> - } >> kfree(spt_band); >> } > > This function can now be removed and replaced with the call to kfree(), > right? Can you send a follow-on patch to do that? > Sure. > thanks, > > greg k-h > > . >