mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Zheao Li <me@manjusaka.me>,
	edumazet@google.com, bpf@vger.kernel.org, davem@davemloft.net,
	dsahern@kernel.org, kuba@kernel.org,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	mhiramat@kernel.org, ncardwell@google.com,
	netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v3] tracepoint: add new `tcp:tcp_ca_event` trace event
Date: Sat, 12 Aug 2023 19:08:20 -0700	[thread overview]
Message-ID: <a587dac9e02cfde669743fd54ab41a3c6014c5e9.camel@perches.com> (raw)
In-Reply-To: <20230812215327.1dbd30f3@rorschach.local.home>

On Sat, 2023-08-12 at 21:53 -0400, Steven Rostedt wrote:
> On Sat, 12 Aug 2023 18:17:17 -0700
> Joe Perches <joe@perches.com> wrote:
> 
> > > I forgot to say "for TRACE_EVENT() macros". This is not about what
> > > checkpatch says about other code.  
> > 
> > trace has its own code style and checkpatch needs another
> > parsing mechanism just for it, including the alignment to
> > open parenthesis test.
> 
> If you have a template patch to add the parsing mechanism, I'd be happy
> to try to fill in the style.

There is no checkpatch mechanism per se.  It's all ad-hoc.

Perhaps something like this though would work well enough
as it just avoids all the other spacing checks and such.
---
 scripts/checkpatch.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 528f619520eb9..3017f4dd09fd2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3947,6 +3947,9 @@ sub process {
 			}
 		}
 
+# trace include files use a completely different grammar
+		next if ($realfile =~ m{(?:include/trace/events/|/trace\.h$/)});
+
 # check multi-line statement indentation matches previous line
 		if ($perl_version_ok &&
 		    $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|(?:\*\s*)*$Lval\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {




  reply	other threads:[~2023-08-13  2:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 18:33 [PATCH] tracepoint: add new `tcp:tcp_ca_event_set` " Manjusaka
2023-08-07 20:00 ` Neal Cardwell
2023-08-08  4:29   ` Manjusaka
2023-08-08  4:50   ` Manjusaka
2023-08-08  5:58   ` [PATCH v2] tracepoint: add new `tcp:tcp_ca_event` " Manjusaka
2023-08-08  8:26     ` Eric Dumazet
2023-08-08  8:46       ` Manjusaka
2023-08-08  8:48         ` Eric Dumazet
2023-08-12 20:12           ` [PATCH v3] " Zheao Li
2023-08-12 20:17             ` Manjusaka
2023-08-12 23:00               ` Steven Rostedt
2023-08-13  0:59             ` Steven Rostedt
2023-08-13  1:01               ` Steven Rostedt
2023-08-13  1:04                 ` Steven Rostedt
2023-08-13  1:17                   ` Joe Perches
2023-08-13  1:53                     ` Steven Rostedt
2023-08-13  2:08                       ` Joe Perches [this message]
2023-08-16  6:09                         ` Manjusaka
2023-08-16 15:02                           ` Steven Rostedt
2023-08-16 16:58                             ` Manjusaka
2023-08-19  1:51             ` Jakub Kicinski
2023-08-19  3:10               ` Eric Dumazet
2023-08-19  8:15                 ` Manjusaka
2023-08-08 20:21     ` [PATCH v2] " Jakub Kicinski
2023-08-09 16:55       ` Manjusaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a587dac9e02cfde669743fd54ab41a3c6014c5e9.camel@perches.com \
    --to=joe@perches.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=me@manjusaka.me \
    --cc=mhiramat@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®