From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C8E3AC0C2 for ; Thu, 19 Mar 2026 14:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773931311; cv=none; b=WUID5Sq6PJohNM79LJ3bFKEEJ5oMxe8NU0Jrq6eSGxoGNMxvhqVni9ZIGI7+IsfQSJklvtWeihcHrvGEavArsxx7xXaTl4XAP+3mD4bsd1fSgioDjc8upAq5exU7A3j45n7cXJ2429vwnYrIEndobbnVhgFoZLsurQi7YibLyQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773931311; c=relaxed/simple; bh=7JJItK1EbpqtAuuT5E/BuYdP/SbDJl/r9WsVMqXZYOM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VVvJZaw1HjNZ1isVCY5YrNXkZWwOdiDS8QSvm7B2hfe+HifPyfY72FH8WnJs+ceLZlo5hmI6E91zJ0kWbvRaA8zXdxPxWSIFDJki132OT1oZerUZ4TDsgEqMByOFwNqR1oQcQVT8+ZMm/JxBBgS/4IGNcunVFS9KaHYVUGWjtfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQX9q88N; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQX9q88N" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2aaed195901so3313465ad.0 for ; Thu, 19 Mar 2026 07:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773931309; x=1774536109; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=szX8KuRPyf5Ig4UEEtTihMfJ0qSCJ5cmhiHMpFHTxGo=; b=aQX9q88NPUl4ouivM/INg9iCESFJy7VKp+Uyg2skc8pPSixJAr1QFfhmpIJ2iiKWJQ RBd62tOxqscDtQIvwpoCoKjeX/tV87/fi++nu0j5FtRj/e8ee9BIjCypCLmCdEVsWlMy Yu1rKpWMA4BGhpJpID5A6eFIxeOnPV82tPj4ZJncQ9i0NvOcTRCbac8K9EKwypTJupra s0OdGId4qy9cYV4S2OS9iN/ukDNXy7YzUa9OvlJidOE5ibGs/odtD9YnwF0PlMrD8cEL kJ75l1xs4Z2YFfenSf7oreIe875Bt2gZM5gZgJn3kAT+h7/ICNcDGW9kBn+AMtHffnw7 egfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773931309; x=1774536109; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=szX8KuRPyf5Ig4UEEtTihMfJ0qSCJ5cmhiHMpFHTxGo=; b=eZd9MADXicmlh8w9naVrBemirkpvsHtuFdWYsJoO6Hieh0Kv+QjYqg3/RCCB6OcFMH G1FCMyUDJ5x5rYuUK7hLlfM9Mu35vdpF+IC/SATewKLvc7R2EKihuyeOI8QlkIL1u5Ac CYGZxJMaat1tDori0Ei+fwLqGItJyCov/Rf9vEP7vkQH+W9+/lbfID9OPo2as+i9t3k6 y7TsBlFLKDybnHaeikFd8hy99j+KnSWuNsroZ4av/Eu56OSEYzEUHO40+r2U2WTqS9Mt ouxyzG3p/soHL8LuWTb3tNdkTIqDBga7OhB54o972tAZjK6eER0+wkikYEhKllZxulZe irNQ== X-Forwarded-Encrypted: i=1; AJvYcCXpUiwJTxHL7elQSEIZ++lFpFzAI2gO6mAUva0ebvwHpidZmFMM1z/iAwin85BsGBpIFcy44+rCxaupAMY=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ9oQebD7I8FQXy8TmwAiN29b9FtmMZtrNmdw+lZt4rYz1hKd/ qab7Y5+0lvjKUkHh/YOxqGIu3DnZwmv2OtTl9SCmKW1b7yoIyEUEgK71LA+DIPsD X-Gm-Gg: ATEYQzwpPLwcRQNmCxhT5PNZAjuPbrQ0plsbUWHq1M3UjtDhIOGcAWtokJxu8NqBk9A KJ7vsZfRsn+MlBhl2TqvGuDwuR6x4sz5fQy6mCLunTAgQ/U4RT8Wb6lrAlvr4f8+y+dr3Saj4wK XOkFD3LTIB0xrskMeGa8l8TMySO24F8HcEN6p4T3iK67s8Oe7nt9bqh3ybmpwc8V0KpN/yADhE1 32+FUyr2UV/1HLAfAIdZgXz3f+OOAM9W49zA0NdX4ROXrJq9D9Ct7n/6cGQi9vUa8JwIXlxTCyN N5sVqmDlflFUj8yam9wr2XjPp4fhFwj3Hn7KdKzTPv8DbuU/1yOLvfS+s/zwrlz2gI2jihwVv9Y yUMKlwZIu24ojIal208sGjhi6zFFEjEpbBtfQLoNLxl19ea82w7Ctaa+vyiC4SZCFCWEbTT2BIa DJW87eyLSwuuwKMpaTakLwRc7zB+UmJ0Y= X-Received: by 2002:a17:903:230c:b0:2b0:4d7d:fbc8 with SMTP id d9443c01a7336-2b06e21bceamr77097275ad.0.1773931309274; Thu, 19 Mar 2026 07:41:49 -0700 (PDT) Received: from [192.168.0.106] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e605108sm79415155ad.60.2026.03.19.07.41.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 07:41:48 -0700 (PDT) Message-ID: Date: Thu, 19 Mar 2026 20:11:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: cx25821-alsa: replace BUG_ON() with WARN_ON() To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260314-media-v1-1-fc6235c57d04@gmail.com> Content-Language: en-US From: Atharv Dubey In-Reply-To: <20260314-media-v1-1-fc6235c57d04@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit A Gentle Reminder for reviewing the patch. Thanks, Atharv On 3/14/26 02:02, Atharv Dubey wrote: > media: cx25821-alsa: replace BUG_ON() with WARN_ON() > > Avoid crashing the kernel for a recoverable condition > by replacing BUG_ON() with WARN_ON(). > > Signed-off-by: Atharv Dubey > --- > drivers/media/pci/cx25821/cx25821-alsa.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/pci/cx25821/cx25821-alsa.c b/drivers/media/pci/cx25821/cx25821-alsa.c > index 3f73391f9098..4fdc59aaed8e 100644 > --- a/drivers/media/pci/cx25821/cx25821-alsa.c > +++ b/drivers/media/pci/cx25821/cx25821-alsa.c > @@ -397,7 +397,7 @@ static int dsp_buffer_free(struct cx25821_audio_dev *chip) > { > struct cx25821_riscmem *risc = &chip->buf->risc; > > - BUG_ON(!chip->dma_size); > + WARN_ON(!chip->dma_size); > > dprintk(2, "Freeing buffer\n"); > cx25821_alsa_dma_unmap(chip); > @@ -509,8 +509,8 @@ static int snd_cx25821_hw_params(struct snd_pcm_substream *substream, > chip->num_periods = params_periods(hw_params); > chip->dma_size = chip->period_size * params_periods(hw_params); > > - BUG_ON(!chip->dma_size); > - BUG_ON(chip->num_periods & (chip->num_periods - 1)); > + WARN_ON(!chip->dma_size); > + WARN_ON(chip->num_periods & (chip->num_periods - 1)); > > buf = kzalloc_obj(*buf); > if (NULL == buf) > > --- > base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a > change-id: 20260314-media-52caee1b1f7f > > Best regards,