mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] x86/Kconfig: Fix allyesconfig
Date: Wed, 16 Apr 2025 17:42:10 -0700	[thread overview]
Message-ID: <a589599f-e069-4aaf-aed6-5cc02b322f1f@roeck-us.net> (raw)
In-Reply-To: <20250416170359.a0267b77d3db85ff6d5f8ac0@linux-foundation.org>

On 4/16/25 17:03, Andrew Morton wrote:
> On Wed, 16 Apr 2025 16:05:59 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
> 
>> 64-bit allyesconfig builds fail with
>>
>> x86_64-linux-ld: kernel image bigger than KERNEL_IMAGE_SIZE
>>
>> Bisect points to commit 6f110a5e4f99 ("Disable SLUB_TINY for build
>> testing") as the responsible commit. Reverting that patch does indeed
>> fix the problem. Further analysis shows that disabling SLUB_TINY enables
>> KASAN, and that KASAN is responsible for the image size increase.
>>
>> Solve the build problem by disabling KASAN for test builds.
>>
> 
> Excluding KASAN from COMPILE_TEST builds is regrettable.
> 
> Can we address this some other way?  One way might be to alter or
> disable the KERNEL_IMAGE_SIZE check if COMPILE_TEST?  That will be sad
> for anyone who tries to boot a COMPILE_TEST kernel, but who the heck
> does that?

As mentioned before, increasing KERNEL_IMAGE_SIZE did not help.
However, it turns out that this works:

diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index ccdc45e5b759..647d4f47486d 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -468,8 +468,10 @@ SECTIONS
  /*
   * The ASSERT() sink to . is intentional, for binutils 2.14 compatibility:
   */
+#ifndef CONFIG_COMPILE_TEST
  . = ASSERT((_end - LOAD_OFFSET <= KERNEL_IMAGE_SIZE),
            "kernel image bigger than KERNEL_IMAGE_SIZE");
+#endif

I'll send v3.

Guenter


      parent reply	other threads:[~2025-04-17  0:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16 23:05 Guenter Roeck
2025-04-17  0:03 ` Andrew Morton
2025-04-17  0:17   ` Guenter Roeck
2025-04-17  1:28     ` Andrew Morton
2025-04-17  3:10       ` Guenter Roeck
2025-04-17  0:42   ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a589599f-e069-4aaf-aed6-5cc02b322f1f@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryabinin.a.a@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®