From: Joe Perches <joe@perches.com>
To: Roman Kiryanov <rkir@google.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Todd Kjos <tkjos@google.com>
Subject: Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large
Date: Mon, 13 Aug 2018 21:41:06 -0700 [thread overview]
Message-ID: <a5899fe3c616db608d45303e9ac4563df6546333.camel@perches.com> (raw)
In-Reply-To: <CAOGAQerZ9D2gs+dmv5VKH_0GZQvnGY=juQLQa3qQ-cEm4qn1tQ@mail.gmail.com>
On Mon, 2018-08-13 at 20:47 -0700, Roman Kiryanov wrote:
> Hi,
>
> thank you for reviewing my patches. I decided to put BUILD_BUG_ON
> close to places where it is important that these structs fit into a
> memory page to give some context.
And you make the reader figure out what type dev->buffers is
unnecessarily when sizeof(struct goldfish_pipe_dev_buffers)
is pretty obvious.
> Regards,
> Roman.
cheers, Joe
next prev parent reply other threads:[~2018-08-14 4:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 23:38 [PATCH 1/9] platform: goldfish: pipe: Fix comments to fit 80 columns rkir
2018-08-13 23:38 ` [PATCH 2/9] platform: goldfish: pipe: Update license rkir
2018-08-13 23:38 ` [PATCH 3/9] platform: goldfish: pipe: Fix checkpatch warning rkir
2018-08-13 23:38 ` [PATCH 4/9] platform: goldfish: pipe: Separate the host interface to a separate header rkir
2018-08-13 23:38 ` [PATCH 5/9] platform: goldfish: pipe: Update the comment for GFP_ATOMIC rkir
2018-08-13 23:38 ` [PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large rkir
2018-08-14 1:48 ` Joe Perches
2018-08-14 3:47 ` Roman Kiryanov
2018-08-14 4:41 ` Joe Perches [this message]
2018-08-13 23:38 ` [PATCH 7/9] platform: goldfish: pipe: Replace an array of 1 with a variable rkir
2018-08-13 23:38 ` [PATCH 8/9] platform: goldfish: pipe: Replace pr_ with dev_ for logging rkir
2018-08-14 1:30 ` Joe Perches
2018-08-14 3:16 ` kbuild test robot
2018-08-14 1:35 ` [PATCH 1/9] platform: goldfish: pipe: Fix comments to fit 80 columns Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5899fe3c616db608d45303e9ac4563df6546333.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkir@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®