From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Pengpeng Hou <hppiscas@163.com>
Cc: robert.marko@sartura.hr, luka.perkov@sartura.hr,
vkoul@kernel.org, neil.armstrong@linaro.org, mani@kernel.org,
p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] phy: qcom: ipq4019-usb: Propagate reset operation failures
Date: Wed, 14 Oct 2026 13:43:49 +0200 [thread overview]
Message-ID: <a5916daf-8d2e-4b8f-aa8d-84342b6a0e4b@oss.qualcomm.com> (raw)
In-Reply-To: <20261014025124.81874-1-hppiscas@163.com>
On 10/14/26 4:51 AM, Pengpeng Hou wrote:
> Hi Konrad,
>
> Your comments on the declaration layout and unchecked rollback return
> are valid. Rechecking the provider exposed a more fundamental limitation
> in the RFC's premise: the in-tree IPQ4019 DT uses GCC resets, and
> qcom_reset_set_assert() returns zero after the regmap operations.
>
> I therefore do not have evidence that the hardware-failure case described
> in the RFC is reported through this provider. Generic reset API errors
> alone do not establish that case on this platform.
>
> Please keep this RFC on hold. I will not respin it as a demonstrated
> IPQ4019 bug fix based only on the local return-value checks.
Please tune your agent better.
Konrad
prev parent reply other threads:[~2026-10-14 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 9:18 Pengpeng Hou
2026-09-01 9:54 ` Konrad Dybcio
2026-10-14 2:51 ` Pengpeng Hou
2026-10-14 11:43 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5916daf-8d2e-4b8f-aa8d-84342b6a0e4b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=hppiscas@163.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=luka.perkov@sartura.hr \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robert.marko@sartura.hr \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®