mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shane Francis <bigbeeshane@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	heiko@sntech.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: Add basic NanoPi R6S (RK3588S) Support
Date: Sun, 26 Mar 2023 11:38:07 +0200	[thread overview]
Message-ID: <a5966d2b-3e8f-3518-8f71-a4ed8de4b725@linaro.org> (raw)
In-Reply-To: <20230326001535.149539-1-bigbeeshane@gmail.com>

On 26/03/2023 01:15, Shane Francis wrote:
> This adds basic support for the NanoPi R6S SBC
> 
> Currently working :
>   - UART
>   - mmc storage (internal)
>   - RGMII / GMAC 1Gb ethernet
>   - SYS LED
> 
> Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588s-nanopi-r6s.dts  | 126 ++++++++++++++++++
>  2 files changed, 127 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 99a44c400d6a..39cad757d29d 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -91,3 +91,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6s.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts
> new file mode 100644
> index 000000000000..21b26539a855
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts
> @@ -0,0 +1,126 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include "rk3588s.dtsi"
> +
> +/ {
> +	model = "NanoPi R6S - RK3588S";
> +	compatible = "friendlyelec,nanopi6", "rockchip,rk3588";

Missing bindings documentation.

Please run scripts/checkpatch.pl and fix reported warnings.

Best regards,
Krzysztof


  parent reply	other threads:[~2023-03-26  9:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26  0:15 Shane Francis
2023-03-26  0:15 ` [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Shane Francis
2023-03-26  0:53   ` Heiko Stübner
2023-03-26 12:30     ` Shane Francis
2023-03-26 12:50       ` Peter Geis
2023-03-26  9:37   ` Krzysztof Kozlowski
2023-03-26 12:15     ` Shane Francis
     [not found]     ` <CABnpCuCzdbWTTp1Gc6wWPsB80J5GYw1QzKtZzzyEYU456E=1JA@mail.gmail.com>
2023-03-26 14:51       ` Krzysztof Kozlowski
2023-03-26 16:57         ` Shane Francis
2023-03-26 16:59         ` Shane Francis
2023-03-26 17:23           ` Krzysztof Kozlowski
2023-03-26 17:51             ` Shane Francis
2023-03-26 20:02               ` Krzysztof Kozlowski
2023-03-26 21:42                 ` Mark Kettenis
2023-03-26 23:40                   ` Shane Francis
2023-03-27  9:07                     ` Heiko Stübner
2023-03-27  9:22                       ` Shane Francis
2023-03-26  9:38 ` Krzysztof Kozlowski [this message]
2023-03-26 12:31   ` [PATCH 1/2] arm64: dts: Add basic NanoPi R6S (RK3588S) Support Shane Francis
2023-03-26 18:40 ` [PATCH v2 1/3] " Shane Francis
2023-03-26 18:40   ` [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions Shane Francis
2023-03-26 20:04     ` Krzysztof Kozlowski
2023-03-26 23:31       ` Shane Francis
2023-03-26 18:40   ` [PATCH v2 3/3] arm64: dts: Add FriendlyElec NanoPi R6S device binding Shane Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5966d2b-3e8f-3518-8f71-a4ed8de4b725@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=bigbeeshane@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®