From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65CEC001DB for ; Fri, 4 Aug 2023 10:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbjHDK7n (ORCPT ); Fri, 4 Aug 2023 06:59:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbjHDK7S (ORCPT ); Fri, 4 Aug 2023 06:59:18 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54BE4E70; Fri, 4 Aug 2023 03:57:52 -0700 (PDT) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RHN091dvgz1Z1Sd; Fri, 4 Aug 2023 18:55:05 +0800 (CST) Received: from [10.67.111.176] (10.67.111.176) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 18:57:49 +0800 Message-ID: Date: Fri, 4 Aug 2023 18:57:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] romfs: only select BUFFER_HEAD for the block based path Content-Language: en-US To: Christoph Hellwig , CC: , , Christoph Hellwig References: <20230804102648.78683-1-hch@infradead.org> From: Li Zetao In-Reply-To: <20230804102648.78683-1-hch@infradead.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.176] X-ClientProxiedBy: dggpeml100021.china.huawei.com (7.185.36.148) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On 2023/8/4 18:26, Christoph Hellwig wrote: > selecting BUFFER_HEAD unconditionally does not work as romfs can also > be built with only the MTD backend and thus without CONFIG_BLOCK. > > Fixes: 0f842210d97a ("fs/Kconfig: Fix compile error for romfs") > Signed-off-by: Christoph Hellwig > --- > fs/romfs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/romfs/Kconfig b/fs/romfs/Kconfig > index 3f6b550eee6192..f24a96a331af1b 100644 > --- a/fs/romfs/Kconfig > +++ b/fs/romfs/Kconfig > @@ -2,7 +2,6 @@ > config ROMFS_FS > tristate "ROM file system support" > depends on BLOCK || MTD > - select BUFFER_HEAD > help > This is a very small read-only file system mainly intended for > initial ram disks of installation disks, but it could be used for > @@ -58,6 +57,7 @@ endchoice > config ROMFS_ON_BLOCK > bool > default y if ROMFS_BACKED_BY_BLOCK || ROMFS_BACKED_BY_BOTH > + select BUFFER_HEAD > > config ROMFS_ON_MTD > bool I have tested the patch on my environment and it resolves the two compile errors reported by kernel test robot. The links are as follows: Link1: https://lore.kernel.org/oe-kbuild-all/202308031810.pQzGmR1v-lkp@intel.com/ Link2: https://lore.kernel.org/oe-kbuild-all/202308041329.6SK97Asr-lkp@intel.com/ Tested-by: Li Zetao Thanks, Li Zetao