From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793876628; b=M4DNosorajB40liXNIONqF+CRuYU6cfnpbrM+SKgwIV3/RRK68PdZKNFrlbRi2FVxKAT lFsC9HYP2DYYFzYThpQf2gcjMUfF1v8vSAeg08sb6HQxfWP2WYJ5zxYnhcA+hcxPPZFq4 vlU34DPPI1UxOpknat9KK2svDz+tIw1VzrAo1dHvljvRI4y58tn5iOC8SOHxU5hMNaNP9 X5PTsIQfn5irUeAFDgOzGMV8yRRC48y8fH3PgAz830LinqvX4s6xqhTFgYbRLWoUfv9KC yf/7tO1b2nkG/f9OzDCyONztItJnXKpBLk8Ve3tt0Jj/y83yvwAmP/FQapzZn4hEDAw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793876628; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=Gap8H+IWEcYnPmZ+NpEifKFD4ejmr9XNlelO2dmBy3s=; b=jCrJb1VNNjNY5r3bQ84AM5K6OJHexB5hmC9DL8xYtyMFuAQjXkbpiT0igTZP6nexcU5A 0aXwRBHT4OzY40BwJbHvHrFKJRiAIY/9xH7fGERIYJKBJgbQ6rKyRJe5qegQ0vJysSiw7 cBw4HTKiN29R+Zi0I2/kjtE+Cyg/VbaY8A/Ocs4xgWwCriNPloQd8aKpFm7OybMYqulTo Y0HYS+ytELglSUkabp1ZW+3WCVWW7dIWKPxu1JbzVYTtAwvc2QHkfCzAS4S/N4CnPHv+t gwpC/5HpNqbgF2gXRmRr24Ipxyzv50DSK9RYvCGQCWHY3KbiKoGbFDL2NaDoD0bs36Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZS6D4tKb; arc=none smtp.remote-ip=209.85.221.53 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9308606D802 for ; Thu, 5 Nov 2026 11:03:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D9308606D802 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZS6D4tKb Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-490585eddfcso955668f8f.0 for ; Thu, 05 Nov 2026 03:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1793876626; x=1794481426; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Gap8H+IWEcYnPmZ+NpEifKFD4ejmr9XNlelO2dmBy3s=; b=ZS6D4tKbZiEH2mERnF+Ya/FotzT7AxXe9zZq6uitUC0iNulayZCb5AVtqeul+gaxjm Es6ERyVhbVZEVyshBUWs6W7AqPdzHtb3qURAq//6k1LUnB0f9cJ69onPW2nADa0b/AQ9 RH8/TSuC/cmert5IvEsC3GDqI7Tip4oLqVEOuVpRk2HdPrSnm0nnyWXQbQgrqHY0Vjsj 9yyliiv9jT11HqITClzAJrvZIdAXiqmc5tyIxFoO4RVXA8u9AAH3sS0jouyXvj7eZc6z JozuF292Oup3gUb15/SmhnZX3XHaq/VLHz/DST2va+7cGmRneaiFVG00jMGn0xE6ASPy C6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793876626; x=1794481426; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Gap8H+IWEcYnPmZ+NpEifKFD4ejmr9XNlelO2dmBy3s=; b=lShjf7y2McM6TNIp8ws5Ad2AF6UFVYE1NzVjSvh/lR3iQ0Hejgj/usIy0cgBUUXJik 7N6YRHCwIcmr13BbkGL+4u6w5EE0TCdkv4EIU87RVu2MXR9cfM3al6I1rcC2GIjX5U/R U7vUlkBRN/aXGNJPpvBolOm4lemuLVKhN1JT8YfVC8ybAy8IEaPZDtbuX93FC27pFiv+ VZ92aWKEJfoLmtzfVg1zWx71VrS2d58TC4Bp166SNIJExVMOyZaBWAG7etbywIOEvyZd GcKzFGIJIZ3ZwYuWzxCoCvVR1wGrTd6frmEleZvVta7lfQDSuxu6wjRxJsm51IZOrNr5 SZmg== X-Forwarded-Encrypted: i=1; AKwUvBy1inLk9KNrVYd6Pb/NZI9mSbdR7dj9XlQo8vuTX0JVHh4mhdPlrsCs1CEiQekg6CkOTZxdr9vStPmAqC0=@vger.kernel.org X-Gm-Message-State: APuU4Z+ba7fG+qfwCPrARSsCYmZ0gyLz1i/MuxCn4NpZfOWoYaMybSSw 8byrofNGtPEDH21UmafOuQhFGudnqZjaX/7telcSxgCqzDDbkkadhXQskr5Yn4mYf5c= X-Gm-Gg: AYBFou2lwIRhUp+LB0a50Hh1OmJuWyVRBZC/WEsD3d7nw55Vr1psbFtkwy45zhGlTSl khqjuMM9jw3CqLwdAd5etAqvKbN+lb0CsEBhWsZMyDRIrtL9beqemY3FdT+qrp5fAWhTErO2fAO rcy8rMGlQk1J/S3T/6qG1Y0mUAOLJ/4dDSzjypLYaTr9bKLRED38N75y/+tofdIFr9Bi9/PVQcm tYmImppjzWEvxFW7cbv0pgyYEeyPGwSdnkTyqVeNzRIOEbya9c6ubp+2CEf/UtGULShkukuAwlA m+khOWbxtC1bC6i2FgBaFIol1mOw+KQ4ph+qcqPk0IzXYk2Ne00cHonedyyaUA5XW7XlE29ratK TCEHabd0AHQWVtQI5awgJ+uQ/mE0FHrc1I8a8zS92jMsey8QyR47z82YNSY+ZIYQW0RO5qWz1AP RL/INj/TR2i4Raf2OToSVUqycuy74d7G9kix6W9qB9Ck3RrRKlEHfVvOvVAs5qYLEaE4muyrpWB vZSTOsdF6GQ3TbXteUj7WPgjm4ahEmhFu9er25xrs4lDoLozpNyabOKYuxMgeKJbtGJBg5ZV5TW LGF6yWwTEEGsq/6+A6FEERPbbJtCbzV2xqGQnbiC X-Received: by 2002:a05:6000:4202:b0:48f:bcdf:6f83 with SMTP id ffacd0b85a97d-48fbcdf713emr12222197f8f.22.1793876626103; Thu, 05 Nov 2026 03:03:46 -0800 (PST) Received: from [192.168.0.167] ([51.37.126.136]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48fece99a5dsm9321835f8f.21.2026.11.05.03.03.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2026 03:03:45 -0800 (PST) Message-ID: Date: Thu, 5 Nov 2026 11:03:43 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports To: Krzysztof Kozlowski , Loic Poulain Cc: Nihal Kumar Gupta , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Vankadara , Vikram Sharma References: <20261102-glymur_camss-v1-0-fcb619fc7319@oss.qualcomm.com> <20261102-glymur_camss-v1-1-fcb619fc7319@oss.qualcomm.com> <20261104-real-nebulous-ostrich-017e92@quoll> <72064a9a-1b2e-4c24-99e2-2cc15a8dd7f1@oss.qualcomm.com> <539842db-c672-4549-b861-4a6f3be47556@oss.qualcomm.com> <1db9bf48-01d8-44fe-8dd2-7a3c84ecc556@kernel.org> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <1db9bf48-01d8-44fe-8dd2-7a3c84ecc556@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/11/2026 10:45, Krzysztof Kozlowski wrote: > On 05/11/2026 10:53, Loic Poulain wrote: >> So some chipsets share the same IP blocks, with some block/phy >> instances disabled. As a result, we need to decide whether we're >> numbering based on active instances or on the actual hardware instance >> index/offset. If we use active-instance numbering, then yes, it should >> be @2 (CSIPHY4 being the third active instance). Alternatively, if the >> port numbering is intended to reflect the hardware instance offset, >> matching the register prop, then @4 would be more appropriate. It also >> has the advantage of directly identifying the underlying hardware >> instance, without requiring any additional driver-side mapping. In any >> case, @3 is incorrect. >> >> That said, since the bindings have already been merged in its current >> form, we'll need to preserve backward compatibility when addressing >> this. > > This is the input port to camss, so how is it called in camss, not the > csi phy? > > > Best regards, > Krzysztof When you have legacy PHYs the port number indicates the PHY - this has been the case since 2015. With standalone PHYs the port number just means "input data port here" with no specific hardware mapping Which to me implies the correct port numbering for systems which have a standalone PHY is {0, 1, 2} On hamoa which supports both legacy and new we have to stick to the old way of {0, 1, 2, 4} Since any PHY can mux to any CSI decoder the old port scheme should IMO be dropped for new standalone PHY DTs. Not sure what to do about Glymur since the example is upstream already. --- bod