mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Kalle Valo <kvalo@kernel.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] wifi: ath10k: correctly document enum wmi_tlv_tx_pause_id
Date: Thu, 18 Jan 2024 09:17:02 -0800	[thread overview]
Message-ID: <a59d0fd8-1351-4fc0-a177-1c96cbff4675@infradead.org> (raw)
In-Reply-To: <20240118-ath10k-kerneldoc-v1-2-99c7e8d95aad@quicinc.com>



On 1/18/24 08:12, Jeff Johnson wrote:
> Currently kernel-doc reports the issue:
> drivers/net/wireless/ath/ath10k/wmi-tlv.h:2363: warning: cannot understand function prototype: 'enum wmi_tlv_tx_pause_id '
> 
> Update the enum wmi_tlv_tx_pause_id documentation to fix this issue.
> 
> No functional changes, compile tested only.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/net/wireless/ath/ath10k/wmi-tlv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
> index 83a8f07a687f..8a2f87d0a3a3 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
> +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
> @@ -3,7 +3,7 @@
>   * Copyright (c) 2005-2011 Atheros Communications Inc.
>   * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
>   * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
> - * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> + * Copyright (c) 2022, 2024 Qualcomm Innovation Center, Inc. All rights reserved.
>   */
>  #ifndef _WMI_TLV_H
>  #define _WMI_TLV_H
> @@ -2343,7 +2343,7 @@ struct wmi_tlv_adaptive_qcs {
>  } __packed;
>  
>  /**
> - * wmi_tlv_tx_pause_id - firmware tx queue pause reason types
> + * enum wmi_tlv_tx_pause_id - firmware tx queue pause reason types
>   *
>   * @WMI_TLV_TX_PAUSE_ID_MCC: used for by multi-channel firmware scheduler.
>   *		Only vdev_map is valid.
> 

-- 
#Randy

  reply	other threads:[~2024-01-18 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 16:12 [PATCH 0/5] wifi: ath10k: fix ath10k kerneldoc issues Jeff Johnson
2024-01-18 16:12 ` [PATCH 1/5] wifi: ath10k: add missing wmi_10_4_feature_mask documentation Jeff Johnson
2024-01-19 17:43   ` Kalle Valo
2024-01-18 16:12 ` [PATCH 2/5] wifi: ath10k: correctly document enum wmi_tlv_tx_pause_id Jeff Johnson
2024-01-18 17:17   ` Randy Dunlap [this message]
2024-01-18 16:12 ` [PATCH 3/5] wifi: ath10k: fix htt_q_state_conf & htt_q_state kernel-doc Jeff Johnson
2024-01-18 17:18   ` Randy Dunlap
2024-01-18 16:12 ` [PATCH 4/5] wifi: ath10k: Fix htt_data_tx_completion kernel-doc warning Jeff Johnson
2024-01-18 17:19   ` Randy Dunlap
2024-01-18 16:12 ` [PATCH 5/5] wifi: ath10k: Fix enum ath10k_fw_crash_dump_type kernel-doc Jeff Johnson
2024-01-18 17:20   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a59d0fd8-1351-4fc0-a177-1c96cbff4675@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®