From: Markus Elfring <Markus.Elfring@web.de>
To: Li Qiang <liqiang01@kylinos.cn>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev,
Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: brcmfmac: Add null pointer check to brcmf_acpi_probe
Date: Wed, 15 Oct 2025 13:24:58 +0200 [thread overview]
Message-ID: <a5a7515e-a35c-46dd-8522-0daa41e23b1d@web.de> (raw)
In-Reply-To: <20251015071607.96415-1-liqiang01@kylinos.cn>
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
Will another imperative wording approach become more helpful for an improved
change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94
Can a summary phrase like “Prevent null pointer dereference in brcmf_acpi_probe()”
be nicer?
Regards,
Markus
next prev parent reply other threads:[~2025-10-15 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 7:16 Li Qiang
2025-10-15 11:24 ` Markus Elfring [this message]
2025-10-30 13:27 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5a7515e-a35c-46dd-8522-0daa41e23b1d@web.de \
--to=markus.elfring@web.de \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=liqiang01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®