From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbdBUK6U (ORCPT ); Tue, 21 Feb 2017 05:58:20 -0500 Received: from mail1.bemta8.messagelabs.com ([216.82.243.197]:21692 "EHLO mail1.bemta8.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbdBUK6M (ORCPT ); Tue, 21 Feb 2017 05:58:12 -0500 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRWlGSWpSXmKPExsVy+LrFKl0r2TU RBn+fqFoceLGQxeLIhbXMFve+n2e2mLhyMrPF+fMb2C02Pb7GanF51xw2i91Ny9gtju65x2zR efwkq8XknW8YLf5u38RisfnObDaL2782sDjweSz4tZXFY/Hp64weTzZdZPTYOesuu8fmFVoem 1Z1snlsXlLvcXNeocfm1y+YPfr/Gnh83iQXwB3FmpmXlF+RwJqx+MUE9oLLXBU3Dv5mbGB8zt HFyMUhJLCMUeLMkRcsXYycHGwCJhI3758Dsjk4hAUiJO4/4AapERGYzyTx8/MWdhCHWWA2k8S P5uMsEN0zGCXurT/HBNLNK+AscerkDVaQbhYBVYlHXewgYVGBBImLf6awQpQISpyc+QRsGadA kMTUE4eZQWxmAX2Jpq1zoGx5ie1vIWwhAW2J9xsXg/VKCChITJ3cyjyBkX8WklGzkLTPQtK+g JF5FaN6cWpRWWqRrrleUlFmekZJbmJmjq6hgYVebmpxcWJ6ak5iUrFecn7uJkZgjDEAwQ7GE5 OdDzFKcjApifJmS62JEOJLyk+pzEgszogvKs1JLT7EKMPBoSTByykDlBMsSk1PrUjLzAFGO0x agoNHSYRXGSTNW1yQmFucmQ6ROsWoKCXOe1AaKCEAksgozYNrgyWYS4yyUsK8jECHCPEUpBbl Zpagyr9iFOdgVBLm1QYZz5OZVwI3/RXQYiagxTc9VoIsLklESEk1MPKE/UmWVPgtG9whoep02 /cH59ULi8r/by7+MtFx0dWZ/zYnKgs8m+Sp4ZqcZPzf02mZRneCp6JTRoVcYR6n6g/Hhzu1pi m1G7M3fwlY9WTO5IamcL2FL/Q8dzdmMwcXC/f9Yp98riae4fzNROVZ9vvPf1/+UkQkYuOzG5a zzO1i3xfdvSj6XomlOCPRUIu5qDgRABY6NIsrAwAA X-Env-Sender: Marc_Gonzalez@sigmadesigns.com X-Msg-Ref: server-4.tower-94.messagelabs.com!1487674681!6595298!1 X-Originating-IP: [195.215.56.170] X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked From: Marc Gonzalez Subject: Re: [RESEND PATCH 1/3] mtd: nand: Pass the CS line to ->setup_data_interface() To: Boris Brezillon , Richard Weinberger , , Sascha Hauer , Sergio Prado , "Wenyou Yang" , Josh Wu CC: David Woodhouse , Brian Norris , Marek Vasut , "Cyrille Pitchen" , Krzysztof Kozlowski , , References: <1487625149-7234-1-git-send-email-boris.brezillon@free-electrons.com> <1487625149-7234-2-git-send-email-boris.brezillon@free-electrons.com> Message-ID: Date: Tue, 21 Feb 2017 11:57:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48 MIME-Version: 1.0 In-Reply-To: <1487625149-7234-2-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.27.0.114] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/02/2017 22:12, Boris Brezillon wrote: > Some NAND controllers can assign different NAND timings to different > CS lines. Pass the CS line information to ->setup_data_interface() so > that the NAND controller driver knows which CS line is concerned by > the setup_data_interface() request. I'm confused, because I thought I was already doing that. On my platform, I have different timings for each chip. (thus, for each CS, right?) In chip->select_chip, I program the appropriate timings which the controller will be using. What am I missing? > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index c8894f31392e..d62a1c7c5c5c 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -1100,8 +1102,10 @@ static int nand_init_data_interface(struct nand_chip *chip) > if (ret) > continue; > > - ret = chip->setup_data_interface(mtd, chip->data_interface, > - true); > + /* Pass -1 to only */ "Pass -1 to only" what? I suppose -1 means NAND_DATA_IFACE_CHECK_ONLY since #define NAND_DATA_IFACE_CHECK_ONLY -1 Maybe you meant "Pass -1 to check only" here? The comment may need a slight rework. > + ret = chip->setup_data_interface(mtd, > + NAND_DATA_IFACE_CHECK_ONLY, > + chip->data_interface); > if (!ret) { > chip->onfi_timing_mode_default = mode; > break;