From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798D414F9FB for ; Wed, 24 Dec 2025 16:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766592042; cv=none; b=EgyeSGhkJsRwvMVDRXbaoxv82sVW3egS1PbaS+BBde/4h0rrVipRtFgU0WWbU6iqWeke8yf/6r0lBCWs+V00oVToiai9ekH4NnZmtTRzG9WS8VXXdsh0G+yCS8k+PhlT0XQnRx+zmA2zCoBn5UKU29ewlbOGg6OUsIcl3jZj4MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766592042; c=relaxed/simple; bh=d+6F9uVSbKemtD8VxhaHQoGcfJHj9u770sLjCeMYWUQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RNWzfJil+gJX9iHG+S9NUfTQQlgAR+QgEfkWLpnIxrwb7SBYqKcgWpQ8D4U+CQ46JedYC8JK8NgPxDZOftRNeAhCuhIVoMUFP4PcGnzk8iz3L32zBDdJj7BcGr74IU6zg06cSdp1XK1x+zYHxCRdOQl1lPa2xW3617GdifvLek0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca; spf=pass smtp.mailfrom=ndufresne.ca; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b=bX82JNCr; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b="bX82JNCr" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8b2627269d5so652586285a.2 for ; Wed, 24 Dec 2025 08:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1766592039; x=1767196839; darn=vger.kernel.org; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=B8GfNqjtHl5a4gr/qUWpYa+PaGpekfTXC3faii3jufs=; b=bX82JNCrSbzoIcw3T99VQe5Mz865DRffOixPkdkP6vAKiYVfzclNoTZALUAP2VL0lv AkHxsfxEyxXoqGeVu0lwGgl4C+CErn9ZWBw78sZ+61TNgdDBqTVA+EKdsHnzJqxlNIrW 0a8tKAflV8Uzx4SVvGYSyD6JHwbUkoX+5q2ZfppS3xfdTP3xWEPWyouhc0BHFTie3oaJ c0yO/dT3pa0HMakjGavnFB1ZHiadtLOMvf7PahoFqiSX4/rEyAA2pJa9LmKtw7BIKJ/F DB/dUj5J1LgFcpzwLJ2Sdh1mkfxKxx3rsAOOjIbVrD6QGxH+Q79eNDuNh4ylsoWh2YYc 5SAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592039; x=1767196839; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B8GfNqjtHl5a4gr/qUWpYa+PaGpekfTXC3faii3jufs=; b=pBjC7d1VihoH2ukWUbgZwuvl1Vv+1ONG62Kf6U5HYUWs0RHzY6pTPfRjcaaS7gKLEl 2pjPwPIo5e18qUkGpzIw3rLfgVwQwPr0P4vZtM5bYWhCcZWE54kDgE2QUHTvjG4IKeVZ asQvVBWfb8cnYDjHMgXksBLnMMTpLTkOC8LRtYj8HwdGZ+wAvtr5ihNsYumevVTO/nS6 PPq8DivX5prOp1l9/fqrTCLCPfiW++9CL9Hqm0t1mt4uk5DUlwOhEuyDWsuK/WTB0F/h x7mVJ3WLJSO9ERQ+LwThD8SRMNeuiyVz8DxdD42XMrS7QAh0dch4/X6207MgavM+bHZj ocVw== X-Forwarded-Encrypted: i=1; AJvYcCWn2MbRWh5mUIthBG/xs9RrhAwD78upU7RdqDIGotKlKJfnBaT/r2F2+qOe/goyu5Wh6uDsLwqxnLDqL2c=@vger.kernel.org X-Gm-Message-State: AOJu0YwTpnCVACyuEkE4XrhPxOZp3joyJwudJRD+tDfs+wHqXI2XCrf0 XGL6Tv7UJXjYoPWAVMIW+JWN+3SokR5kPbGghJz2f4dKxxBDBWbKD95YGDR5ZEU3uC0= X-Gm-Gg: AY/fxX6kmjAV6NLteLeDzAIKRkLlGykPAXhPPHPrTr5/Jp/TIlYGELSYJaMSKBOolNh 1TcY8YXVNB0p4BI3WNz2a9ibm/0Wt8KqRk5CaRW6mPjzdu9IgOK074fYOirpZpwBEopJjHyCX9H LDS0LtMPbTCSH3R2o412Gkn6n+JHF37/m7LObXpE+nC7AeBSvZOE2asbV+lx4DxGwW9NYxv84sr l4/YxPU+nVbN3VPpKUqf1iBZ9Yqs42FVxCENaaXO1WOEBw+8FB93PYv7B0AKZdres6cg8LtU16z WRuKj+4psy2v66Cedu4KFMqEUS6X1BRWz4guUtcvM+qMV8sSTvIJXe/xDNzaO60BMrwaXHUlfHJ xVnY5GQe40BHUezLlLASJjD+JHQKKh5/APzCmP8y1y9Ta7/bueILA5vaN935tO5z11X2hQzug68 1vUPr/xiZlmlwiiYXB X-Google-Smtp-Source: AGHT+IFIZF2H0HnNmQiOGLnklkzBl2kWriBVm1AimimcWBGx+3cCd1NWu6NStzB4+jVjvScDMa6lZg== X-Received: by 2002:a05:622a:4813:b0:4f3:5652:6743 with SMTP id d75a77b69052e-4f4abd79a87mr277964811cf.39.1766592039264; Wed, 24 Dec 2025 08:00:39 -0800 (PST) Received: from ?IPv6:2606:6d00:17:7b4b::c41? ([2606:6d00:17:7b4b::c41]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d9a544ba9sm128813236d6.50.2025.12.24.08.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 08:00:38 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 19/22] media: rockchip: rga: add feature flags From: Nicolas Dufresne To: Sven =?ISO-8859-1?Q?P=FCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de Date: Wed, 24 Dec 2025 11:00:37 -0500 In-Reply-To: <20251203-spu-rga3-v2-19-989a67947f71@pengutronix.de> References: <20251203-spu-rga3-v2-0-989a67947f71@pengutronix.de> <20251203-spu-rga3-v2-19-989a67947f71@pengutronix.de> Autocrypt: addr=nicolas@ndufresne.ca; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ZZ4kMHEmgfVAsTpDFN2e" User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-ZZ4kMHEmgfVAsTpDFN2e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mercredi 03 d=C3=A9cembre 2025 =C3=A0 16:52 +0100, Sven P=C3=BCschel a = =C3=A9crit=C2=A0: > In preparation to the RGA3 addition add feature flags, which can limit > the exposed feature set of the video device, like rotating or selection > support. This is necessary as the RGA3 doesn't initially implement the > full feature set currently exposed by the driver. >=20 > Signed-off-by: Sven P=C3=BCschel Reviewed-by: Nicolas Dufresne > --- > =C2=A0drivers/media/platform/rockchip/rga/rga-hw.c |=C2=A0 4 ++++ > =C2=A0drivers/media/platform/rockchip/rga/rga.c=C2=A0=C2=A0=C2=A0 | 23 ++= +++++++++++++-------- > =C2=A0drivers/media/platform/rockchip/rga/rga.h=C2=A0=C2=A0=C2=A0 |=C2=A0= 7 +++++++ > =C2=A03 files changed, 26 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c > b/drivers/media/platform/rockchip/rga/rga-hw.c > index a868a34a1452e..0d1cf911af0d5 100644 > --- a/drivers/media/platform/rockchip/rga/rga-hw.c > +++ b/drivers/media/platform/rockchip/rga/rga-hw.c > @@ -658,6 +658,10 @@ const struct rga_hw rga2_hw =3D { > =C2=A0 .max_height =3D MAX_HEIGHT, > =C2=A0 .max_scaling_factor =3D MAX_SCALING_FACTOR, > =C2=A0 .stride_alignment =3D 4, > + .features =3D RGA_FEATURE_FLIP > + =C2=A0 | RGA_FEATURE_ROTATE > + =C2=A0 | RGA_FEATURE_BG_COLOR > + =C2=A0 | RGA_FEATURE_SELECTION, > =C2=A0 > =C2=A0 .setup_cmdbuf =3D rga_hw_setup_cmdbuf, > =C2=A0 .start =3D rga_hw_start, > diff --git a/drivers/media/platform/rockchip/rga/rga.c > b/drivers/media/platform/rockchip/rga/rga.c > index c991cc64b4b7f..3958e71b8987d 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -162,17 +162,21 @@ static int rga_setup_ctrls(struct rga_ctx *ctx) > =C2=A0 > =C2=A0 v4l2_ctrl_handler_init(&ctx->ctrl_handler, 4); > =C2=A0 > - v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > - =C2=A0 V4L2_CID_HFLIP, 0, 1, 1, 0); > + if (rga->hw->features & RGA_FEATURE_FLIP) { > + v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > + =C2=A0 V4L2_CID_HFLIP, 0, 1, 1, 0); > =C2=A0 > - v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > - =C2=A0 V4L2_CID_VFLIP, 0, 1, 1, 0); > + v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > + =C2=A0 V4L2_CID_VFLIP, 0, 1, 1, 0); > + } > =C2=A0 > - v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > - =C2=A0 V4L2_CID_ROTATE, 0, 270, 90, 0); > + if (rga->hw->features & RGA_FEATURE_ROTATE) > + v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > + =C2=A0 V4L2_CID_ROTATE, 0, 270, 90, 0); > =C2=A0 > - v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > - =C2=A0 V4L2_CID_BG_COLOR, 0, 0xffffffff, 1, 0); > + if (rga->hw->features & RGA_FEATURE_BG_COLOR) > + v4l2_ctrl_new_std(&ctx->ctrl_handler, &rga_ctrl_ops, > + =C2=A0 V4L2_CID_BG_COLOR, 0, 0xffffffff, 1, 0); > =C2=A0 > =C2=A0 if (ctx->ctrl_handler.error) { > =C2=A0 int err =3D ctx->ctrl_handler.error; > @@ -489,6 +493,9 @@ static int vidioc_s_selection(struct file *file, void > *priv, > =C2=A0 struct rga_frame *f; > =C2=A0 int ret =3D 0; > =C2=A0 > + if (!(rga->hw->features & RGA_FEATURE_SELECTION)) > + return -EINVAL; > + > =C2=A0 f =3D rga_get_frame(ctx, s->type); > =C2=A0 if (IS_ERR(f)) > =C2=A0 return PTR_ERR(f); > diff --git a/drivers/media/platform/rockchip/rga/rga.h > b/drivers/media/platform/rockchip/rga/rga.h > index 980f70f842317..b9c75b5fda4dc 100644 > --- a/drivers/media/platform/rockchip/rga/rga.h > +++ b/drivers/media/platform/rockchip/rga/rga.h > @@ -6,6 +6,7 @@ > =C2=A0#ifndef __RGA_H__ > =C2=A0#define __RGA_H__ > =C2=A0 > +#include > =C2=A0#include > =C2=A0#include > =C2=A0#include > @@ -132,6 +133,11 @@ static inline void rga_mod(struct rockchip_rga *rga,= u32 > reg, u32 val, u32 mask) > =C2=A0 rga_write(rga, reg, temp); > =C2=A0}; > =C2=A0 > +#define RGA_FEATURE_FLIP BIT(0) > +#define RGA_FEATURE_ROTATE BIT(1) > +#define RGA_FEATURE_BG_COLOR BIT(2) > +#define RGA_FEATURE_SELECTION BIT(3) > + > =C2=A0struct rga_hw { > =C2=A0 const char *card_type; > =C2=A0 bool has_internal_iommu; > @@ -140,6 +146,7 @@ struct rga_hw { > =C2=A0 u32 max_width, max_height; > =C2=A0 u8 max_scaling_factor; > =C2=A0 u8 stride_alignment; > + u8 features; > =C2=A0 > =C2=A0 void (*setup_cmdbuf)(struct rga_ctx *ctx); > =C2=A0 void (*start)(struct rockchip_rga *rga, --=-ZZ4kMHEmgfVAsTpDFN2e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaUwOJQAKCRDZQZRRKWBy 9BMlAP9wheqN0kV9AGOEcLeIGF3jdIvsKyUQd/a18l7/P2R5GgEA2QE1kyL14SMl UIwibdNY/yvhzXGSYKqEEEF8yKlUfwo= =K5xI -----END PGP SIGNATURE----- --=-ZZ4kMHEmgfVAsTpDFN2e--