From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbdJLOSm (ORCPT ); Thu, 12 Oct 2017 10:18:42 -0400 Received: from mail-bn3nam01on0051.outbound.protection.outlook.com ([104.47.33.51]:22720 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751924AbdJLOSj (ORCPT ); Thu, 12 Oct 2017 10:18:39 -0400 Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v5.2 12.1/31] crypto: ccp: Define SEV userspace ioctl and command id To: Borislav Petkov References: <20171007010607.78088-2-brijesh.singh@amd.com> <20171011164605.115592-1-brijesh.singh@amd.com> <20171012132752.6qgkjyxuofwhvcto@pd.tnic> From: Brijesh Singh Message-ID: Date: Thu, 12 Oct 2017 09:18:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171012132752.6qgkjyxuofwhvcto@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR1701CA0018.namprd17.prod.outlook.com (10.172.58.28) To SN1PR12MB0160.namprd12.prod.outlook.com (10.162.3.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c117876-061d-4bcc-58a6-08d5117c20f4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:SN1PR12MB0160; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;3:oJNz/knRJdMCdPvQP7ltwiXVI5eRRncTURi1aERP/+gmZDtPNqOnVoRqzG2YiA/TX+PJCyPUdHX12CoxnyLF8xhEqFsASyS1rCBtwloU1fkfNFWZn63tR1GABsk41uewHVBOZEHomUiL+Y86OH6SX15usxD8Ge9S5wA9Cf5l1vybNA9BYjhdsVHXFl7n/ELeMyaQKMrjVO16OBQ5Un+I71x0UtD4f/Bq8qcfb3EnBdOIQaya1OUb4OguvP7Huzdb;25:gt8EPJUApMYXc4labHxceidzZ4sFmTLBvN7mOKrwpcKTUxmhAA46b6oqOT693o+l29Dz0qvoWXYl9uraPSaDBxsrn0ELgsUwcmm6fzxyBmOj0a1GOYGXgM+GZi+nGeFeb54D+6EmAyoWUGNomwa6oGLUQDOcYcF41+ugdwl3x+ZE3z6sA58JIU5Hda1rIY0+5vVnuo/zL20GDv5BfjzFCTTTVoOUyM+daqQ1ATZtgLblvdLo7Btq272Y7QdltLQ8ve5XaVQJ42IROQfeh6NlxRFFVjnJZGPWgWtwixfINkPXpdLVyCNg4fscug2IWxdptkIg9ishoXaXkKJx0k5C9A==;31:Lg//49d/L413+iDlc4cBBxWrmt1adeW13zjUGCUJIhfaLDCH14DPjuanhFXZxG2PhSBfDZLlo+ywOSwUCkPzd6a7UCPmIIDOLpGHdLkdA4JS6Yb4sFzSorJZFC4/p9LmHJrcqIaNdAavmhBbT7KkrR4zjhaijD/6/NUBXeh52aXvct0eZwXFTmpnz2qZhdbxq3VvFI/m8PgdVGzVkInLGHKM8xl7L/ea5nqCm5F5C4I= X-MS-TrafficTypeDiagnostic: SN1PR12MB0160: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;20:9eSQTzyu3E/mmV/RVB82f/VweLSnttepKse4YvKCwaM6cBxyuLbWmIOxZsRqKIuD61/OLspTLBQ2VnjtnBD9u46ES/VyXqZ+mYPnB4yHNaI7eIQOsf0kEQQeRu1PpQih58i2Y9jwpAUOmNZYxBR8Otegw4buopDr2+y/DHnvbkjqpoHVQliQ2TD0UY9FcBUBuys3SrBaSn72ToZozS2WZprkbQ8+NZ529AEfE14vkMIXoe0lQlA9oBSddhth2Cta46mYGE1v+jJV+x3nJQi0XXx3NVOryEnRD8PWIDdUwcTEVro6FRAZMFOikwGYfncQWeuBaEmVnG2sDs+g2Ok8IKAMGQUNJJSiRvnQot6jZruvu5I+B3ARBIftWp+hb8R9H89pyVSlNlpneGFJcXkJCkLGfPWIrV2VrmimU0NDqAyJ0bAqdQH5JucdygGtTRJuLng36/PrNwGpFDdjFiD6nmilkeBMm3cs0INhnBxpWg1DU3nJWVOHiCJo8xkHK+de;4:vZiA7tJ2oQwvHM08FGf4a9E6lrhquke82mG9Q+m/sZafY/2u0knzbu2VZVhcEXt6b5iB7zukMaiAmQIFIEQgkKl6/241Xx0NEkOVVF20Clnff4Nsn/wJvADg0E7h4AUglhNo31szcWJJox18OGSAYJFVmAJd8iCMGYm3fqRyrzmxFW70QSjMGFGXEyVHQx9bpHp+sMphK0GGIYMb2PLZmWj1rntKwgnTreQv8YEwTg73Byt0/CR4FNIYqyva0/gN X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0160;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0160; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(6049001)(39860400002)(346002)(376002)(189002)(5423002)(377454003)(199003)(24454002)(6486002)(106356001)(36756003)(77096006)(90366009)(105586002)(189998001)(4326008)(33646002)(5660300001)(65826007)(31686004)(101416001)(6916009)(2950100002)(6246003)(68736007)(6666003)(229853002)(53936002)(50986999)(76176999)(54356999)(478600001)(54906003)(58126008)(16526018)(83506001)(305945005)(7736002)(25786009)(97736004)(16576012)(316002)(53546010)(86362001)(2906002)(8936002)(31696002)(47776003)(3846002)(50466002)(6116002)(230700001)(81156014)(64126003)(65956001)(23676002)(66066001)(65806001)(8676002)(81166006)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0160;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTYwOzIzOitKV3htV1R1SjRSMzAzdlkxalpBeFF1NDhC?= =?utf-8?B?L3JZTEhiME5sR044WXJUazE0RHNTMVV3TFdCT3NtQnZuSGx5WlAzTkp0NU5B?= =?utf-8?B?Yy9haEdvb2FYd1ZROUxPUzlQZW1CbTE5S0tMS3hPYWI3S0xBYjNPbUFqN0d1?= =?utf-8?B?L1FYUFUrTmdTcnBEWDJEck1Ga1E3Vmx3TFRSakkzU1ExQWlCS1owekRkbEpL?= =?utf-8?B?enMveW44UytTOTcyaFJ0M1dBOHVVTitGcnlqUENCendxL2srSXIrbU9XcWFF?= =?utf-8?B?WGwvYTVkSVN0WHNyV3BzWjJWUmZzNFdTNXp4cnJvZnBjRWRaS1BZYzVTaThp?= =?utf-8?B?dlpHOTVqRHd1Z2t6eWhCRFhza21pZlVtTkszcHAvajJSaEJCNjl0a1R4MTRq?= =?utf-8?B?K1NSUXJKRXA5OGlGTmx4ZkU3T25HcXpHY1lGYUI1ZTlnSnkvV2pqTnZscGR6?= =?utf-8?B?bWFxWi9zMzlITG5ZMllyaUxtNEdrZDlzNzJSUlc1Z2ovN0FhdXBxWjAvbmZT?= =?utf-8?B?UXFKellNT3BrU0YwN295LzZLY2JieTZJV25sMW5RVU9pcDFHY3k3algvcjlM?= =?utf-8?B?c3BrU2x3V0lVcmtORlREOXFNYWR5TW81N21UdzZVQ2RjOHNrZTJpS2txT0Vp?= =?utf-8?B?dVpWOFptQ1RwRWxqa1Byd0xmWFpGcVFhbnVIZ0VMUVFBR09xS2FhVkVjWlI2?= =?utf-8?B?ajRZVERYcFVZL2kyQlpZcHlZQThLMnk1UDhWd1FleWt0MG1HanBIY1l5emRa?= =?utf-8?B?QkNPODZiZnVvZ3I5WlpNcDgwVDl3MzNPREtKa0Q2MFNzZzhObFhVRk1VWGo3?= =?utf-8?B?Q0VSc1h2TmN2SERaUldJdGRwUVYwdkIrRDRwU1VsYnNXaEZrR3p3cEx3bnl1?= =?utf-8?B?bTdldytwMmJGM2QxMHRTUXpqam44STUwYVBlaGk4L2g3VGR6M29nRFBhLytk?= =?utf-8?B?MUxoaFluVi8zdFcxdHQ4eU1XTkNDdHVPUHBLNWltb3lhN2RmL3VWV2daSkxO?= =?utf-8?B?V3pjdTdWYlJkTWo3ZHh2Yys5ZmZZQzFmYlg0S0hBaVo4ak9RamhyQjI3am0y?= =?utf-8?B?WXlQK2VXcHFLVS9vT1c2S0NnZUN4c3N0ZjgwTFh6cklraDVGbEhtMlBObjFR?= =?utf-8?B?L2k5ai9acGwzcWJ3bDZPRmhBSnZUd3J4ZDVMYVpsMFcveTdUVGF4MWZaZGdq?= =?utf-8?B?RHRESzRPYWpRN0lNNXl4dVlpL1YvVEdTQXlrN25vNFZzWmRTYTNyWks5aUNF?= =?utf-8?B?N29VWG9lclFhQnpDN3hHeVRadFFGcFZBdnhsejExRzkvY1NVWnFHQ0Fqb2RB?= =?utf-8?B?UXZmU0lLV2pEMGEvRHpGNHFYVVpUSXlURjh6bnhiV2JSWGhjRE8xQytGWS9a?= =?utf-8?B?RWg2QWdTeHY4bTBMWTc4bldnVjh3TWhzVWVMREp4a1lzZk1xZU5vNzN0d2h4?= =?utf-8?B?eWVjajBYaUpmYXFOM0FqcWNzTlhHSkhTRGJJcTVRQ0haT0VxWTBMVFFaNW8z?= =?utf-8?B?R2RyOUxFcFFuWVJzSnMyODR1QXVCWXljbTJ1aTQ0WkM3NFZQNkwxRlEzZVRx?= =?utf-8?B?anJkOWtLNVNKNHhwZ2xkUXdlWXdzS1h4YllvOE14V2ZXTHlzMkgwckk1SGVX?= =?utf-8?B?RHlRcjVqKzdaeURmUmhaMG15L0xjS3JDSFJ4TnVlVkF5a2JOcndHZDZjVTdK?= =?utf-8?B?QlNLdTRNWkVIcm9UZnNXYmNrZE5BYUJJREx2NzFjZVY0dVBud01NeHB6TGND?= =?utf-8?B?ZVAwbXpYNzRFaDRTNXliWFVhT1EyV3JNUm5BVDVSdnpPYk81a2dIWjJSUVN2?= =?utf-8?B?aEdSMGV3dzQ0ejZBSWQ3eDRZVW5oaWpkR3pYUUVieVZKQmVCSnNVVTE5WUxi?= =?utf-8?B?MFRLR3M5TVVwWHBGVld5THlSNDJaRTJQZG1haTBEUGJHOXEzSFlXZHgweWNH?= =?utf-8?B?d3lXcElaczg3UktnUjV2TG9Vc2Z1QzJIa2VWcERSb3NOWG8ybGYxRUFDWVU3?= =?utf-8?B?cjhhM21uSXdCUkt0b0dHcVZ5VGRjTlh5R09ENC9nWGZCcmxZYi9IRTJNeEhC?= =?utf-8?Q?xaaOczk0GxCH6KwD/PfuUxkM1?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;6:d1vmtJ/EpN2ZHoggb982lnaZ8j67QTmW7VYK8YWX7i1q2U8x56dCsAGaKip0en6MnTWbFc1dFtEofujEAYnWMo4HybBGsf37mqDPr6BYciwW+lotgiIxk+usaaMMHJU7O7tBe3oP7+xudMOEqAVOx59B67Fo52njjsz/5rA3aeEKG+3w5kRkvei8hDCs0jDIOeixQoUaJRsLGNunJtm8CLVOJE32q9/7nsEeswpcpibyEKb3/PU4cnu60XmnMy18lKdZ6S82wBMfWFFKbhulEJPjmxiUtRVq1O8LBDSfFv3n0HSQkmCiQwe7+9GsCOR1KYesukgM9iDT4EOQ/HvNig==;5:5kOi2LlCUg3JcPiZ7CIfR7M71Bg64dehLna8r/rqU5HyZSryODKyAqr2usc+R3aqgJQsStjD/h0y6wmgV6IWOTjBo7m4xJkZkBEtgFdFYO6foHpNNq68gHTt0ZUPI9ty8rZSe3xDyyEdk7D0U35UZQ==;24:TsjQBvCc0oWOZ+b/UjAfQpFor61OhTV0cwfnrCNcGMujaZDk8/eK8ZJM3Qs0g9e1zZ0XnCWOP61IWxKuPdBkhPNXPQhw405RO8pFfyry8RA=;7:jROCdF8q3dkHY1wnv/bOdbiZk9DRZz2SQ9kIJ5BrjigpZLe/ViK6csvFN+RGhGC7houEJRfGFITQCOOoPVAdb9xdPm/Mwju6WDbPHwnsPndvAvPJVkmuiaMB4Bg3vw94XrlFom37kmxzXuU7VJ6xX6E2Ndc0bEPiLrvhig9hrFrUalJpxIxbs6VGvl+gerGJFtyIKf8vm2G6JdJteWvSGjzrqpgCMLsbXrXcocz2OCk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;20:4o7+xV75/bwg/iarxE7Zg14C5LUZtgo+obO+qwAf4c/rmx6Hw4635yD5fosJr9ZgYRWG4n4JiNHkCQEQCzWTDjDbSXAmKDrPwPHtN4uFSDgyIrlZSV18pndILHiu2GopKkYC4LkYi+R3S71wlTFT96GZK8TsYmGNoAuTAXH/glJDFiF92ydlBAi5MJQzNy5FioYgljFrYWq9JbU/I30Bo4dKOPBAGjGOGxWN+cxHLS0xyFVyzqGZHhzlvrGjTwA0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 14:18:35.6951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2017 08:27 AM, Borislav Petkov wrote: ... > >> +/** >> + * struct sev_user_data_status - PLATFORM_STATUS command parameters >> + * >> + * @major: major API version >> + * @minor: minor API version >> + * @state: platform state >> + * @owner: self-owned or externally owned >> + * @config: platform config flags >> + * @build: firmware build id for API version >> + * @guest_count: number of active guests >> + */ >> +struct sev_user_data_status { >> + __u8 api_major; /* Out */ >> + __u8 api_minor; /* Out */ >> + __u8 state; /* Out */ >> + __u8 owner; /* Out */ >> + __u32 config; /* Out */ >> + __u8 build; /* Out */ >> + __u32 guest_count; /* Out */ >> +} __packed; >> + > > After yesterday's discussion about the sev_data_status layout, that > struct is not needed anymore, right? > Yes, we no longer need that structure. -Brijesh