From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA5163A2E02 for ; Tue, 12 May 2026 13:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778594318; cv=none; b=HsCk+j/c7YFwJM5lPVIpUJXxJgi8dZ6rIH7fQUazyzMBQsUINxtlx3BXs1elOXMGjzg20rppE00G0QElUV1xPzdc1GhXR5urAaGxWSr9kY3RsCN4FNOAoXBr0Brqt05Qnf93er6vqPzYQ+qMrgu8x2bR3xvT6UQQBryV/SqMd4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778594318; c=relaxed/simple; bh=beBaFWnPlfzZYXJ1j1qcJkPi/P6JOAav2skAWYAtYIs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PKaCq5DyIq3/Bl9IymRIXlAFNUL8ryH80BVu/eUYd4TiaZeLe6uz1VSzYbONzey2GqbizkbNYK5FLMZFKEyHwIwBEUYSCpGQZRuEoizrD4JcJDiDNQfmuNNC74NC/e2YLZd4VSQ9qfNsJp3OpL0CmYTT+q9oxSoWXjPnY+afCrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bvc7QX/0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z+JckVHu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bvc7QX/0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z+JckVHu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778594316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SO7uwB/59cp8ViAfTobce45IfmpXjuBRX6FFhYJ0cN8=; b=Bvc7QX/0nPZKmYMwro1Jtbg5ticGujRd9259A6f1RlQ+fFq9fIf8hSf+hrfK0C0tBvc5IW ZmOWqPyHnNH2hTS3CvZ8zgBGc0TUuj5Yh7a0he9PllOxHcB+xZJadR7SLWjDg5wQh1Dm/Z S88/CzaKblHEV3vXxTt9yXjzynp3zVo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-3ShovmE2PraBm93_W6Rf-w-1; Tue, 12 May 2026 09:58:32 -0400 X-MC-Unique: 3ShovmE2PraBm93_W6Rf-w-1 X-Mimecast-MFC-AGG-ID: 3ShovmE2PraBm93_W6Rf-w_1778594311 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48d0677b5f7so31498615e9.1 for ; Tue, 12 May 2026 06:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778594311; x=1779199111; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SO7uwB/59cp8ViAfTobce45IfmpXjuBRX6FFhYJ0cN8=; b=Z+JckVHun0brI6fyU7IB4ax+adM0D8DdoHpbGyoCtaKbgvvoj4GZRB2d4rjpUWjdXs LDeI1hYGE1OAS68OkT2coxO61YScWk9ZgLBDN6KfGLf3H0d81tk9PBlioUfWfVZa4WEz K43yvBX2v6GnGo0VZvaX+MQRoxWBtok8qj9UxzRHk1ia27fiw7LvQJC/W1LcrmN4zG3h jjXzyT7/BSi2DPJx5KvmFp5ocIvlQXu9cAy739LgLpURuqhwMSmJyc85AlG415AY7o5R kA78sceSXIAAghgNVv+UTguaklHyDN0o6oT153Fb0vsCxRrmEEKmQhgm9FSJJZmWfpRr mgiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778594311; x=1779199111; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SO7uwB/59cp8ViAfTobce45IfmpXjuBRX6FFhYJ0cN8=; b=HclQnB3LOmDRvntUQuFH6eWs6IYpZbp7SQLHR1IUEd2idruQKgBzaHKqEfl1MaV571 wAw8t6rox4oOLVoVmcphcuz4wejaKnNwGsxChGwq1nOLcFX1e5E2O+lYvTXfOnwEMFN0 Y9wTYjf5GA0frAURzG/zfkWTzCS+SkcFsVYfoKAblzEY8ZEmtpy4mzBnrXTXy0IlEsu3 sCx7mSLWyU3aZum74UaUS04hfzBL3KbqdJzz6SRHqdAOi7xBvXROZZGZ9+Q0XKqSY88h d6vlf0ewgt3gCNO2Ofzh7p8FPKx4B1hyrkQMbA6Ko0txm4kCEDHOu0WG/yecYCy3VMBR rE6A== X-Forwarded-Encrypted: i=1; AFNElJ/xxNI46cpN/9HAkvGwZZ9OKpAuOnQliGxeFHy7Ha8ik3jR/Xq+7ffmIWHXnXiYfJb7Uhf2G9ftxYNdCOs=@vger.kernel.org X-Gm-Message-State: AOJu0YzzCsYhC9hzmXjEacfDuWQBzS7NHmIBUXmR3eyXMXW+n0E+ETvk muQCkIDr9IEUBXbiSR994fvHZ+bHPX2yacCVJeDIZyWKCQiY0jkSdNuRgcLd1wk3V87EyiZ4b6U v+66sBeAt07GFkv0Mrk7ozeu5+g2tfZUGovLqXe1c63Bsz3D06eTAQfY8BbFepKpNAA== X-Gm-Gg: Acq92OG1fzFzZN2mupmKeycUutA3kihAsXZ9qh/SCacnMB3sabck2zORtdRMSAt11WZ ZfwH085E0ex4eTrVNPd7tjN7SHfVh5mV4JTSciPG/rVCbC7FgNowqYDQySTDlrhJRStxD3JdGKK cwydALYyibh3Z6i7POKb0HCTlyGVaNhJy6oNBTey1Ycqpx2x6YkFXjnzATokrdvnxzl+F3d+xuL 0P/jdoP12L7HPFMN7DRk/r6Ex7AroV2BJimBBL6OVwA6SY2+gz2+0Ib3to+cwMU68MX2V/KnycG P9k8S1Hiu7Ypmc+O516J30i2tFHucNxiEYa9SUy9dfJqXwJEWclVT/Fi8u7O0Dnf91NqvO7Jh3B jDadvsNHQwhADVH2i6NLAtVV/Il06X8B0c0dFCerGVdQAHFVvS5bZKDE= X-Received: by 2002:a05:600c:3f0f:b0:488:a797:f0ac with SMTP id 5b1f17b1804b1-48e9007290cmr51762965e9.28.1778594311077; Tue, 12 May 2026 06:58:31 -0700 (PDT) X-Received: by 2002:a05:600c:3f0f:b0:488:a797:f0ac with SMTP id 5b1f17b1804b1-48e9007290cmr51762245e9.28.1778594310452; Tue, 12 May 2026 06:58:30 -0700 (PDT) Received: from [192.168.88.32] ([216.128.9.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f41a8b1sm28490495e9.7.2026.05.12.06.58.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 06:58:29 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 15:58:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 1/2] net: pppoe: implement GRO/GSO support To: Qingfang Deng , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , David Ahern , Ido Schimmel , Kees Cook , Guillaume Nault , Eric Woudstra , Felix Fietkau , Willem de Bruijn , Kuniyuki Iwashima , Richard Gobert , Jiayuan Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-ppp@vger.kernel.org, Pablo Neira Ayuso , Alexander Lobakin References: <20260509030507.387050-1-qingfang.deng@linux.dev> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260509030507.387050-1-qingfang.deng@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/9/26 5:04 AM, Qingfang Deng wrote: > +static struct sk_buff *pppoe_gso_segment(struct sk_buff *skb, > + netdev_features_t features) > +{ > + struct sk_buff *segs = ERR_PTR(-EINVAL); > + struct packet_offload *ptype; > + struct pppoe_hdr *phdr; > + __be16 orig_type, type; > + int len, nhoff; > + > + skb_reset_network_header(skb); > + nhoff = skb_network_header(skb) - skb_mac_header(skb); > + > + if (unlikely(!pskb_may_pull(skb, PPPOE_SES_HLEN))) > + goto out; > + > + phdr = (struct pppoe_hdr *)skb_network_header(skb); > + type = pppoe_hdr_proto(phdr); > + ptype = gro_find_complete_by_type(type); > + if (!ptype) > + goto out; > + > + orig_type = skb->protocol; > + __skb_pull(skb, PPPOE_SES_HLEN); > + features &= ~(NETIF_F_TSO | NETIF_F_TSO6); As sashiko points out here you need to use NETIF_F_GSO_SOFTWARE. /P