From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7203F48822E; Fri, 18 Sep 2026 06:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789712916; cv=none; b=dQIfZaU9RZ8z3Nb7Mrhvkml3gqCLNv36U/6bFP96cdhoNzXFygx2BJHXR5/voqoNSSgL8odrXWFEez2sVSTMdFqttw5gjKuJ1S43n7vXKMmArvYgA48Nczuk+jLYBZIR4SXx4jSdz1pJBuNst9QlEXFUYr43t07sZHnrbiwks3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789712916; c=relaxed/simple; bh=b6XkBxPV5Sk+hjlETmNdvsAh0l3GGlqd79jQh+8GRZo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pgkO5GxkfRglxtQTC0n4IC5ak5WByVEFOBuZi8WXHkBT8LJ21YX9c/6LO+1CgCfzmPfod4WDm9wqdCQujXigGHSFOUBxXHj1vLwXPcaY8bXiDI3YMDzeybWvXzs4WkyNmUq2U+zJadYc7lG8+bSNQB7nHCL16tbkSVt2euiRAmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=c2PMFaP2; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="c2PMFaP2" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id AAD3E1A0966; Fri, 18 Sep 2026 06:28:30 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 79C7E60649; Fri, 18 Sep 2026 06:28:30 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D826811C7B021; Fri, 18 Sep 2026 08:28:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1789712909; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=YaeovCCcKo4LXDy70ugQFFbgV9Ov4ukWmKtdxBtxQ+w=; b=c2PMFaP2a+305bFeri5vtlqTR+1XwXfM/gXP6oKloXDIAu/G/wPE5IQKnaG4aJ8zkXArPV kyhhYv50l773fscKGmHA8H2tJBz3tW6WdrWkoXgq3Y6UGS8iF2wBfCYardyKZczx5DoCX4 bdRrfNyr9/dDtpq6jJsyFZ1VkPhW0tE0NjTDYNZ1b733PZR7SBVEMgeeIkGvsNpkn16oWg kPuVjf19HuCUK/f2+bRfy6FU5nwnefwKZG02zWQ4LSuz2zaXR1qiTbTEjsW3ixhtlH46po +olofKih/bQ4WOtvVtPAPjSyEwaVkjjBL/XjxM56BgPgAE7J3i5tBDNdEYD6QA== Message-ID: Date: Fri, 18 Sep 2026 08:28:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 3/3] net: stmmac: sun8i: add support for Allwinner H616 EMAC1 To: James Hilliard , Richard Genoud , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Coquelin Cc: Maxime Ripard , Alastair D'Silva , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20260917-submit-h616-emac1-v1-v3-0-62cb8316e19b@gmail.com> <20260917-submit-h616-emac1-v1-v3-3-62cb8316e19b@gmail.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260917-submit-h616-emac1-v1-v3-3-62cb8316e19b@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 9/17/26 19:55, James Hilliard wrote: > The H616 secondary EMAC uses a separate system-control clock register > and supports only RMII at 10/100 Mbps. It connects internally to the > co-packaged AC200 or AC300 EPHY and has no external PHY pins. > > Add an EMAC1 variant using the dedicated register and enable only RMII. > Leave PHY initialization to the PHY driver instead of using the H3 > internal-PHY controls. No RX or TX clock delays are configured for this > RMII-only variant. > > Co-developed-by: Richard Genoud > Signed-off-by: Richard Genoud > Signed-off-by: James Hilliard Reviewed-by: Maxime Chevallier Thanks :) Maxime > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index 4523a14f5e0c..1020168f1c3a 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -81,6 +81,13 @@ static const struct reg_field sun8i_syscon_reg_field = { > .msb = 31, > }; > > +/* EMAC1 clock register @ 0x34 in the "system control" address range */ > +static const struct reg_field sun8i_syscon_reg_field_emac1 = { > + .reg = 0x34, > + .lsb = 0, > + .msb = 31, > +}; > + > /* EMAC clock register @ 0x164 in the CCU address range */ > static const struct reg_field sun8i_ccu_reg_field = { > .reg = 0x164, > @@ -143,6 +150,13 @@ static const struct emac_variant emac_variant_h6 = { > .tx_delay_max = 7, > }; > > +static const struct emac_variant emac_variant_h616_emac1 = { > + .syscon_field = &sun8i_syscon_reg_field_emac1, > + /* The co-packaged AC200/AC300 PHY does not use the H3 PHY controls. */ > + .soc_has_internal_phy = false, > + .support_rmii = true, > +}; > + > #define EMAC_BASIC_CTL0 0x00 > #define EMAC_BASIC_CTL1 0x04 > #define EMAC_INT_STA 0x08 > @@ -1276,6 +1290,8 @@ static const struct of_device_id sun8i_dwmac_match[] = { > .data = &emac_variant_a64 }, > { .compatible = "allwinner,sun50i-h6-emac", > .data = &emac_variant_h6 }, > + { .compatible = "allwinner,sun50i-h616-emac1", > + .data = &emac_variant_h616_emac1 }, > { } > }; > MODULE_DEVICE_TABLE(of, sun8i_dwmac_match); >