From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3BAF367B73 for ; Sat, 25 Jul 2026 02:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784948334; cv=none; b=MO2MtfM3gEPTTpLkwBDEQhMjqy7KC3kVtj0sMT05S7uXd+IFn67nM6GtwrLmxDRU+WnJuv1YZ9oOEd1f3j5SgEixlizbeEHcBOCcovDCWbefPNt3MjbzJJ38eCZSUYysZ8Hr/OQaUUVBjVcZShcZ5+NoGrc2zHjsKujPFDQ/aiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784948334; c=relaxed/simple; bh=IyJOaFKHP5Z6JsgoSrdbBHiqOS2kFveNeppXWV+Qwkg=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=isDJWK7v2//WmMoS8bVjd1dvq4XmVzLs95ghhiq6csrFnu4wxGbj58VjMqjYzEDOWmjpkBey3qaqeczHYBmanI3s+e9my+QQGBa6eSCQg2qxK7SPW7L31vwjWcL0hvAR4UxkB5Unxv+5mwE1dixSF0yL7dLjdvANlfh/CqWpI+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1wnSb7-0000000030c-32Ro; Sat, 25 Jul 2026 02:58:45 +0000 Date: Sat, 25 Jul 2026 03:58:42 +0100 From: Daniel Golle To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Allen Chen , Hermes Wu , Pin-yen Lin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai Subject: [PATCH v6 04/13] drm/bridge: it6505: complete poweroff even if disabling regulators fails Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: it6505_poweroff() returns early when regulator_disable() fails, leaving it6505->powered set with the IRQ already disabled. The next it6505_poweron() then takes its early return and never re-enables the IRQ, leaving the bridge deaf to hotplug and link training interrupts. The regulator core keeps the consumer's enable count on a failed disable either way, so bailing out only adds a wedged bridge on top of the leaked reference. Log the error and complete the power-off state transition instead. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Signed-off-by: Daniel Golle --- v6: note that the regulator reference is leaked either way v5: new patch drivers/gpu/drm/bridge/ite-it6505.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index c10cc6a786b5..fb6030a2c18c 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -2811,13 +2811,15 @@ static int it6505_poweroff(struct it6505 *it6505) if (pdata->pwr18) { err = regulator_disable(pdata->pwr18); if (err) - return err; + dev_err(dev, "cannot disable pwr18 regulator: %d", + err); } if (pdata->ovdd) { err = regulator_disable(pdata->ovdd); if (err) - return err; + dev_err(dev, "cannot disable ovdd regulator: %d", + err); } it6505->powered = false; -- 2.55.0