From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7C4350A20 for ; Thu, 22 Jan 2026 09:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769074884; cv=none; b=XiYVNQ9uVX7nHwSGsRG4TI9wn2+aWisc8Y4cWrWUAg0wwRySO51OL6AJaiUCq9c8N6XVTn46wIpLwd8tBfvmhD7+ZQAEoQDS7AK7rXu00LVjl/FaI4/GpYA4ce3EoEyl3rmLXaUcAB9RT21LUjK+eGuR6zdJOZEKu2kxIcfv/70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769074884; c=relaxed/simple; bh=nyaNABROd7o7p8CvqbXZyR8TgZAtD/lO3Focy6AWrOk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DiQBv6+us9bOeqRhHMZeTmds8OupJxwefjZ7cPQ/iiFs+tzLiinhQ/W7NF1PztdhycmTaKhhYPM/HV/Wsm6vfg+I12QE1bInTIKB+Zd6FSMdqh/9NaSwNzyfGa4EtUI/gaDqwR3HK+V072pCS4ZCTGwmpmNBE07d0cnMIwt6tVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Cgq6e04q; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=H7UVtJcA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cgq6e04q"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="H7UVtJcA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769074881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ibHidGnmSWCLwRRmhNMKIRvOwyETyBrBfeoqUFQJa/s=; b=Cgq6e04qLfJbrsH2jBro8MEx4MKVNFPSxIKUkkLkZaYrIXAKB1zosR8q8T/4j3IgqkZXM3 E1MY48Jk+g3ptxRD1wr1t0BkBrEmL+eGFNxqW5JeppC9QE1XW1U7HHzZm/k2UQtVxR/Rjm aNruE8TBB9bo7+kWOBfhhPWb8B5+kYQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-CLIeptoMO-SC32b7i5cLDA-1; Thu, 22 Jan 2026 04:41:19 -0500 X-MC-Unique: CLIeptoMO-SC32b7i5cLDA-1 X-Mimecast-MFC-AGG-ID: CLIeptoMO-SC32b7i5cLDA_1769074879 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47ee3dd7fc8so7213155e9.3 for ; Thu, 22 Jan 2026 01:41:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769074879; x=1769679679; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ibHidGnmSWCLwRRmhNMKIRvOwyETyBrBfeoqUFQJa/s=; b=H7UVtJcA5GzoUL81KJhp8NIxnnvzNoIR1PZjhSNSfa3xk2vNHxkJwpCOYrHBR+3Tvr QcsoznsqURxDXkkcrqM7wCMHe9tbn9pNts+pySDDPW9R39TSQbLKQ8Z8F3L/x3YEcDlv D+wEVwSsPfnSb7mrcgudBYEFweGfXEyAuVPBltiKGmWrF9l8iVkp7tmAZkWBYi1XVcqN EjmOMLG1cxw0y0lfLTTY4ri3skwVG1lRriNDwdx5KNWheEyx+biuQZLgcfR8oWyFXFFy dML1soICw1zn2wr0IfQsuu4WQx9JZfns1ubwz1zb8VsQVbmWu1Z3ZWvHGJitI5Yaa++y J6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769074879; x=1769679679; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ibHidGnmSWCLwRRmhNMKIRvOwyETyBrBfeoqUFQJa/s=; b=Bh7YNTVMfabp8p3E7O7ayoqj4h+xfQDXShh7NriWW7tE45Gb5p04fVhJO5tgVHquxO rgEgYzR0f+dXKAZAqeWaU0lu/u8hUvWPMfP9vwQgRUWOdyYrHe20SqMmmEbscGOwvic1 q2Jwd++dR9IyvwKIS8+BcQ/AStKSqvzP5HDwVBnigUdQ0C7LBcnhvyyx1vwRIRRQJESX Am+t1vWB1xupit5TfNeqtCirAPaITZSEIr/gLmVR/tXVDNzeLZr+1ONM8M+dWowWKRS3 sACFjKlr8BkoDmDZZ5cMRhs1DsJyio06CJRoXEH/sVF39NBsUSZmwaIqDkLUYTNM8Q3R 5azg== X-Forwarded-Encrypted: i=1; AJvYcCUTa/wqDmv2V1GGtjhMAZijrkRh3SS94xS37DXcYVx542PYDqSV+UsyF6RMHJ+KtMsWlAphFOr3jGkjvQs=@vger.kernel.org X-Gm-Message-State: AOJu0YyDx9N54Tf+nu6W1Cziml0JGNI4YUgNvlQcq8gmwVcn4WKSWNu9 gGWSgb6Oyo9T017t5wVZm4YhdjureqzJ69B4vKe4xTe5NgTPAErsD2hGGEym3ypg4i/a6f9DQd9 LVHCG8lYDsDxI28SX+C/1wUo6QVymS4dP73nkfgq4t07IrDUj/USLy8Rgr0njkYXyPQ== X-Gm-Gg: AZuq6aLB4oQft+1vwYEg481VzXqs2f4+mT+y/4pwdSTlftzwIypPjbS5YKofkJKdqm8 tV51qg5EuvVeK3vtZsZ/elmCobGVf7asBPqhK8YEujO9+B/zXE8CTT0Zijkd267HQ2Z4PeT5Ehd 0eZN/N9qsBOdD6sv0Q48nLf6CDKNTMKUwQst+Ww7iTneH4wQIBjsO09pv3Q1xqNyYmfNJWhrcfu nXam5GTkpv+6qQdaIxwDwOt4tzOQhY2QmlBAIErNWm3BHV3JKpR+TTtlYLCdLgfQ5lVDPPHiLFF 10rqs5jWfnWUEb/u8+oSqdsB38X2V6cVbuVqHh4Q6QlIr1W3LJpCDYMIvl4h4nBRu2F5a3odhDc 1E+GUrvKhTdsG X-Received: by 2002:a05:600c:a11c:b0:480:1aae:676c with SMTP id 5b1f17b1804b1-4801eb0928bmr222203175e9.18.1769074878589; Thu, 22 Jan 2026 01:41:18 -0800 (PST) X-Received: by 2002:a05:600c:a11c:b0:480:1aae:676c with SMTP id 5b1f17b1804b1-4801eb0928bmr222202855e9.18.1769074878143; Thu, 22 Jan 2026 01:41:18 -0800 (PST) Received: from [192.168.88.32] ([216.128.11.175]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48046fba46dsm54385625e9.0.2026.01.22.01.41.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 01:41:17 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 10:41:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 1/3] net: dsa: yt921x: Fix MIB overflow wraparound routine To: David Yang , netdev@vger.kernel.org Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org, Dan Carpenter , David Laight References: <20260118013019.1078847-1-mmyangfl@gmail.com> <20260118013019.1078847-2-mmyangfl@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260118013019.1078847-2-mmyangfl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/18/26 2:30 AM, David Yang wrote: > Reported by the following Smatch static checker warning: > > drivers/net/dsa/yt921x.c:702 yt921x_read_mib() > warn: was expecting a 64 bit value instead of '(~0)' > > Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/netdev/aPsjYKQMzpY0nSXm@stanley.mountain/ > Suggested-by: David Laight > Signed-off-by: David Yang > --- > drivers/net/dsa/yt921x.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c > index 0b3df732c0d1..5e4e8093ba16 100644 > --- a/drivers/net/dsa/yt921x.c > +++ b/drivers/net/dsa/yt921x.c > @@ -682,21 +682,22 @@ static int yt921x_read_mib(struct yt921x_priv *priv, int port) > const struct yt921x_mib_desc *desc = &yt921x_mib_descs[i]; > u32 reg = YT921X_MIBn_DATA0(port) + desc->offset; > u64 *valp = &((u64 *)mib)[i]; > - u64 val = *valp; > u32 val0; > - u32 val1; > + u64 val; > > res = yt921x_reg_read(priv, reg, &val0); > if (res) > break; > > if (desc->size <= 1) { > - if (val < (u32)val) > - /* overflow */ > - val += (u64)U32_MAX + 1; > - val &= ~U32_MAX; > - val |= val0; > + u64 old_val = *valp; Why targeting net-next here? the blamed commit is already in Linus'tree and it looks like the above could causes functional issues, ad the wrong value is written into the mib. I think this should go via net. /P