mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: typec: fusb302: mark OF related data as maybe unused
Date: Mon, 13 Mar 2023 10:21:39 +0100	[thread overview]
Message-ID: <a5be6b0c-654f-0cfa-29ae-66f91ea4156a@linaro.org> (raw)
In-Reply-To: <ZA7q0PkvhB5i4CS8@kuha.fi.intel.com>

On 13/03/2023 10:20, Heikki Krogerus wrote:
> On Fri, Mar 10, 2023 at 11:29:37PM +0100, Krzysztof Kozlowski wrote:
>> The driver can be compile tested with !CONFIG_OF making certain data
>> unused:
>>
>>   drivers/usb/typec/tcpm/fusb302.c:1816:34: error: ‘fusb302_dt_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Should this be marked as a fix?
> 

It's a fix for compile test with W=1, so not a real issue.

Best regards,
Krzysztof


  reply	other threads:[~2023-03-13  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 22:29 [PATCH 1/2] usb: typec: hd3ss3220: Drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-10 22:29 ` [PATCH 2/2] usb: typec: fusb302: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-10 23:22   ` Guenter Roeck
2023-03-13  9:20   ` Heikki Krogerus
2023-03-13  9:21     ` Krzysztof Kozlowski [this message]
2023-03-10 23:22 ` [PATCH 1/2] usb: typec: hd3ss3220: Drop of_match_ptr for ID table Guenter Roeck
2023-03-13  9:19 ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5be6b0c-654f-0cfa-29ae-66f91ea4156a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®