From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B6C33261A for ; Fri, 27 Feb 2026 10:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772186616; cv=fail; b=W6iPMKxwUtglARsoKVW7JJCxnoM4DDvHB5G/3IWN0qxOTWth6NVdUB7qoX+yNWQEopVYItwS4ftN6xk5YZPxuYSAOYUf9fauYwY2EGQqRmCMu5ErPNRJoQrtvfeo9PMv7qxvwJDYvyzA6Vf6GvAbk6WgyAxvAP5yA9KsGWvBZgA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772186616; c=relaxed/simple; bh=iHk1roD45cHwdZmfyPlssw+Hf+QZfK5f/1xVcdT7bjw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=acZCgsOz2bcVeUcXQjcmf3XriRAl/JpDNfwitULKSuIkRjGbBKXK/QDBkW8KpbhXr2Bm4wOHlW8XEcijCgzY466QXgaaFNAtUXyHYUv6SLVtXNBh9VIF0HF5hR0smKqoSMxXhIXbO/io0iVh205AwuuthT579Z4ivsHYXJ7Geek= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=qLWQTNxt; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=Dx6P85l9; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="qLWQTNxt"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="Dx6P85l9" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R505wx2382702; Fri, 27 Feb 2026 04:03:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=FOPDEhbfyiuBHeKm1B+BXuXfc+i7K2SYL7sktW/nhVc=; b= qLWQTNxt15u/YgD3vv/s+ODOGQ52qRTc+OacOMeF61DVaCsMb1tTzN0W+nKRrP+3 2sPevD5pr7LVLNNz2IYnJCblkePnR9iOWEcQSXYh3HRqiIpW5akT4LFS47ekRC2V ulPwIPYb+nJU+OC1aR2kTGzwFcdSmKfU3yolSvUj5nk1V8Da+UcmUVZP7qAYvJV1 SQYxIYOCguKbXEI8pMANIGOs9g5Wyi0IY6L0oqahNeocGHliJYorNpo8e5HRY5fX 2WepgFIo6bWtyDCgFVWbhitf4EhoF34MVyckhuSFLx/NGgzbslgBeZfaF6ZiiZV5 +GP83Mt+MC6IJeikQnpuzA== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11023120.outbound.protection.outlook.com [40.107.201.120]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4cjmds1bbw-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 04:03:33 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rCRKYJakdMVJoqZjCxSQY4I+G4GfQ/+dKAvfousS8yv0/hViYepNKwe2Mz80pfL3pr7fXXuMjfrG64Pcdt25xpEv1yH6NUvC9fWTDTgQTgLifSTRh7IAjU42XZPMNPLDOz+6XjmADLTdhm8/ujAzGfXElElVSp7gsPm/Ms0QJ0NgKdTvejwZMIE0/LM1kp8Hy8jqIe+6bgwAYiCy52JzRL6h24qCksnjdCoi2CKqzYy+Vl/+R1w8rxROsX56JNm45AcoFsNcYcfq/SEmCoOQnCOSpTJQVvMI7+FvXsiS8kaXO73Kh3qHv55n3Xi6EqIHU8D36eaD7egB9zhCvEoD4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FOPDEhbfyiuBHeKm1B+BXuXfc+i7K2SYL7sktW/nhVc=; b=rVAtgHZpzDLIr8f2EPhmv8qKqgxqgfRw3X+rKXpQCjjgt7eMH9uaTUrHnx6cVOgEA0+yAc4totRxdnmcxOZWhqnJBVfDgiWgMsTlf962dG0kxltQBrh3ZzwKuszdLKKmnmpwj9xmyKhQkFfL9oT/J7fDrpdyZWK/PiOeGpFnHOB2yo3gmzyMIJ1L118MPI79fk1YAXQAqogGxAic//Ht95jPJq9fuQcuHEje5gJSHUXwvFf3JrQFE1JF2glZpONQKG+48mOs9Af+0sDTXr2ODDmgt31FQSHHzjLiUe3dUBrq03Hxc4ZrDmJOFgXfLDrkPij4hicubZMD9+ocY7E2LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FOPDEhbfyiuBHeKm1B+BXuXfc+i7K2SYL7sktW/nhVc=; b=Dx6P85l9RozT8RKiVKTTzmdnu9eX/MpL9Ey5YlYQI36hiwG7Pmlhs/DyhG9n0Fj40HOqYAdY5vFALXsIw2kmQ6ou89eEqa9U8IUWuSb1TsW3xeDtHo70AF1SToLxdM4gvFnMr8aGUZlW6iGXlU0F7LtjWzATZ7d9AolfzLn951E= Received: from PH7P220CA0017.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::9) by CY8PR19MB6964.namprd19.prod.outlook.com (2603:10b6:930:5c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Fri, 27 Feb 2026 10:03:30 +0000 Received: from SJ1PEPF000023D6.namprd21.prod.outlook.com (2603:10b6:510:326:cafe::51) by PH7P220CA0017.outlook.office365.com (2603:10b6:510:326::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Fri, 27 Feb 2026 10:03:24 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF000023D6.mail.protection.outlook.com (10.167.244.71) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.0 via Frontend Transport; Fri, 27 Feb 2026 10:03:29 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 7E965406541; Fri, 27 Feb 2026 10:03:27 +0000 (UTC) Received: from [198.90.208.24] (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 5D12C82024B; Fri, 27 Feb 2026 10:03:27 +0000 (UTC) Message-ID: Date: Fri, 27 Feb 2026 10:03:27 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_stop() To: Ziyi Guo , Simon Trimmer , Charles Keepax Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org References: <20260202144153.1668326-1-n7l8m4@u.northwestern.edu> Content-Language: en-GB From: Richard Fitzgerald In-Reply-To: <20260202144153.1668326-1-n7l8m4@u.northwestern.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D6:EE_|CY8PR19MB6964:EE_ X-MS-Office365-Filtering-Correlation-Id: 72561c17-57e9-4e85-2c73-08de75e77527 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|61400799027|82310400026|7053199007|54012099003; X-Microsoft-Antispam-Message-Info: Fc/VTtQmkd2J+0z1qAlppEBOg7qwYuFnutjzDP2nmJQoIM7oDi/8KriSQbP//nkiPZIcxGSoagSJZmznZE7AfC/OIVzVNXJ6D0AFqLuVPel53aKWixaF9Rd2Jom2arpQoCtlyZ6UhVfNjMV1OyW4cJkO8ZD6z2X1DX2J1aCwQG92NeP2w1CJXJj0mMIROaC+zEJ3K4uCE75QzV0RnpVWjx3l3k7meNMa62Z5UaIs+QsI9HOhe1rsHB9W5Gwn7udL4jGZBPX2nv8l/2vRrjsny+Y+V/4KWya5CZTIMVNd6Yh8crK3542TFCdrsb6KVL4vV61aY7mdW9z2pZYKZk84rZriTa+XMzU45HxAp40vlfciVsSQsjN+y8vbxT06eHT5LynHRnu3n+znKpc/ZYvW4FcKoUpSRpNa19gg5dCuXaff/sc9wqA05MRO1/rhqw2PlnZ1CJEx7xk28U3V/6I12nocrA41N/Eq6+9igPZAiN4WWvms2Fog+rBB9IQOoWK9AGb0Trtlo2q+D4r3TyZAJknIRaeXgAVIEYVbCuW8mxpf+JCmfHYziAOq3q0aU2krXM4kbpcY/e/N+BO9Jsza3cRrs14Mjw9INTuvg+nUh3F8qO44i1RmGhf1brqY+1GcIw1A4u2hAtKijfEOFQ22uASoxK8hWCw4p5DW9by+yBxTAFTJWxFZhgWhW6sNcedg4qAOQ9wF6uFWlvOPUgoFaOQVi5G7kRaPut0JViKMxWWfz1VByljhnSyScboKDMYAr9FzwcPt0W/gr2aAaUHuYNPnbXRLcibOVeC3HS5Y/OH3k7yapmNjKhitwY9nByQxShV1Zlx8jFJoSC/bWS96VA== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(61400799027)(82310400026)(7053199007)(54012099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LS0D1fZYg/oRhtQAv3CkAMDsTAjAJ5/uxUSJuMYBcGuFxP+OpbsAIax/fG4D0MVDyUqJJwobc814zlKUkZJfqk9w+Boy80DuIrqfpCWFGsZxMHy2Ln3tq7U56XU3IbQYBAAbVEplgTgkAdA91m2TgxzlHc56fjOmw8S8E5mVyhXrimBRup11Eok1CSM7zE5uaxxSXGEPaGOyshkR7VdQWtVyPL2DWY+FFFh3T5bSjcVzq2sbBUfYOFax9Br4qSyMBjHKdsRb4qtfnD/U+biuhtJg4VORIBfULME8BlS325I2eQ0nhXRGygzPFpji09Z+o7+WAnoSyhMNJgmTq5q0ANBBEcw8JSGn1RfqA02ekSL6/6wMWSP0vyeZS6LYz3aBeEpzDuiVLSk7oLWiKfxssReUkB2iDHAVJNH7MSXR1bmLrHVMSVGgkfLj/AgoKDJH X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 10:03:29.3237 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72561c17-57e9-4e85-2c73-08de75e77527 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ1PEPF000023D6.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR19MB6964 X-Authority-Analysis: v=2.4 cv=dO2rWeZb c=1 sm=1 tr=0 ts=69a16bf5 cx=c_pps a=l4k2vjVpr9fnFs3jNJfJ4g==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=VwQbUJbxAAAA:8 a=h82RxPqXzz0Ig2-r10MA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 5N4syAYMCC8XXvqJVY2LO5N_xTGGVytr X-Proofpoint-ORIG-GUID: 5N4syAYMCC8XXvqJVY2LO5N_xTGGVytr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDA4NSBTYWx0ZWRfX/vYohpwoZTw1 MvMmXo7ED/8w3LDhujkydM/ln6gwbO4qSj658h0i/DIXUSd1AL1ou1FImv274cofs5iTT9+oDZ2 khRLXzNNqk2b92g7EXGDltsOEHZ995zyYsCPtLpejsF8fcgm+TX9IXRdOl2y5Fglxh7wETfw04T 1PbjOR18GbapEPHXBByF1Nh+qAegWz3/s3b57mN8br3yg3i0Ol7Q3V/MlWKMb8rOVWqcWKdt0cQ spfZXRzCm2sVzb/++CZP0coxFbl3eqGQ3aj32nh4OOf2/uCc56edO5terHMpSi3Gzu2xJaRgc2b 7vNSNxV0Yl04CkrQ6qGOAyXUMFRVmdfRzjy6by98LL/HnmaaQ2fiT8Jl0cPG3t4cjE75F9ycrz9 YxkFMnWIx7ogxMYowyFgyfw+qXymJfssomm2f0fJOcqKq46D1WreP3gSaqiQ34Sm/ptaqhwG6v/ LmkHFn+Z8d8XGVXFkRg== X-Proofpoint-Spam-Reason: safe On 02/02/2026 2:41 pm, Ziyi Guo wrote: > cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control() > which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held. > > cs_dsp_signal_event_controls() is invoked from cs_dsp_stop(). > > Put mutex_lock() at the top of cs_dsp_stop() to fix the > missing lock protection, also align with cs_dsp_run(). > > Signed-off-by: Ziyi Guo > --- > v2: > - Put mutex_lock() at the top of cs_dsp_stop() to fix and align with cs_dsp_run() > You need to send this patch to Mark Brown and also add linux-sound@vger.kernel.org to your cc list