From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610EA26463F for ; Tue, 8 Apr 2025 07:41:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098098; cv=none; b=IOciDuCX7kVGQsGm2C2vA64MY5xk0wePZBHDzLHftMq4GUgjON2pv6b5y5zQY7FMsWnigqDDRqJR2HRJPB2nqXjzF8rVOEvEHwf9ACHOK/d68bIWrLziyglYYl620pxOiacYRWeDZ5HUKaJQOfhpZ7kRawPtK9KZUC0+UOnxPqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098098; c=relaxed/simple; bh=WFrbgnjtIdLegARnh8ZOz8cdARf39yPGWF1ZZYqL4Q0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=FgXkxashC0JWfwZE7OpRukVW7pyfHqV5eokEkDh4OG0Eg3egsI3B00L4HgBHdOXq3nE/K5SiLYMGUfHJQZDv7yfVulLFueoYER3R0xj7W0jQ4GYUaJUBXrq+M7ZaOe5gMAmJ4xCww8nymqV6cJO83YTPod5UR0uFBG2bU/QpmtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hmod+tMg; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hmod+tMg" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43cf680d351so36414595e9.0 for ; Tue, 08 Apr 2025 00:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744098094; x=1744702894; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XXt1VUtxJKVhenaGxKn/M7BRvobuDoOHV9yLu3KSCFE=; b=hmod+tMgF0WotVFTL+iHV4tKhgkjQpggj8li7esK8pax9yO5nnXw5YJeT27LFU3KoI XKEgAszIzLam3mb1tyqxO397uwfnI2Gk5EVVgXh4YQ8UnGf4yAyZwXNNmOkFyWm7eB0M ZWLSRx2XpAzbT0WCzUwoEFrzu9kmsw9KuT4amdr272Brmc4Gm3UkQqGfDyfpyujtyf/b AevnWpRIqegCFZ8+YOVoGAJPA4+0/YqIPe0zgFBb3NFfQEgIoGx4pa1m/oi3lRYRqUEq Pp9qeGxE1oCEfno/L7cD4Ggzs4HfcnL93tvYPGOCpLJAiJ5j6r0c3IlulZzRGexIZbS4 EQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744098095; x=1744702895; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XXt1VUtxJKVhenaGxKn/M7BRvobuDoOHV9yLu3KSCFE=; b=FDi50sGMMrVRyDh6fsrJpLtlVCSrYRytEPYU519kGYg3iImRziO44RXOOfYgRZ9HaK Z6FcWNUzghJTKELbUz0NyDZHy3TDMGw+5ScKzJtU1U20tdqHe6+MvxkCarooHAHZJ0Eq bX9GFATnosTQFGOfHb+hCnkhqQH1nYpf5Px/CYN8aDVaicT/XS06F8U7Ad/59owQuHn+ NzcAKZe2MlaK7W0h49IdDfQ/bebE4rA7jld7hNhzyRGJsw0sZT263w+4lG6jYRL5Oa5F Ss+AGb9jJjYedSmKBMkuegoeW7S8aiMS+hEY82v0iAs004/NvXywBa25C3p7M+f0eHPR xZMg== X-Forwarded-Encrypted: i=1; AJvYcCUXzV6gXwR9WApIGkhuHGxBQfe6wH93JHnp3KoFeBLJ1ofBm1I24qu/nId2BEGtYsPVO6M7c8cX0A4s/N8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1Z0q7StIdy4KoOoN8F+UUg5x8ou62rTrjabyf1VBm3AZ/G872 GxxqfLnjkHkC8mfnS6g63qm6bCeUaK80m/4z4/To8kWwNIDnNEoc14JFwU6Fru8= X-Gm-Gg: ASbGncs9WMa4qoWq+v6txaMBIQ4Z8W0l3MBh4KhN/taOfwtvaGLL3zoYSz0gZdMg2BD Mi7T893MmigcEKsCvfzcsrbiFr5SbSkZ7rKKVYOASiZw7zOcxQYVjvyKT7YKQZs1z8fTRsJ70uD lRpTAGtJDTKRFm4qCQMD/kbT9TQxwsLxgCmUbotHiN7emZ3DukOXsxdIwwNdLv0yGTWUJPGpEdx 1M5xmhLivN+NHRAz73RqW57K/Uiy8vAcDVS6O8EmA84kCSxxiWBWs4/w+/e0igsk+l8VmV/FiqY ZL4o1muyVvtyTEoULdzkYjpwRJOzp6CGCljS2qFsMDbzKRrnKi7owIQMNc92XuKQCsL+a/SW3Jn RJKvF3PkVYHMgy7dlJmCDkg== X-Google-Smtp-Source: AGHT+IGwV0LdqrELIcKaYg5qGdauKUw5ISrN3fxgvRHpkZn+vvc+/FEZS7JUbltTES57GokFyHQFlA== X-Received: by 2002:a05:6000:2cc:b0:391:952:c74a with SMTP id ffacd0b85a97d-39d820aca79mr1827989f8f.8.1744098094642; Tue, 08 Apr 2025 00:41:34 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:3daa:5b6d:6ccb:4c71? ([2a01:e0a:3d9:2080:3daa:5b6d:6ccb:4c71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c300968c4sm14179491f8f.9.2025.04.08.00.41.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Apr 2025 00:41:34 -0700 (PDT) Message-ID: Date: Tue, 8 Apr 2025 09:41:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 05/10] pinctrl: meson: use new GPIO line value setter callbacks To: Bartosz Golaszewski , Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> <20250408-gpiochip-set-rv-pinctrl-part1-v1-5-c9d521d7c8c7@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-5-c9d521d7c8c7@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/04/2025 09:17, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > struct gpio_chip now has callbacks for setting line values that return > an integer, allowing to indicate failures. Convert the driver to using > them. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/pinctrl/meson/pinctrl-meson.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c > index 253a0cc57e39..e7485c82089c 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson.c > +++ b/drivers/pinctrl/meson/pinctrl-meson.c > @@ -580,9 +580,9 @@ static int meson_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, > gpio, value); > } > > -static void meson_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) > +static int meson_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) > { > - meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); > + return meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); > } > > static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio) > @@ -616,7 +616,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc) > pc->chip.direction_input = meson_gpio_direction_input; > pc->chip.direction_output = meson_gpio_direction_output; > pc->chip.get = meson_gpio_get; > - pc->chip.set = meson_gpio_set; > + pc->chip.set_rv = meson_gpio_set; > pc->chip.base = -1; > pc->chip.ngpio = pc->data->num_pins; > pc->chip.can_sleep = false; > Reviewed-by: Neil Armstrong