From: Johannes Berg <johannes@sipsolutions.net>
To: Arnd Bergmann <arnd@kernel.org>,
Stanislav Yakovlev <stas.yakovlev@gmail.com>,
Kalle Valo <kvalo@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper
Date: Tue, 15 Oct 2024 09:45:55 +0200 [thread overview]
Message-ID: <a5c6a210cb6b83c7523b0e86b306a7cfa7e573fd.camel@sipsolutions.net> (raw)
In-Reply-To: <20241015073216.9443-1-arnd@kernel.org>
On Tue, 2024-10-15 at 07:32 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The lib80211 code uses arc4 crypto helpers that can be
> disabled:
>
> ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
> ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
>
> Select the library from Kconfig to ensure this can be called.
>
> Fixes: 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")
Right, sorry. I sent a similar one before:
https://lore.kernel.org/linux-wireless/20241011115820.070c468b271d.Iac76e81b5cd9a5b949b8c154381128e8131d581d@changeid/
> +++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
> @@ -6,6 +6,7 @@
> config IPW2100
> tristate "Intel PRO/Wireless 2100 Network Connection"
> depends on PCI && CFG80211
> + select CRYPTO_LIB_ARC4
>
I think this got to the wrong place?
johannes
next prev parent reply other threads:[~2024-10-15 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 7:32 Arnd Bergmann
2024-10-15 7:45 ` Johannes Berg [this message]
2024-10-15 8:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c6a210cb6b83c7523b0e86b306a7cfa7e573fd.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®