From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755093AbdJPUTp (ORCPT ); Mon, 16 Oct 2017 16:19:45 -0400 Received: from mout.web.de ([217.72.192.78]:54057 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbdJPUTo (ORCPT ); Mon, 16 Oct 2017 16:19:44 -0400 To: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Michal Simek , Nava kishore Manne , Rob Herring , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] xilinx_hwicap: Improve a size determination in hwicap_setup() Message-ID: Date: Mon, 16 Oct 2017 22:18:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:KIPaBEREtCSNHySFAFDeNnscM9wIP59OBqpXiDSvCin8CMGT7py WsOlIfC86mGEtUOuxlLpwpaio/6SqeTo9uKZg6mJpqQ9+d2zYewT5LMDGYUwc33ANhNPKmQ dT7ANDrFWGPiaM5tADrHJZhdsGg2hpB++9LlNA0tHZAhtx8IughQdVEFiDgKIBqFd5FYMC8 SLdid+wxS3VoD9XY9KYsw== X-UI-Out-Filterresults: notjunk:1;V01:K0:tbm5B+WTshc=:B0zwoJi+PQyUE9L5PWV/V1 R1dBhum/omw6vaAQv6awiIktc5yBe70Q/LqiCW5LaiLfyHMFzIflTI6/BaWnC/uMkVuf74/aF GfhWyzMl5YpOgYGPg6LWgLrNKrlMxl7kZ2/p4rxSIIMmIzy1eUG0aMiCHGer14TXfb5oqFaew xhYNEQjzF0gSvnCCzSvC2gbvADzd/dc2n1cZmJOrlhOk/HBmZZIH2NrFuhTu1NdFFB+WsPn3h s8ctoo0pzQfmjmsFr//QDAwaJ08r7TDtPlB4oRmSmzp5Tht+VyJcJ/gE3JYeI7SLAG5v0sAzF e46OvIslAzFGqo2Fwny58o1YBRIMU9h4htcQAeMHt4Yfb6lvtP7YHbRKRIj9V+9qzT1L7XHA2 4sIEEADv3E9WZ4wlf0FvJsPoJeYOX1/5qK6WFbRufH3uhKX6vP6ep0YkcnTWkmdPZPnItQaOQ ZMmgX9GuRi3KA3xPg0DSLpVzXDwG7PwSetcx87BIfdAxKIjS9GRduIcf/vkFExsdAbP2Y23ij 5WCclKgEiWA3bwfgs4W/GNlfnGPyS0nWrSz66MrEuMuJrEldLmuT/FAtmNn/3MVKidQklZNRS nAJ+OPxJQT9BecxGkV7dfft/8ts6cj/z5D/7/AZpUIdn0dkZuLFiLW5XFaHI2vPi0ZYKuGsuv 6/Esu+9vltUysp/ZRe/gcnOTfiW1OAjbstcks2+lf9HrxPV/EryjyhoIUeN3NpauYIMOhGSy8 P6G2RAwjoIggcjBfviJrsFUh14yEE1VmlUWjZDAWZ+URWl7NYyExsHVsoTSU+YKrH8sObuR7e BFqq9BjvWa0TXc3biTWedJPVGPdm+NnhXwxoDxXKrwb78msVWA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 16 Oct 2017 22:10:32 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/xilinx_hwicap/xilinx_hwicap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index 067396bedf22..2ab9df5a60bd 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -634,7 +634,7 @@ static int hwicap_setup(struct device *dev, int id, devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR + id); - drvdata = kzalloc(sizeof(struct hwicap_drvdata), GFP_KERNEL); + drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL); if (!drvdata) { retval = -ENOMEM; goto failed0; -- 2.14.2