From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 381D9369985 for ; Mon, 18 May 2026 13:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111721; cv=none; b=WpRBECGzSsMkli5pMz/k6n6905EZ2YWWodXSwSkvRx9ab7rX9HcuJi3eykPzSUKSMc7oWRFOE5i+2nvthVQJZ8UaypPT7EiV0pQpFym7Fduzpovv98VnYYzd3sb1cRnopUw2p73bHyRgWRmeGVBLl5GV9qEQVvgwRGDH+nJIkcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111721; c=relaxed/simple; bh=ERa9KGcfFMbzXPZhSgeHUPTZ1z2PRDKTu5+uRwX8ig4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VjZvnVAHpX0Ux6DwgBljws+hw2Y5EIl0WRGcas06PO+X2wbH7ls2hWK9OJQXwMQU9CTxugFu6DaxD135KvDcFmmIJ8gbsPLWYiJC3/1JmJDJHJ4wcvrCCPkap79a7jqqTY+zTAVlztLJWag6qtiIRwvt1Tw2YWRKlC9AxLzEpdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XvsvNBvh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ByUzD6m2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XvsvNBvh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ByUzD6m2" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IDbkS5353057 for ; Mon, 18 May 2026 13:41:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jOQ2L+lUTrqPio0b+Bre2mbX+LErk3gfKwpcIuQXOGQ=; b=XvsvNBvh+ImGM9dN EdvOrrKes25dpNpUss/uQAOFvfr0/xfL0bzSQ3sbYtXci5su81V//SSSZoBWRNlR jGFVn7vYFxOyaQ/GmY+rWyHbwWi/exKMmBUZAhCGJzWKBXLmdMRcz09KsmR/gY/Y hsYk+nlcDcNHpRZieUfsWMkOX2zxRdaVqZizSkz/jWPjiwqPKzglUG0Yq7qTEc5u KchQBnfbhuRleGWfJ1TIelvBETpmr8Nsrhzt2Q/WtZuYkqdpiBDRvFqFEltKgppX JjNt6ZPLNJIh089N7+TElhTnk3V8AKshR52I5SkxIuL9JiLLdB5kdtdjN12MAu98 ymo+dQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7xjahedj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 13:41:56 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d840206c3so8694051cf.3 for ; Mon, 18 May 2026 06:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779111716; x=1779716516; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jOQ2L+lUTrqPio0b+Bre2mbX+LErk3gfKwpcIuQXOGQ=; b=ByUzD6m2V8mFsGyOO/5HdD6LBStK3kwPBqYElt4RC24m9/Xq1pzy4HyrgJp44b3daN /han+fWIPmTiBco4I3Eo48Cy34gUUTu5bJKXG7Zlo+ZVknizzb+fyugMNYVEOUwFx/3Q OWnm936cCpk3cpEUTqlujL3GkQrbJ2pucBRfeMd+LqadCjElnkMSZ/AepCrHcIBZaxcn fQNg/WFHmjc/pz4LnIA1VdTFiBJi3HkuvQyFHaMNw4Swa/etPTtSqWA60YgCADqNXDrG oymIakd+hJKhnevfVgQC+ysTXbzvBq/9HHdpqzB8J7IZxOciMlqBxunA7as/7oVrjd1A kbsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779111716; x=1779716516; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jOQ2L+lUTrqPio0b+Bre2mbX+LErk3gfKwpcIuQXOGQ=; b=bCrBiH/s44jJyzojMoErTZrhJ8b+qgd1GR2HYHjhvRMDTDJ4dau5mFE9WbDoatpO2x b/bHzW4mAbVjvM/78O+itkAaP2fk1YPmkIcX3tOI+a47YQDbnEvnNTZ8mD6lWMK6NHhZ KjLErHgu99IjZgRAI+WkANnNRAEVjsf+VTFooaM6RRnKwOc161JpSfqfl6Rshz3o9dON uTLwTDcgWSnoJGJtZWamcv1/lxvXubvL41/Y8cN9eFvQ7WzCNS1F5WZCwm4UBq9pK+fD b8IV8r1DYhF3UPi9u57Btx7CCe+HjAu22tR+BKrqV4VvQb/o9m05lGeN4xY5G4it1Oj/ zwsA== X-Gm-Message-State: AOJu0YxypC0jVuMdhmgKGyupGzONDK3lDGqys1odhAOFzG4JwwfnNCfj j5k9q0MOHughDl01OtbKEeQvf4ijvSeSNNOd6GMR7NOy7xirn4g4Xhi8C+fyrKwq8Ll1kVkl2Uh c+O/jv2WDoA0LHQD6dGBrq1aDThiFXZab9Xx/vguv/vj7kqKypiS7+I6VvGyT6R6zmqE= X-Gm-Gg: Acq92OGFX0WBrI4FgOn9vpSz62GcNOCPdZeApz9e1D3pVPFg5Hb+2+VNp1BTQgp5dCG BbhBuKXBCan0sDSl+zrNipSQgqZ1P7MBZlthMhZepAGmr6OqJS9cpoQezNwVfElq6s7SyRGWzPM yEtp6TgeiNLYDAqZa33oG7q0/PIQitHSqDJDuYV81ywmJtDJaRaMEgVHJoafymoid4xnKzmg9zR dQ6+e7g/xLSzfNZTi6CMveOQTw2SX9X3VMCl+wk8P+HdtXCGXibt8i95kD9Tn1BeMQHq6jaAK1p NXJs3yQzvrw/HRDkqUZEWToYElZsozdzMQUdHvIWkgFMEntWb46ze+LFTznFEhzampS3u/m8E8j Td9jP4wsTPzF4vjxPnS9JW42y4TvB72OkTPcn2TcfjRGhekSva9QYAL9w8xcZf3vRDWaYQvtP6q t+fSw= X-Received: by 2002:a05:622a:111:b0:50d:5af1:65bb with SMTP id d75a77b69052e-5165a1e7299mr143825051cf.5.1779111715488; Mon, 18 May 2026 06:41:55 -0700 (PDT) X-Received: by 2002:a05:622a:111:b0:50d:5af1:65bb with SMTP id d75a77b69052e-5165a1e7299mr143824661cf.5.1779111715037; Mon, 18 May 2026 06:41:55 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4dea94bsm563155866b.33.2026.05.18.06.41.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 06:41:54 -0700 (PDT) Message-ID: Date: Mon, 18 May 2026 15:41:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] serial: qcom-geni: Add tracepoints for Qualcomm GENI serial driver To: Praveen Talari , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, Mukesh Kumar Savaliya , Aniket Randive , chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260512-add-tracepoints-for-qcom-geni-serial-v2-0-a5726421b3af@oss.qualcomm.com> <20260512-add-tracepoints-for-qcom-geni-serial-v2-2-a5726421b3af@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260512-add-tracepoints-for-qcom-geni-serial-v2-2-a5726421b3af@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDEzNCBTYWx0ZWRfX72Y4Y8He4ldA IXvPz4voyEECYkVeHMy7GX8nbGxOriNhh5b7m7ZuuWIZXkV9cFrCfHh59iOIj2iBYhiv9bOz8li NePAxp4i6d13gvGSzi7sTQr/xFopvoWQnrMUZFt+9rXzv6eK59boXiJZ18R1SOdeM64AQwFnHWt LDR34L0Q+hSd2sS/7Ydbu7IMfmkwo/M/o2GdC2Ipv4Fr9F5a+k55wI8rk4fpQ9Sl8L4k35Cd3GL 0XRXl44SPLlTV99WC8TJv4T+B5Re0zrPf+YP08VLdGOCx6tSFDnrxAkmQuhr0Ibd9QfZF2KcVej IHe3TxyvUueN9AKRZ3u7KIlRz/MXFo6zP7VLfGfHQW3T5X6gUJ9buO1KgS6HA8yEBNAJFs5KF6u dWBeqQzwtEkYsgipRHF9yjLxeQ4esSLdDyqDbEyzz7D2Y0kACUILWZI494yAkhwnwmMw5cqgK/7 hjxE0XfyKBd6CT0T7xQ== X-Authority-Analysis: v=2.4 cv=BYHoFLt2 c=1 sm=1 tr=0 ts=6a0b1724 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Vhne2ItbJHd0rvwzwroA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: eOXeThMyrZd_pdocvocbpw2vOrfIUExu X-Proofpoint-GUID: eOXeThMyrZd_pdocvocbpw2vOrfIUExu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180134 On 5/12/26 7:14 PM, Praveen Talari wrote: > Add tracing to the Qualcomm GENI serial driver to improve runtime > observability. > > Trace hooks are added at key points including termios and clock > configuration, manual control get/set, interrupt handling, and data > TX/RX paths. > > Usage examples: > > Enable all serial traces: > echo 1 > /sys/kernel/debug/tracing/events/qcom_geni_serial/enable > cat /sys/kernel/debug/tracing/trace_pipe > > Example trace output: > > 2517.938432: geni_serial_clk_cfg: a94000.serial: desired_rate=1843200 > clk_rate=7372800 clk_div=4 clk_idx=0 > 2517.938753: geni_serial_irq: a94000.serial: m_irq=0x88800000 > s_irq=0x08000111 dma_tx=0x00000000 dma_rx=0x00000000 > 2517.938803: geni_serial_set_termios: a94000.serial: baud=115200 bpc=8 > tx_trans=0x00000002 tx_par=0x00000000 rx_trans=0x00000000 > rx_par=0x00000000 stop=0 > 2517.938807: geni_serial_set_mctrl: a94000.serial: mctrl=0x8006 > uart_manual_rfr=0x00000000 > 2517.938818: geni_serial_get_mctrl: a94000.serial: mctrl=0x0160 > geni_ios=0x00000001 > 2517.939165: geni_serial_irq: a94000.serial: m_irq=0x00400000 > s_irq=0x00000000 dma_tx=0x00000000 dma_rx=0x00000000 > 2517.939592: geni_serial_tx_data: a94000.serial: tx_len=8 data=61 62 63 > 64 65 66 67 68 > 2517.940610: geni_serial_irq: a94000.serial: m_irq=0x00000001 > s_irq=0x00000000 dma_tx=0x00000003 dma_rx=0x00000000 > 2517.942174: geni_serial_irq: a94000.serial: m_irq=0x08000000 > s_irq=0x08000100 dma_tx=0x00000000 dma_rx=0x00000003 > 2517.942323: geni_serial_rx_data: a94000.serial: rx_len=8 data=61 62 63 > 64 65 66 67 68 > 2517.942680: geni_serial_set_mctrl: a94000.serial: mctrl=0x8000 > uart_manual_rfr=0x80000002 I think the example (or at least the data that it produces) could go under the --- line, there's plenty of docs regarding tracing on docs.kernel.org Reviewed-by: Konrad Dybcio Konrad