From: Danilo Krummrich <dakr@kernel.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: FUJITA Tomonori <fujita.tomonori@gmail.com>,
daniel.almeida@collabora.com, a.hindborg@kernel.org,
alex.gaynor@gmail.com, ojeda@kernel.org,
anna-maria@linutronix.de, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, frederic@kernel.org, gary@garyguo.net,
jstultz@google.com, linux-kernel@vger.kernel.org,
lossin@kernel.org, lyude@redhat.com,
rust-for-linux@vger.kernel.org, sboyd@kernel.org,
tglx@linutronix.de, tmgross@umich.edu
Subject: Re: [PATCH v2 2/2] rust: Add read_poll_count_atomic function
Date: Tue, 21 Oct 2025 18:02:39 +0200 [thread overview]
Message-ID: <a5cca6ca-9147-4531-81d8-05af1333848b@kernel.org> (raw)
In-Reply-To: <aPeTFMeVoIuo8Lur@google.com>
On 10/21/25 4:05 PM, Alice Ryhl wrote:
> On Tue, Oct 21, 2025 at 02:35:34PM +0200, Danilo Krummrich wrote:
>> Please replace the match statement with map().
>>
>> read_poll_count_atomic(
>> ...
>> )
>> .map(|_| ())
>>
>
> IMO, this should instead be:
>
> read_poll_count_atomic(
> ...
> )?
> Ok(())
I think map() has the advantage that it is a bit more explicit about the fact
that the return value is discarded intentionally.
But I'm fine with either version.
next prev parent reply other threads:[~2025-10-21 16:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 7:11 [PATCH v2 0/2] Add read_poll_count_atomic support FUJITA Tomonori
2025-10-21 7:11 ` [PATCH v2 1/2] rust: add udelay() function FUJITA Tomonori
2025-10-21 12:08 ` Danilo Krummrich
2025-10-21 14:39 ` Miguel Ojeda
2025-10-21 14:46 ` Danilo Krummrich
2025-10-21 14:58 ` Miguel Ojeda
2025-10-21 15:09 ` Danilo Krummrich
2025-10-21 15:13 ` Miguel Ojeda
2025-10-21 15:20 ` Danilo Krummrich
2025-10-22 10:32 ` FUJITA Tomonori
2025-10-22 14:11 ` Alice Ryhl
2025-10-23 5:19 ` FUJITA Tomonori
2025-10-24 8:23 ` Andreas Hindborg
2025-10-24 8:20 ` Andreas Hindborg
2025-10-24 9:27 ` Alice Ryhl
2025-10-24 19:05 ` Miguel Ojeda
2025-10-26 13:11 ` FUJITA Tomonori
2025-10-26 14:49 ` Miguel Ojeda
2025-10-21 7:11 ` [PATCH v2 2/2] rust: Add read_poll_count_atomic function FUJITA Tomonori
2025-10-21 12:35 ` Danilo Krummrich
2025-10-21 14:05 ` Alice Ryhl
2025-10-21 16:02 ` Danilo Krummrich [this message]
2025-10-22 11:27 ` FUJITA Tomonori
2025-10-24 8:25 ` Andreas Hindborg
2025-10-24 9:19 ` Alice Ryhl
2025-10-23 5:24 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5cca6ca-9147-4531-81d8-05af1333848b@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®